From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fernando Nasser To: Scott Bambrough Cc: GDB Patches Mail List Subject: Re: RFA: Testsuite patches... Date: Fri, 28 Jul 2000 13:43:00 -0000 Message-id: <3981F062.13C3373@cygnus.com> References: <39803B5C.9C31BB15@netwinder.org> <3981D53F.BE84EDCF@cygnus.com> <3981DCFE.9D99AB4F@netwinder.org> X-SW-Source: 2000-07/msg00356.html Scott Bambrough wrote: > > Fernando Nasser wrote: > > > > > 2000-07-26 Scott Bambrough > > > * gdb.base/environ.exp: Run tests for all targets. > > > > > > 2000-07-26 Scott Bambrough > > > > > > * linux-thread.c (linux_threads_pid_to_str): Change "Pid" to > > > "process" to allow gdb.base/environ.exp to pass all tests. > > > Change capitalization on "Thread" for consistency. > > > > > I forwarded the above change to the maintainers requesting their approval. > > These two need to go hand in hand, otherwise we get failures in environ.exp. I > sent a response to Michael Snyder's comments about this to him yesterday. I > just realized it didn't go to the list; so I forwarded it to the list as well. > I will wait to check these in until I hear about the change in linux-thread.c. > I'm also been thinking that maybe I shouldn't enable this for all targets, the > show/set/unset environment commands may fail on embedded targets. They should > work fine on any target that has an environment. The info program tests should > work on all targets. Maybe this test should be split up? Comments? > Good point. You can activate it just for native targets. if [is_remote target] skip the tests. -- Fernando Nasser Red Hat - Toronto E-Mail: fnasser@cygnus.com 2323 Yonge Street, Suite #300 Tel: 416-482-2661 ext. 311 Toronto, Ontario M4P 2C9 Fax: 416-482-6299 >From guo@cup.hp.com Fri Jul 28 13:49:00 2000 From: Jimmy Guo To: gdb-patches@sourceware.cygnus.com Subject: [PATCH] dejagnu lib/framework.exp Date: Fri, 28 Jul 2000 13:49:00 -0000 Message-id: X-SW-Source: 2000-07/msg00357.html Content-length: 1879 After picking up updates during the past ~30 days, gdb testing sporadically issues UNRESOLVED messages for test points that look perfectly fine (and there's no usual error / warning messages accompanying these UNRESOLVED messages). While I'm still scratching my head to root cause this annoyance, here is a patch to the only one of a tiny number of dejagnu updates that is questionable: compiler_conditional_xfail_data was made a global in 'proc fail' ... to be consistent 'proc pass' needs to do the same thing as well. However I'm not sure if somehow this would fix my problem ... Fri Jul 28 13:39:27 Jimmy Guo * lib/framework.exp (pass): make compiler_conditional_xfail_data a global, corresponding to a recent change to 'proc fail'. Index: lib/framework.exp /usr/local/bin/diff -c -L lib/framework.exp lib/framework.exp@@/main/cygnus/5 lib/framework.exp *** lib/framework.exp --- lib/framework.exp Fri Jul 28 13:38:25 2000 *************** *** 672,685 **** # Record that a test has passed # proc pass { message } { ! global xfail_flag # if we have a conditional xfail setup, then see if our compiler flags match ! if [uplevel {info exists compiler_conditional_xfail_data}] { ! if [uplevel {check_conditional_xfail $compiler_conditional_xfail_data}] { set xfail_flag 1 } ! uplevel {unset compiler_conditional_xfail_data} } if $xfail_flag { --- 672,685 ---- # Record that a test has passed # proc pass { message } { ! global xfail_flag compiler_conditional_xfail_data # if we have a conditional xfail setup, then see if our compiler flags match ! if [ info exists compiler_conditional_xfail_data ] { ! if [check_conditional_xfail $compiler_conditional_xfail_data] { set xfail_flag 1 } ! unset compiler_conditional_xfail_data } if $xfail_flag {