Re: RFA: Testsuite patches...

[Andrew Cagney <ac131313@cygnus.com>]

Um, careful here.

I don't think the question to ask is ``who will fix the failures''. 
Rather, I think people should be asking  ``does the test check correct
functionality''?

If the test is correct and applicable to more than just HP then I think
it should be enabled.  If it adds to the number of failures for certain
targets then ``oops'' :-)  I'd assume the relevant maintainers would
simply append this to their list of known problems.

Perhaphs post something like a transcript (assuming they are not to
large) of each test so people can see them in action.

As a generalization, GDB desperatly needs more tests.

	enjoy,
		Andrew
From ac131313@cygnus.com Thu Jul 27 20:59:00 2000
From: Andrew Cagney <ac131313@cygnus.com>
To: Dave Brolley <brolley@redhat.com>
Cc: gdb-patches@sourceware.cygnus.com
Subject: Re: [PATCH][RFA]: sim/common: Cpu Frequence and Exec Time
Date: Thu, 27 Jul 2000 20:59:00 -0000
Message-id: <398104FD.8FB4ACBE@cygnus.com>
References: <39806B05.96F0DA12@redhat.com>
X-SW-Source: 2000-07/msg00342.html
Content-length: 270

Dave,

This doesn't compile on the mn10300 (PROFILE_MODEL_TOTAL_CYCLES is only
defined when WITH_PROFILE_MODEL_P).  When making changes to sim/common,
it is a good idea to quickly re-compile (not test) a variant of each sim
so that this sort of thing shows up.

	Andrew
From ac131313@cygnus.com Fri Jul 28 00:17:00 2000
From: Andrew Cagney <ac131313@cygnus.com>
To: GDB Patches <gdb-patches@sourceware.cygnus.com>
Subject: [maint] target maintainers
Date: Fri, 28 Jul 2000 00:17:00 -0000
Message-id: <39813390.FD4535EF@cygnus.com>
X-SW-Source: 2000-07/msg00343.html
Content-length: 2188

Hello,

Appended is an updated target/architecture maintainer list.  I've gone
through and listed everything (I could never remember what was where).

I'd also like to propose that any target that doesn't have an active
maintainer be identified as ``maintenance only''.  All maintainers can
make mechanical changes to such targets (params, multi-arch, spelling,
indentation, -W....) - just as long as it still builds :-).  A
non-mechanical change would be something that needs to be tested.  Put
forward one of these and I'll make you the maintainer :-)

Wonder if this makes sense.

		Andrew

Target/Architecture:

Generic ISA (Instruction Set Architecture) issues, API variants, CPU
variants.  *-tdep.c. The Target/Architecture maintainer works with the
host maintainer when resolving build issues.  The Target/Architecture
maintainer works with the native maintainer when resolving API issues.

	a29k		maintenance only
	alpha		maintenance only
	arc		maintenance only

	arm		Fernando Nasser		fnasser@cygnus.com
			Jim Ingham		jingham@apple.com
			Scott Bambrough		scottb@netwinder.org

	convex		OBSOLETE

	d10v		Andrew Cagney		cagney@cygnus.com

	d30v		David Taylor		taylor@cygnus.com

	djgpp		(see native and host)

	fr30		maintenance only
	h8300		maintenance only
	h8500		maintenance only

	i386		Mark Kettenis           kettenis@gnu.org

	i960		maintenance only

	ia64		Kevin Buettner		kevinb@cygnus.com
	m32r		Michael Snyder		msnyder@cygnus.com

	m68hc11		maintenance only
	m68k		maintenance only
	m88k		maintenance only
	mcore		maintenance only

	mips		Andrew Cagney		cagney@cygnus.com

	mn10200		maintenance only

	mn10300		Andrew Cagney		cagney@cygnus.com

	ns32k		maintenance only

	pa		Jeff Law		law@cygnus.com

	powerpc		Kevin Buettner		kevinb@cygnus.com
			Elena Zannoni		ezannoni@cygnus.com

	pyramid		OBSOLETE

	romp		maintenance only
	rs6000		maintenance only

	sparc		David Taylor		taylor@cygnus.com

	tahoe		OBSOLETE

	tic80		maintenance only
	v850		maintenance only
	vax		maintenance only
	w65		maintenance only
	z8k		maintenance only

All maintainers can make changes to OBSOLETE targets.

All maintainers can make maintenance changes to ``maintenance only''
targets.
From guo@cup.hp.com Fri Jul 28 10:17:00 2000
From: Jimmy Guo <guo@cup.hp.com>
To: gdb-patches@sourceware.cygnus.com
Subject: [PATCH 1 of 2] readline rl_prompt corruption fix
Date: Fri, 28 Jul 2000 10:17:00 -0000
Message-id: <Pine.LNX.4.10.10007281012060.7566-100000@hpcll168.cup.hp.com>
X-SW-Source: 2000-07/msg00344.html
Content-length: 4043

This is part 1 of 2 patches to fix readline rl_prompt string corruption
problem.  This patch is for the readline library that readline will
store a copy of the passed in prompt string.  The next patch is for
gdb/event-top.c to plug a mem leak due to this change.

- Jimmy

Fri Jul 28 09:58:55	Jimmy Guo	<guo@cup.hp.com>

	* readline.c: Initalize globals rl_initialized rl_prompt.
	(readline): Use a copy of prompt instead of itself when
	assigning to rl_prompt in readline ().

	* callback.c (rl_callback_handler_install): Use a copy of
	prompt instead of itself when assigning to rl_prompt.
	
	* display.c: Initialize local_prompt and local_prompt_prefix.

Index: readline.c
/usr/local/bin/diff -c -w -L readline.c readline.c@@/main/cygnus/6 readline.c
*** readline.c
--- readline.c	Fri Jul 28 09:57:29 2000
***************
*** 119,125 ****
  int rl_arg_sign = 1;
  
  /* Non-zero means we have been called at least once before. */
! static int rl_initialized;
  
  /* If non-zero, this program is running in an EMACS buffer. */
  static int running_in_emacs;
--- 119,125 ----
  int rl_arg_sign = 1;
  
  /* Non-zero means we have been called at least once before. */
! static int rl_initialized = 0;
  
  /* If non-zero, this program is running in an EMACS buffer. */
  static int running_in_emacs;
***************
*** 153,159 ****
  int readline_echoing_p = 1;
  
  /* Current prompt. */
! char *rl_prompt;
  int rl_visible_prompt_length = 0;
  
  /* Set to non-zero by calling application if it has already printed rl_prompt
--- 153,159 ----
  int readline_echoing_p = 1;
  
  /* Current prompt. */
! char *rl_prompt = NULL;
  int rl_visible_prompt_length = 0;
  
  /* Set to non-zero by calling application if it has already printed rl_prompt
***************
*** 251,257 ****
  {
    char *value;
  
!   rl_prompt = prompt;
  
    /* If we are at EOF return a NULL string. */
    if (rl_pending_input == EOF)
--- 251,259 ----
  {
    char *value;
  
!   if (rl_prompt)
!     free (rl_prompt);
!   rl_prompt = prompt ? strdup (prompt) : 0;
  
    /* If we are at EOF return a NULL string. */
    if (rl_pending_input == EOF)
***************
*** 260,266 ****
        return ((char *)NULL);
      }
  
!   rl_visible_prompt_length = rl_expand_prompt (rl_prompt);
  
    rl_initialize ();
    (*rl_prep_term_function) (_rl_meta_flag);
--- 262,269 ----
        return ((char *)NULL);
      }
  
!   rl_visible_prompt_length = (rl_prompt && *rl_prompt) ?
!                              rl_expand_prompt (rl_prompt) : 0;
  
    rl_initialize ();
    (*rl_prep_term_function) (_rl_meta_flag);
Index: callback.c
/usr/local/bin/diff -c -w -L callback.c callback.c@@/main/cygnus/2 callback.c
*** callback.c
--- callback.c	Fri Jul 28 09:55:11 2000
***************
*** 81,88 ****
       char *prompt;
       VFunction *linefunc;
  {
!   rl_prompt = prompt;
!   rl_visible_prompt_length = rl_prompt ? rl_expand_prompt (rl_prompt) : 0;
    rl_linefunc = linefunc;
    _rl_callback_newline ();
  }
--- 81,91 ----
       char *prompt;
       VFunction *linefunc;
  {
!   if (rl_prompt)
!     free (rl_prompt);
!   rl_prompt = prompt ? strdup (prompt) : 0;
!   rl_visible_prompt_length = (rl_prompt && *rl_prompt) ?
!                              rl_expand_prompt (rl_prompt) : 0;
    rl_linefunc = linefunc;
    _rl_callback_newline ();
  }
Index: display.c
/usr/local/bin/diff -c -w -L display.c display.c@@/main/cygnus/7 display.c
*** display.c
--- display.c	Fri Jul 28 09:56:05 2000
***************
*** 146,152 ****
  /* Default and initial buffer size.  Can grow. */
  static int line_size = 1024;
  
! static char *local_prompt, *local_prompt_prefix;
  static int visible_length, prefix_length;
  
  /* The number of invisible characters in the line currently being
--- 146,152 ----
  /* Default and initial buffer size.  Can grow. */
  static int line_size = 1024;
  
! static char *local_prompt = NULL, *local_prompt_prefix = NULL;
  static int visible_length, prefix_length;
  
  /* The number of invisible characters in the line currently being