From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25149 invoked by alias); 24 May 2019 08:54:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25141 invoked by uid 89); 24 May 2019 08:54:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-23.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS,UNSUBSCRIBE_BODY autolearn=ham version=3.3.1 spammy=claiming, pumps, serial, wonders X-HELO: EUR04-DB3-obe.outbound.protection.outlook.com Received: from mail-eopbgr60052.outbound.protection.outlook.com (HELO EUR04-DB3-obe.outbound.protection.outlook.com) (40.107.6.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 May 2019 08:54:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XNaOhr5Z9ClJHS3O9N1e1X2VJiWzU9+Ft9O3Yb6pgmQ=; b=HmaoloyF8A1HyxsuYWaAIFV0prqhxx9jSDojR7+GAWuGpNVyzFNCvE3loe31LJ1sZYb77AiDuHbTmooURzqDsJ9ZMct/leYOJaL0y3RME4eDK6NazWbsvb2zXid7bksYgMXwyhbdf8nUoigfr8bf7O5w7QfoZgz0sBHYWzRm+5o= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) by DB6PR0802MB2488.eurprd08.prod.outlook.com (10.172.251.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1922.17; Fri, 24 May 2019 08:54:50 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::8c26:bb4b:6c93:9d40]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::8c26:bb4b:6c93:9d40%2]) with mapi id 15.20.1922.017; Fri, 24 May 2019 08:54:50 +0000 From: Alan Hayward To: Pedro Alves CC: Andrew Burgess , "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH] Supress SIGTTOU when handling errors Date: Fri, 24 May 2019 08:54:00 -0000 Message-ID: <3935437B-CD4F-4474-B84A-05859CE822DF@arm.com> References: <20190516155150.71826-1-alan.hayward@arm.com> <20190516180640.GS2568@embecosm.com> In-Reply-To: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-exchange-purlcount: 2 x-ms-oob-tlc-oobclassifiers: OLM:10000; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 Content-Type: text/plain; charset="utf-8" Content-ID: <7E1B459A735C634BA17AEA410F656F0C@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Alan.Hayward@arm.com X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00559.txt.bz2 DQoNCj4gT24gMjMgTWF5IDIwMTksIGF0IDIxOjMyLCBQZWRybyBBbHZlcyA8 cGFsdmVzQHJlZGhhdC5jb20+IHdyb3RlOg0KPiANCj4gT24gNS8xNi8xOSA3 OjA2IFBNLCBBbmRyZXcgQnVyZ2VzcyB3cm90ZToNCj4gDQo+PiBBcyBJIHVu ZGVyc3RhbmQgaXQgdGhlIHByb2JsZW0geW91J3JlIHNlZWluZyBjb3VsZCBi ZSByZXNvbHZlZCBieQ0KPj4gbWFraW5nIHN1cmUgdGhhdCB0aGUgdGVybWlu YWwgaXMgY29ycmVjdGx5IGNsYWltZWQgYnkgR0RCIGF0IHRoZSBwb2ludA0K Pj4gdGNkcmFpbiBpcyBjYWxsZWQuICBUaGlzIHdvdWxkIHJlcXVpcmUgYSBj YWxsIHRvIGVpdGhlcg0KPj4gJ3RhcmdldF90ZXJtaW5hbDo6b3VycyAoKScg b3IgJ3RhcmdldF90ZXJtaW5hbDo6b3Vyc19mb3Jfb3V0cHV0ICgpJy4NCj4+ IA0KPj4gSSd2ZSBtYWRlIHNldmVyYWwgYXR0ZW1wdHMgdG8gZml4IHRoaXMg aW4gdGhlIHBhc3QgKG5vbiBwb3N0ZWQNCj4+IHRob3VnaCksIG9uZSBwcm9i bGVtIEkndmUgcHJldmlvdXNseSBydW4gaW50byB0aGF0IEkndmUgbm90IHll dA0KPj4gdW5kZXJzdG9vZCBpcyB0aGF0IGNhbGxpbmcgOjpvdXJzX2Zvcl9v dXRwdXQgZG9lc24ndCBzZWVtIHRvIGJlIGVub3VnaA0KPj4gdG8gcHJldmVu dCB0aGUgU0lHVFRPVSAoSSBhc3N1bWUgZnJvbSB0aGUgdGNkcmFpbikgYW5k IG9ubHkgY2FsbGluZw0KPj4gOjpvdXJzIGlzIGVub3VnaC4NCj4+IA0KPj4g V2hhdCBJJ3ZlIGJlZW4gdHJ5aW5nIHRvIGZpZ3VyZSBvdXQgaXMgd2hhdCB0 aGUgaW50ZW5kZWQgZGlmZmVyZW5jZQ0KPj4gYmV0d2VlbiA6Om91cnNfZm9y X291dHB1dCBhbmQgOjpvdXJzIGFjdHVhbGx5IGlzLCANCj4gDQo+IFRoZSBw b2ludCBvZiBvdXJzX2Zvcl9vdXRwdXQgaXMgdGhhdCB3aGlsZSB0aGUgaW5m ZXJpb3IgaXMgc3RpbGwNCj4gcnVubmluZywgbGVhdmUgaXQgaW4gdGhlIGZv cmVncm91bmQsIHN1Y2ggdGhhdCBnZGIgZG9lc24ndCBpbnRlcmZlcmUNCj4g d2l0aCB0aGUgdGVybWluYWwgbW9kZSwgQ3RybC1DIHJlYWNoZXMgdGhlIGlu ZmVyaW9yIGRpcmVjdGx5LCBvciBzdWNoDQo+IHRoYXQgYW55IGtleWJvYXJk L3N0ZGluIGlucHV0IHR5cGVkIGJ5IHRoZSB1c2VyIGdvZXMgdG8gdGhlIGlu ZmVyaW9yDQo+IGRpcmVjdGx5LCBub3QgdG8gZ2RiLiAgVGhlIGxhdHRlciBp cyBwYXJ0aWN1bGFybHkgaW1wb3J0YW50IGZvciBhDQo+IGZvbGxvdyB1cCBz ZXJpZXMgSSB3YXMgd29ya2luZyBvbiBidXQgbmV2ZXIgZ290IGEgY2hhbmNl IHRvDQo+IHN1Ym1pdCwgaGVyZToNCj4gDQo+ICBodHRwczovL2dpdGh1Yi5j b20vcGFsdmVzL2dkYi9jb21taXRzL3BhbHZlcy90dHktYWx3YXlzLXNlcGFy YXRlLXNlc3Npb24NCj4gDQo+IFdpdGggdGhhdCBicmFuY2gsIGdkYiBhbHdh eXMgcHV0cyB0aGUgaW5mZXJpb3IgaW4gYSBzZXBhcmF0ZSBzZXNzaW9uLA0K PiBhbmQgdGhlbiBwdW1wcyBzdGRpbi9zdGRvdXQgYmV0d2VlbiB0aGUgaW5m ZXJpb3IncyB0dHkgYW5kIGdkYidzIHR0eQ0KPiBhdCB0aGUgcmlnaHQgdGlt ZXMuICBUaGF0IGJyYW5jaCBzb2x2ZXMgcHJvYmxlbXMgbGlrZSBub3QgYmVp bmcgYWJsZQ0KPiB0byBDdHJsLUMgd2hpbGUgdGhlIGluZmVyaW9yIGlzIGJs b2NrZWQgaW4gc2lnd2FpdCB3aXRoIFNJR0lOVCBibG9ja2VkDQo+IChnZGIv MTQ1NTksIGdkYi85NDI1KS4gIFRoYXQncyB0aGUgZml4IEkgbWVudGlvbmVk IGluIHRoZSBjb21taXQgbG9nDQo+IG9mIGU2NzFjZDU5ZDc0Yy4gIEFueXdh eSwgd2l0aCB0aGF0IGJyYW5jaCwgaWYgd2Ugc3dpdGNoIHRvIG91cnMoKSB3 aGlsZQ0KPiB0aGUgaW5mZXJpb3IgaXMgcnVubmluZyBpbiB0aGUgZm9yZWdy b3VuZCwgdGhlbiB3ZSBtaXNzIGZvcndhcmRpbmcgdGhlDQo+IGlucHV0IHRv IHRoZSBpbmZlcmlvci4gIFNlZToNCj4gDQo+IGh0dHBzOi8vZ2l0aHViLmNv bS9wYWx2ZXMvZ2RiL2Jsb2IvZDMzOTJiODMwODZiMGE1NDFhYTMxZmNmZjMw MTI4MWRhN2E3M2EwZS9nZGIvaW5mbG93LmMjTDc2Mg0KPiANCj4gQWxzbywg aWYgd2UgbWlzcyBjYWxsaW5nIG91cnNfZm9yX291dHB1dCgpLCB0aGVuIHdl IHByaW50IG91dHB1dCB0byB0aGUNCj4gdGVybWluYWwgaW4gcmF3IG1vZGUu ICBXaGF0IEknbSBzYXlpbmcgaXMgdGhhdCB0aGF0IGJyYW5jaC9maXggZXhw b3Nlcw0KPiBtb3JlIGxhdGVudCBidWdzIGFyb3VuZCBpbmNvcnJlY3Qgb3Vy cygpL291cnNfZm9yX291dHB1dCgpL2luZmVyaW9yKCkNCj4gaGFuZGxpbmcs IGFuZCB0aGUgYnJhbmNoIGluY2x1ZGVzIGZpeGVzIGluIHRoYXQgZGlyZWN0 aW9uLCBlLmcuOiB0aGUgDQo+ICJ0YXJnZXRfdGVybWluYWw6Om91cnNfZm9y X291dHB1dCgpOiByZWNlaXZlZCBTSUdJTlQiIHBhdGNoLg0KPiANCj4gVGhp cyBpcyBub3QgdW5saWtlIHdoYXQgb2xkIGNvbW1lbnQgaW4gcmVtb3RlLmMg c3VnZ2VzdHMgd2UgY291bGQNCj4gZG8sIGJ1dCBmb3IgbG9jYWwgZGVidWdn aW5nOg0KPiANCj4gc3RhdGljIHZvaWQNCj4gcmVtb3RlX3Rlcm1pbmFsX2lu ZmVyaW9yIChzdHJ1Y3QgdGFyZ2V0X29wcyAqc2VsZikNCj4gew0KPiAgLyog Tk9URTogQXQgdGhpcyBwb2ludCB3ZSBjb3VsZCBhbHNvIHJlZ2lzdGVyIG91 ciBzZWx2ZXMgYXMgdGhlDQo+ICAgICByZWNpcGllbnQgb2YgYWxsIGlucHV0 LiAgQW55IGNoYXJhY3RlcnMgdHlwZWQgY291bGQgdGhlbiBiZQ0KPiAgICAg cGFzc2VkIG9uIGRvd24gdG8gdGhlIHRhcmdldC4gICovDQo+IH0NCj4gDQo+ IA0KPj4gaWYgd2UgY2FuJ3QgYWx3YXlzDQo+PiB3cml0ZSBvdXRwdXQgYWZ0 ZXIgY2FsbGluZyA6Om91cnNfZm9yX291dHB1dC4gIFBhcnQgb2YgbWUgd29u ZGVycyBpZg0KPj4gd2Ugc2hvdWxkIGp1c3Qgc3dpdGNoIHRvIHVzaW5nIDo6 b3VycyBpbiBhbGwgY2FzZXMuLi4uDQo+IA0KPiBJJ20gdGhpbmtpbmcgdGhh dCBBbGFuJ3Mgb3JpZ2luYWwgcGF0Y2ggdG8gZGlzYWJsZSBTSUdUVE9VIGlz IGNvcnJlY3QuDQo+IFdoZW4gd2UncmUgaW4gb3Vyc19mb3Jfb3V0cHV0IG1v ZGUsIHdlIHNob3VsZCBiZSBhYmxlIHRvIHdyaXRlIHRvIHRoZQ0KPiB0ZXJt aW5hbCwgYW5kIHdlIGNhbi4gIEJ1dCwgdGhlcmUgYXJlIGEgY291cGxlIGZ1 bmN0aW9ucyB0aGF0IHJhaXNlDQo+IGEgU0lHVFRPVSBpZiB5b3Ugd3JpdGUg dG8gdGhlIGNvbnRyb2xsaW5nIHRlcm1pbmFsIHdoaWxlIGluIHRoZQ0KPiBi YWNrZ3JvdW5kLCBhbmQgeW91ciB0ZXJtaW5hbCBoYXMgdGhlIFRPU1RPUCBh dHRyaWJ1dGUgc2V0LCBhbmQgdGNkcmFpbg0KPiBpcyBvbmUgb2YgdGhlbS4g IA0KDQoNCkxvb2tpbmcgYmFjayBhdCBteSBvcmlnaW5hbCBwYXRjaCBhZ2Fp biwgSeKAmW0gd29uZGVyaW5nIGlmIGl04oCZcyBiZXR0ZXIgdG8NCm1vdmUg dGhlIGlnbm9yZSBoaWdoZXIgdXAgdGhlIGNhbGwgc3RhY2sgaW4gcHJpbnRf Zmx1c2gsIHNvIHRoYXQgaXTigJlzIHNldA0KYWNyb3NzIGJvdGggZmx1c2hl czoNCg0KDQpkaWZmIC0tZ2l0IGEvZ2RiL2V4Y2VwdGlvbnMuYyBiL2dkYi9l eGNlcHRpb25zLmMNCmluZGV4IGViZGM3MWQ5OGQuLmNiYTZkNzhiMGIgMTAw NjQ0DQotLS0gYS9nZGIvZXhjZXB0aW9ucy5jDQorKysgYi9nZGIvZXhjZXB0 aW9ucy5jDQpAQCAtMzIsNDAgKzMyLDQ0IEBADQogc3RhdGljIHZvaWQNCiBw cmludF9mbHVzaCAodm9pZCkNCiB7DQogICBzdHJ1Y3QgdWkgKnVpID0gY3Vy cmVudF91aTsNCiAgIHN0cnVjdCBzZXJpYWwgKmdkYl9zdGRvdXRfc2VyaWFs Ow0KDQogICBpZiAoZGVwcmVjYXRlZF9lcnJvcl9iZWdpbl9ob29rKQ0KICAg ICBkZXByZWNhdGVkX2Vycm9yX2JlZ2luX2hvb2sgKCk7DQoNCiAgIGdkYjo6 b3B0aW9uYWw8dGFyZ2V0X3Rlcm1pbmFsOjpzY29wZWRfcmVzdG9yZV90ZXJt aW5hbF9zdGF0ZT4gdGVybV9zdGF0ZTsNCiAgIC8qIFdoaWxlIG5vcm1hbGx5 IHRoZXJlJ3MgYWx3YXlzIHNvbWV0aGluZyBwdXNoZWQgb24gdGhlIHRhcmdl dA0KICAgICAgc3RhY2ssIHRoZSBOVUxMIGNoZWNrIGlzIG5lZWRlZCBoZXJl IGJlY2F1c2Ugd2UgY2FuIGdldCBoZXJlIHZlcnkNCiAgICAgIGVhcmx5IGR1 cmluZyBzdGFydHVwLCBiZWZvcmUgdGhlIHRhcmdldCBzdGFjayBpcyBmaXJz dA0KICAgICAgaW5pdGlhbGl6ZWQuICAqLw0KICAgaWYgKGN1cnJlbnRfdG9w X3RhcmdldCAoKSAhPSBOVUxMICYmIHRhcmdldF9zdXBwb3J0c190ZXJtaW5h bF9vdXJzICgpKQ0KICAgICB7DQogICAgICAgdGVybV9zdGF0ZS5lbXBsYWNl ICgpOw0KICAgICAgIHRhcmdldF90ZXJtaW5hbDo6b3Vyc19mb3Jfb3V0cHV0 ICgpOw0KICAgICB9DQoNCisgICAvKiBJZ25vcmUgU0lHVFRPVSB3aGljaCBt YXkgb2NjdXIgZHVyaW5nIHRoZSBkcmFpbiBkdWUgdG8gdGhlIHRlcm1pbmFs IGJlaW5nDQorICAgICAgaW4gdGhlIGJhY2tncm91bmQuICAqLw0KKyAgIHNj b3BlZF9pZ25vcmVfc2lndHRvdSBpZ25vcmVfc2lndHRvdTsNCisNCiAgIC8q IFdlIHdhbnQgYWxsIG91dHB1dCB0byBhcHBlYXIgbm93LCBiZWZvcmUgd2Ug cHJpbnQgdGhlIGVycm9yLiAgV2UNCiAgICAgIGhhdmUgMyBsZXZlbHMgb2Yg YnVmZmVyaW5nIHdlIGhhdmUgdG8gZmx1c2ggKGl0J3MgcG9zc2libGUgdGhh dA0KICAgICAgc29tZSBvZiB0aGVzZSBzaG91bGQgYmUgY2hhbmdlZCB0byBm bHVzaCB0aGUgbG93ZXItbGV2ZWwgb25lcw0KICAgICAgdG9vKTogICovDQoN CiAgIC8qIDEuICBUaGUgX2ZpbHRlcmVkIGJ1ZmZlci4gICovDQogICBpZiAo ZmlsdGVyZWRfcHJpbnRpbmdfaW5pdGlhbGl6ZWQgKCkpDQogICAgIHdyYXBf aGVyZSAoIiIpOw0KDQogICAvKiAyLiAgVGhlIHN0ZGlvIGJ1ZmZlci4gICov DQogICBnZGJfZmx1c2ggKGdkYl9zdGRvdXQpOw0KICAgZ2RiX2ZsdXNoIChn ZGJfc3RkZXJyKTsNCg0KICAgLyogMy4gIFRoZSBzeXN0ZW0tbGV2ZWwgYnVm ZmVyLiAgKi8NCiAgIGdkYl9zdGRvdXRfc2VyaWFsID0gc2VyaWFsX2Zkb3Bl biAoZmlsZW5vICh1aS0+b3V0c3RyZWFtKSk7DQogICBpZiAoZ2RiX3N0ZG91 dF9zZXJpYWwpDQogICAgIHsNCiAgICAgICBzZXJpYWxfZHJhaW5fb3V0cHV0 IChnZGJfc3Rkb3V0X3NlcmlhbCk7DQogICAgICAgc2VyaWFsX3VuX2Zkb3Bl biAoZ2RiX3N0ZG91dF9zZXJpYWwpOw0KICAgICB9DQoNCg0KLi4ub3IgaWYg aXQgcmVhbGx5IHNob3VsZCBiZSBsZWZ0IGp1c3QgYXJvdW5kIHRoZSB0Y2Ry YWluLg0KTm90IHF1aXRlIHN1cmUgd2hhdCB0aGUgYmVoYXZpb3VyIGlzIG9u IG5vbi1MaW51eCB0YXJnZXRzLg0KDQoNCj4gDQo+IFRoYXQgaXNuJ3QgdG8g c2F5IHRoYXQgeW91ciBwYXRjaCBfaXNuJ3RfIGFsc28gY29ycmVjdC4gIFdl IGhhdmUgbWFueQ0KPiBsYXRlbnQgYnVncyBhcm91bmQgdGhpcyBhcmVhLiAg TGV0IG1lIHRha2UgYSBiZXR0ZXIgbG9vayBhdCB0aGF0IG9uZSB0b28uDQo+ IA0KPiBJIHRoaW5rIHRoYXQgZXZlbiBpZiB3ZSBnZXQgc29tZXRoaW5nIGxp a2UgeW91ciBwYXRjaCBpbiwgdGhlbg0KPiBBbGFuJ3MgaXMgc3RpbGwgY29y cmVjdCBiZWNhdXNlIHdlIGNhbiBoYXZlIHBsYWNlcyBkb2luZw0KPiB0cnkv Y2F0Y2ggdG8gc3dhbGxvdyBhbiBlcnJvciBidXQgc3RpbGwgcHJpbnQgaXQg d2l0aCBleGNlcHRpb25fcHJpbnQsDQo+IGFsbCB3aGlsZSB0aGUgaW5mZXJp b3IgaXMgcnVubmluZy4gIE9mIGNvdXJzZSBzdWNoIHNwb3RzIHNob3VsZA0K PiBjYWxsIG91cnNfZm9yX291dHB1dCgpLCBidXQgdGhhdCB3aWxsIHJ1biBp bnRvIHRoZSB0Y2RyYWluIGlzc3VlLg0KPiANCg0KTWlub3IgaXNzdWUgaXMg dGhhdCBvbmNlIG15IHBhdGNoIGlzIGluLCBpdOKAmWxsIGhpZGUgdGhlIG1p c3Npbmcgb3Vyc19mb3Jfb3V0cHV0DQpidWdzICg/KQ0KDQo+IA0KPj4gDQo+ PiBBbnl3YXksIEkgdGhpbmsgbW9zdCBvZiB0aGUgcHJvYmxlbXMgeW91J3Jl IHNlZWluZyBzaG91bGQgYmUgZml4ZWQgYnkNCj4+IGNsYWltaW5nIHRoZSB0 ZXJtaW5hbCBlaXRoZXIgcGVybWFuZW50bHkgKGNhbGxpbmcgOjpvdXJzIG9y DQo+PiA6Om91cnNfZm9yX291dHB1dCkgb3IgdGVtcG9yYXJpbHkgdXNpbmcN Cj4+IHRhcmdldF90ZXJtaW5hbDo6c2NvcGVkX3Jlc3RvcmVfdGVybWluYWxf c3RhdGUuDQo+PiANCj4+IExpa2UgSSBzYWlkLCBJJ20gbm90IGFuIGV4cGVy dCBvbiB0aGlzIGNvZGUsIHNvIG1heWJlIEkndmUNCj4+IG1pc3VuZGVyc3Rv b2QgdGhlIHByb2JsZW0geW91J3JlIHNvbHZpbmcuDQo+PiANCj4gDQo+IFRo YW5rcywNCj4gUGVkcm8gQWx2ZXMNCg0K >From gdb-patches-return-156328-listarch-gdb-patches=sources.redhat.com@sourceware.org Fri May 24 11:02:57 2019 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 49745 invoked by alias); 24 May 2019 11:02:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 49736 invoked by uid 89); 24 May 2019 11:02:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=suppression, screen X-HELO: mail-wr1-f66.google.com Received: from mail-wr1-f66.google.com (HELO mail-wr1-f66.google.com) (209.85.221.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 May 2019 11:02:55 +0000 Received: by mail-wr1-f66.google.com with SMTP id m3so9565941wrv.2 for ; Fri, 24 May 2019 04:02:55 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:4eeb:42ff:feef:f164? ([2001:8a0:f913:f700:4eeb:42ff:feef:f164]) by smtp.gmail.com with ESMTPSA id h17sm2508373wrq.79.2019.05.24.04.02.52 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 24 May 2019 04:02:52 -0700 (PDT) Subject: Re: [PATCH] Supress SIGTTOU when handling errors To: Alan Hayward References: <20190516155150.71826-1-alan.hayward@arm.com> <20190516180640.GS2568@embecosm.com> <3935437B-CD4F-4474-B84A-05859CE822DF@arm.com> Cc: Andrew Burgess , "gdb-patches@sourceware.org" , nd From: Pedro Alves Message-ID: <7483f478-44d2-b2ce-b0cb-3e984054305a@redhat.com> Date: Fri, 24 May 2019 11:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <3935437B-CD4F-4474-B84A-05859CE822DF@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2019-05/txt/msg00560.txt.bz2 Content-length: 2427 On 5/24/19 9:54 AM, Alan Hayward wrote: > Looking back at my original patch again, I’m wondering if it’s better to > move the ignore higher up the call stack in print_flush, so that it’s set > across both flushes: What are the two flushes? I only see one, from the serial_drain_output call? In any case, I think it's better to keep the SIGTTOU handling close to the tcdrain call, to make to code a lot more obvious -- SIGTTOU suppression is described in tcdrain manuals -- and I don't think we have to worry about efficiency here? > ...or if it really should be left just around the tcdrain. > Not quite sure what the behaviour is on non-Linux targets. The behavior should be the same on all POSIX systems: https://pubs.opengroup.org/onlinepubs/009695399/functions/tcdrain.html "Any attempts to use tcdrain() from a process which is a member of a background process group on a fildes associated with its controlling terminal, shall cause the process group to be sent a SIGTTOU signal. If the calling process is blocking or ignoring SIGTTOU signals, the process shall be allowed to perform the operation, and no signal is sent." On non-POSIX systems, the serial_drain_output call doesn't end up in ser-unix.c:hardwire_drain_output, so from that perspective, putting the SIGTTOU suppression in common code is a bit of an abstraction violation. > > >> >> That isn't to say that your patch _isn't_ also correct. We have many >> latent bugs around this area. Let me take a better look at that one too. >> >> I think that even if we get something like your patch in, then >> Alan's is still correct because we can have places doing >> try/catch to swallow an error but still print it with exception_print, >> all while the inferior is running. Of course such spots should >> call ours_for_output(), but that will run into the tcdrain issue. >> > > Minor issue is that once my patch is in, it’ll hide the missing ours_for_output > bugs (?) > Sure. But we shouldn't avoid fixing one bug because of that. The palves/tty-always-separate-session branch on my github exposes such bugs because with a missing ours_for_output call, gdb prints to the screen while the terminal is in raw mode, resulting in output like this is line one this is line two this is line three instead of: this is line one this is line two this is line three Thanks, Pedro Alves