From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id 5A7623858D34 for ; Thu, 18 Jun 2020 20:00:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5A7623858D34 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-494-m81awf07POmban_OH51cnQ-1; Thu, 18 Jun 2020 16:00:10 -0400 X-MC-Unique: m81awf07POmban_OH51cnQ-1 Received: by mail-wm1-f71.google.com with SMTP id q7so2073033wmj.9 for ; Thu, 18 Jun 2020 13:00:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/k1Nyhoon/IxLd0K1UgAIxF8QQsfbyo1km8DtnS4TzQ=; b=AM+YEZ4VTabO13E/fSYY8oJr+FaAqin+ETn+mXT1gp8IA71Vwls4qc16qDsQzKo4Nl uw10lvNxX8z/BbTXgMLKEsVSaC1iqE1QeO++eJIvbiW2iZMDBksumDJlnLWf89tK0VJi 4zRoHxKVy5zk/iKWvT0aJqMja/baXAZepWseDpddsEvUCd3WDe/5g1k/XpXTbR1swiQ0 2KMqCoAsLfRD3xesM2kCQc0He5CUtwRNslBxSuGtbWn6XfuKwXXN3xE8tdq3VInPfssj /S7Dk7Ru7k4tocks58i3a5o2TGYUM01iXEsGqCqUqEyOtk+u91II7EWIpg6OX0ZR6mbD pyNA== X-Gm-Message-State: AOAM531JVg7pFdKPAtT27bQbRhBlkXz8W4FXinLDdXeU3nWVBzVpMaDB /QF4BIPP95nSF/+WRyj8ahBBl4fMQuyqZO9YU4pnVZu/Vd6HURzerbhjkVcgiy7NlJ5VBHrDIdE k3jtsH2fuBkFprhREVG6G9Q== X-Received: by 2002:a7b:c201:: with SMTP id x1mr23908wmi.58.1592510408902; Thu, 18 Jun 2020 13:00:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxbIlmvtfF2OQNbepz2YB0Qmg+Ds08uyne9Qto2LMMiycZI4Bdag1+hhNOZ5f+FGJ+n23u8Tw== X-Received: by 2002:a7b:c201:: with SMTP id x1mr23895wmi.58.1592510408736; Thu, 18 Jun 2020 13:00:08 -0700 (PDT) Received: from ?IPv6:2001:8a0:f922:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f922:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id e15sm4794537wme.9.2020.06.18.13.00.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2020 13:00:08 -0700 (PDT) Subject: Re: [PATCH 26/28] Don't write to inferior_ptid in ravenscar-thread.c To: Tom Tromey , Pedro Alves via Gdb-patches References: <20200414175434.8047-1-palves@redhat.com> <20200414175434.8047-27-palves@redhat.com> <87zhbaq7cn.fsf@tromey.com> From: Pedro Alves Message-ID: <38f730fe-b295-218e-c843-7ccee50a0ed1@redhat.com> Date: Thu, 18 Jun 2020 21:00:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <87zhbaq7cn.fsf@tromey.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jun 2020 20:00:25 -0000 On 4/17/20 7:45 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves via Gdb-patches writes: > > Pedro> ravenscar_thread_target () > Pedro> + : m_base_ptid (inferior_ptid) > Pedro> { > Pedro> - update_inferior_ptid (); > Pedro> + thread_info *thr = add_active_thread (); > Pedro> + if (thr != nullptr) > Pedro> + switch_to_thread (thr); > Pedro> } > > I wonder if this will help with the announcement problem fixed here: > > https://sourceware.org/pipermail/gdb-patches/2019-March/156455.html > I don't think so. update_inferior_ptid added a thread, and add_active_thread will still add it. > It's not all that important, I still want to try to get that series in. > It's held up on > > https://sourceware.org/pipermail/gdb-patches/2019-March/156453.html > Offhand that seemed like a gross hack to me when I first saw it, which is why I've had trouble responding. :-( But maybe I just misunderstood it. Thanks, Pedro Alves