From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id g85iGMpFjmdjaBUAWB0awg (envelope-from ) for ; Mon, 20 Jan 2025 07:47:06 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=bvPRkM/R; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=dCsPvSht; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=bvPRkM/R; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=dCsPvSht; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4AE981E100; Mon, 20 Jan 2025 07:47:06 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 720191E08E for ; Mon, 20 Jan 2025 07:47:05 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0699D3857C5F for ; Mon, 20 Jan 2025 12:47:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0699D3857C5F Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=bvPRkM/R; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=dCsPvSht; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=bvPRkM/R; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=dCsPvSht Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 3E1013858431 for ; Mon, 20 Jan 2025 12:46:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3E1013858431 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3E1013858431 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737377191; cv=none; b=fBvDmTGYMFtuFydKwO3qH+SHYusGDUBKLTyIhqnfsviN/E4WjkbU4NXvRTxserQfa5XzeTlplYTdmEvNZPVOpDuXSmbFM0duV0W63NzEcsB7KH/G1uWGj6+JFDdHM/DEAJay7Zuo2I0Qq3jjfkHHnpYFlNp9STgny7p5L8HeVhI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737377191; c=relaxed/simple; bh=6FTKFSVMYsQ5wX+uONbP2COWbOiSiYsuHgiyLhTpq4Q=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=YeWsHgltGCvBqArGm98DYulJ8DYVR4JECHEbftm46R/qjjVwTQhFLTYXpoJnZevzghNciDwqgo7gKuszPOlRWiUw3Q6N9EfsurM1s/JAviSgsR1U8iiB7X/xHUaip0jlvby6wBx8s6ugYCTI5nIttoEAdRh2BzPuZyq7HwmHPC8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3E1013858431 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1B2E61F7B3; Mon, 20 Jan 2025 12:46:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1737377190; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SZxN76ldypH2QYtHItCR+AHkiVeMWB7QQwxtUcM7CuI=; b=bvPRkM/RlwVbMVwKCQ2sr4k4v3nj3DDEW2Yyb0uovLrTz9FgXlH4h+eca2rxQ5m8hGJI94 qmTOF5SaidVo6T1ymvFb6igD7tn+EORi7PrGOlqPYsVRDo/dWp9n4OBdNuk59soj9jZjmA 07xaiPNkEzkWGw9IG7rJHTrmN0EBJrg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1737377190; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SZxN76ldypH2QYtHItCR+AHkiVeMWB7QQwxtUcM7CuI=; b=dCsPvSht5HR46IXvCAOjtCYPcqFw0jkPHAZ1DsI3Jzfcngz0/GfmTgCXAQsxKIOG+rpYCP /kkulbwlr9P7PRBw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="bvPRkM/R"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=dCsPvSht DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1737377190; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SZxN76ldypH2QYtHItCR+AHkiVeMWB7QQwxtUcM7CuI=; b=bvPRkM/RlwVbMVwKCQ2sr4k4v3nj3DDEW2Yyb0uovLrTz9FgXlH4h+eca2rxQ5m8hGJI94 qmTOF5SaidVo6T1ymvFb6igD7tn+EORi7PrGOlqPYsVRDo/dWp9n4OBdNuk59soj9jZjmA 07xaiPNkEzkWGw9IG7rJHTrmN0EBJrg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1737377190; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SZxN76ldypH2QYtHItCR+AHkiVeMWB7QQwxtUcM7CuI=; b=dCsPvSht5HR46IXvCAOjtCYPcqFw0jkPHAZ1DsI3Jzfcngz0/GfmTgCXAQsxKIOG+rpYCP /kkulbwlr9P7PRBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0188B139CB; Mon, 20 Jan 2025 12:46:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id TLdsOqVFjmf8PQAAD6G6ig (envelope-from ); Mon, 20 Jan 2025 12:46:29 +0000 Message-ID: <38f18a49-f283-45cb-9333-ee911ee76e73@suse.de> Date: Mon, 20 Jan 2025 13:46:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/testsuite: Fix file location for gdb.base/backtrace-through-cu-nodebug To: Guinevere Larsen , gdb-patches@sourceware.org References: <7fa350c1-a2b7-4284-a59b-be68c1af9221@suse.de> <20250120122608.115710-2-guinevere@redhat.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <20250120122608.115710-2-guinevere@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1B2E61F7B3 X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; ASN(0.00)[asn:25478, ipnet:::/0, country:RU]; MIME_TRACE(0.00)[0:+]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCPT_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_COUNT_TWO(0.00)[2]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_MATCH_ENVRCPT_ALL(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 1/20/25 13:26, Guinevere Larsen wrote: > The newly added test gdb.base/backtrace-through-cu-nodebug.exp had a > problem in the call to gdb_comiple, that caused the .o files to be Hi Gwen, gdb_comiple -> gdb_compile > outputted in the GDB file tree. This commit fixes the issues in the calls. > > Reported-By: Tom de Vries I've tested this, and checked that it fixes the problem. LGTM. Approved-By: Tom de Vries Thanks, - Tom > --- > > Hi Tom, > > Sorry about that, this patch should fix it. I'm not sure if this counts > as obvious, so I haven't pushed it yet, do let me know if this is ok :) > > --- > .../gdb.base/backtrace-through-cu-nodebug.exp | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp > index d6e686539c9..53bf642a92c 100644 > --- a/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp > +++ b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp > @@ -17,8 +17,8 @@ > # trace goes through a function with no debug information. > > standard_testfile -caller.c -main.c > -set objmainfile ${testfile}-main.o > -set objcallerfile ${testfile}-caller.o > +set objmainfile [standard_output_file ${testfile}-main.o] > +set objcallerfile [standard_output_file ${testfile}-caller.o] > > # Recompile the inferior with or without CFI information, then run the > # inferior until the point where the important test starts. > @@ -28,7 +28,7 @@ proc prepare_test {has_cfi} { > if {$has_cfi} { > set extension "cfi" > if {[gdb_compile "${srcdir}/${subdir}/${srcfile}" \ > - "${srcdir}/${subdir}/${objcallerfile}" \ > + "${objcallerfile}" \ > object [list {additional_flags=-fomit-frame-pointer \ > -funwind-tables -fasynchronous-unwind-tables}]] != "" } { > untested "couldn't compile with cfi" > @@ -37,7 +37,7 @@ proc prepare_test {has_cfi} { > } else { > set extension "no-cfi" > if {[gdb_compile "${srcdir}/${subdir}/${srcfile}" \ > - "${srcdir}/${subdir}/${objcallerfile}" \ > + "${objcallerfile}" \ > object [list {additional_flags=-fomit-frame-pointer \ > -fno-unwind-tables \ > -fno-asynchronous-unwind-tables}]] != "" } { > @@ -45,8 +45,8 @@ proc prepare_test {has_cfi} { > return false > } > } > - if {[gdb_compile [list "${srcdir}/${subdir}/${objmainfile}" \ > - "${srcdir}/${subdir}/${objcallerfile}"] \ > + if {[gdb_compile [list "${objmainfile}" \ > + "${objcallerfile}"] \ > "${binfile}-${extension}" binfile {}] != ""} { > untested "couldn't link object files" > return false > @@ -66,7 +66,7 @@ proc prepare_test {has_cfi} { > } > > if {[gdb_compile "${srcdir}/${subdir}/${srcfile2}" \ > - "${srcdir}/${subdir}/${objmainfile}" \ > + "${objmainfile}" \ > object {debug}] != "" } { > untested "couldn't compile main file" > return