From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13689 invoked by alias); 31 Mar 2017 15:13:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13671 invoked by uid 89); 31 Mar 2017 15:13:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1177 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 31 Mar 2017 15:12:59 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 99853C05AA56; Fri, 31 Mar 2017 15:12:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 99853C05AA56 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 99853C05AA56 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9CE5B783C6; Fri, 31 Mar 2017 15:12:58 +0000 (UTC) Subject: Re: [PATCH v2] gdbserver: Suffix generated C files with -generated To: Simon Marchi , gdb-patches@sourceware.org References: <20170331145554.26349-1-simon.marchi@ericsson.com> Cc: Simon Marchi From: Pedro Alves Message-ID: <38db6e08-ed78-59ce-a514-03398fe5fe70@redhat.com> Date: Fri, 31 Mar 2017 15:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170331145554.26349-1-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-03/txt/msg00544.txt.bz2 On 03/31/2017 03:55 PM, Simon Marchi wrote: > From: Simon Marchi > > I noticed that there were some missing files in gdbserver's gitignore > (some generated register format .c files). Of course the easy fix would > be to add those files to .gitignore, but I think we can do a better job, > so that we don't have to worry about adding generated files to > .gitignore or the clean Makefile target. > > I suggest naming all generated source files -generated.c. This way, we > can use a single rule in .gitignore and do a "rm -f *-generated.c" to > clean them up. > > New in v2: > > - Don't rename version.o and xml-builtin.o > > gdb/gdbserver/ChangeLog: > > * .gitignore: Remove generated files, replace with wildcard. > * (clean): Replace removal of generated files with wildcard. > (version.c): Replace with... > (version-generated.c): ...this. > (xml-builtin.c): Replace with... > (xml-builtin-generated.c): ...this. > (%-ipa.o: %-generated.c, %.o: %-generated.c): New rules. > (%.c: *regformats*): Replace with... > (%-generated.c: *regformats*): ...this. OK. Thanks, Pedro Alves