From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id hztuFF2IOmMJmwQAWB0awg (envelope-from ) for ; Mon, 03 Oct 2022 02:59:41 -0400 Received: by simark.ca (Postfix, from userid 112) id 4B5EF1E112; Mon, 3 Oct 2022 02:59:41 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=Gkf0vGeP; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 032C71E0D3 for ; Mon, 3 Oct 2022 02:59:41 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B0C26385742F for ; Mon, 3 Oct 2022 06:59:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B0C26385742F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1664780379; bh=0hh6UCjnj4D59nLmLe6HztJo8E8+s3jfaxWtfh0tMS8=; h=Subject:Date:References:In-Reply-To:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Gkf0vGePqjB3ZUWtv9w7gO79MrfHs09mVfZffw/pMZoZ5Wxjl4ArSecdegGOdfkCo /AihxvRxacjHjDjAaJpw9kLyDmxvTzSo4h14YG194X4mFo0xqCI+/NYyuYtEcKBsan JRYzQYeosT+nHpUQoeeSAJQeFar6jzMoK6TUpqKQ= Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 367F03858D32; Mon, 3 Oct 2022 06:59:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 367F03858D32 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (1.0) Subject: Re: RFC: Sort tarballs created by the src-release.sh script Date: Mon, 3 Oct 2022 07:59:04 +0100 Message-Id: <38F08F3E-EFA6-4ABA-9CEE-60306E872C25@gentoo.org> References: In-Reply-To: To: Jan Beulich X-Mailer: iPhone Mail (20A380) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sam James via Gdb-patches Reply-To: Sam James Cc: Tzvetelin Katchov , Andreas Schwab , Nick Clifton , Nick Clifton via Gdb-patches , Binutils Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > On 3 Oct 2022, at 07:56, Jan Beulich wrote: >=20 > =EF=BB=BFOn 02.10.2022 09:54, Sam James wrote: >>=20 >>=20 >>>> On 30 Sep 2022, at 12:38, Nick Clifton via Binutils wrote: >>>=20 >>> =EF=BB=BFHi Guys, >>>=20 >>> Right, here is the latest and greatest - and hopefully last - version >>> of the patch. I added a parseable string to the --mtime option and a >>> comment explaining why these options are being used. >>>=20 >>> Any more comments/suggestions ? >>>=20 >>> Cheers >>> Nick >>>=20 >>> diff --git a/src-release.sh b/src-release.sh >>> index 079b545ae7c..8a2ac125030 100755 >>> --- a/src-release.sh >>> +++ b/src-release.sh >>> @@ -184,9 +184,11 @@ do_tar() >>> ver=3D$2 >>> echo "=3D=3D> Making $package-$ver.tar" >>> rm -f $package-$ver.tar >>> + # The sort command and --mtime, --group and --owner options are >>> + # used in order to create consistent, reproducible tarballs. >>> find $package-$ver -follow \( $CVS_NAMES \) -prune \ >>> - -o -type f -print \ >>> - | tar cTfh - $package-$ver.tar >>> + -o -type f -print | LC_ALL=3DC sort \ >>> + | tar cTfh - $package-$ver.tar --mtime=3D"1970-01-01 00:00:00" -= -group=3D0 --owner=3D0 >>> } >>>=20 >>> # Compress the output with bzip2 >>>=20 >>=20 >> I think this might hit a problem I faced when trying to do this with Go t= arballs: https://www.gnu.org/software/tar/manual/tar.html#warnings. >>=20 >> With that date, I got "implausibly old time stamp" warnings from tar. I h= aven't tested this patchthough (writing from mobile, apologies). >>=20 >> Maybe default to the creation date of Binutils and allow overriding via h= ttps://reproducible-builds.org/docs/source-date-epoch/? >=20 > Not sure what "creation date" might mean here. I meant whatever date folks consider to have been the creation of the Binuti= ls project. First commit, announcement, first release, whatever. Not that it really matters, it just can't be the unix epoch.=