From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-155149-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21166 invoked by alias); 3 Apr 2019 18:28:52 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 20960 invoked by uid 89); 3 Apr 2019 18:28:51 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=
X-HELO: mail-wr1-f49.google.com
Received: from mail-wr1-f49.google.com (HELO mail-wr1-f49.google.com) (209.85.221.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Apr 2019 18:28:50 +0000
Received: by mail-wr1-f49.google.com with SMTP id t17so76998wrw.13        for <gdb-patches@sourceware.org>; Wed, 03 Apr 2019 11:28:50 -0700 (PDT)
Return-Path: <palves@redhat.com>
Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b])        by smtp.gmail.com with ESMTPSA id w2sm13008417wrm.74.2019.04.03.11.28.47        (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);        Wed, 03 Apr 2019 11:28:48 -0700 (PDT)
Subject: Re: [PATCH v2 15/22] Make exceptions use std::string and be self-managing
To: Tom Tromey <tom@tromey.com>
References: <20190227201849.32210-1-tom@tromey.com> <20190227201849.32210-16-tom@tromey.com> <f6f7893d-d3dc-6b68-adb8-88c710da19ca@redhat.com> <8736mz2cp4.fsf@tromey.com>
Cc: gdb-patches@sourceware.org
From: Pedro Alves <palves@redhat.com>
Message-ID: <3887dba3-33e6-7ead-3847-7870f642be56@redhat.com>
Date: Wed, 03 Apr 2019 18:28:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <8736mz2cp4.fsf@tromey.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2019-04/txt/msg00054.txt.bz2

On 04/03/2019 06:58 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> 
> Pedro> I think fixing this isn't hard, so I think we should do it from the
> Pedro> start -- instead of gdb_exception holding a std::string, hold a
> Pedro> reference counted immutable heap-allocated C string.
> 
> I'll do this.
> 
> How about just a std::shared_ptr<std::string>?  

That should be fine.

Thanks,
Pedro Alves