From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7533 invoked by alias); 4 Sep 2013 13:02:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7523 invoked by uid 89); 4 Sep 2013 13:02:09 -0000 Received: from mga14.intel.com (HELO mga14.intel.com) (143.182.124.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Sep 2013 13:02:09 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RDNS_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mga14.intel.com Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga102.ch.intel.com with ESMTP; 04 Sep 2013 06:01:53 -0700 X-ExtLoop1: 1 Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by azsmga001.ch.intel.com with ESMTP; 04 Sep 2013 06:01:37 -0700 Received: from irsmsx105.ger.corp.intel.com (163.33.3.28) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.3.123.3; Wed, 4 Sep 2013 14:01:19 +0100 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.233]) by IRSMSX105.ger.corp.intel.com ([169.254.7.64]) with mapi id 14.03.0123.003; Wed, 4 Sep 2013 14:01:19 +0100 From: "Blanc, Nicolas" To: "gdb-patches@sourceware.org" Subject: RE: [PATCH v14 0/5] remove-symbol-file & add-symbol-file Date: Wed, 04 Sep 2013 13:02:00 -0000 Message-ID: <388084C8C1E6A64FA36AD1D656E4856624357F30@IRSMSX106.ger.corp.intel.com> References: <1375086490-14352-1-git-send-email-nicolas.blanc@intel.com> In-Reply-To: <1375086490-14352-1-git-send-email-nicolas.blanc@intel.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00132.txt.bz2 ping -----Original Message----- From: Blanc, Nicolas=20 Sent: Monday, July 29, 2013 10:28 AM To: gdb-patches@sourceware.org Cc: lgustavo@codesourcery.com; Blanc, Nicolas Subject: [PATCH v14 0/5] remove-symbol-file & add-symbol-file Adjust Patch 3/5 to reflect modification of struct target_section from upst= ream. Thanks Luis for pointing this out. The patch set was tested on x86_64 (Fedora 15) and x86 (Ubuntu 12.04). No regression was detected. Regards, Nicolas Changes between v13 and v14 * symfile.c (add_target_sections_of_objfile): Reflect modification of struct target_section from upstream. (symfile_free_objfile): Reflect modification of struct target_section from upstream. Changes between v12 and v13 * Changed "is_elf_target" to "is_known_elf_target" (Patch 4/5) according to Doug's proposal (http://sourceware.org/ml/gdb-patches/2013-07/msg00426.html). * Removed dependency to according to Mark's suggestion (http://sourceware.org/ml/gdb-patches/2013-07/msg00415.html). Changes between v11 and v12 * symfile.c (add_target_sections_of_objfile): Reflect modification of struct target_section from upstream. * gdb.base/sym-file-main.c: Move loader into a separate file as suggested and implemented the other recommendations from Doug. * gdb.base/sym-file-loader.c: New file. * gdb.base/sym-file-loader.h: New file. * lib/gdb.exp (is_elf_target): New function. Changes between v10 and v11: * Changed documentation for add-symbol-file according to feedback (Patch 3): "keeps adding to" -> "is kept in addition to". * Fixed indentation issues in test (sym-file-main.c from Patch 2). Changes between v9 and v10: * Dropped "USAGE" in "USAGE: remove-symbol-file FILENAME" according to sugg= estion. * Fixed comment according to suggestion: "any reference to any objfile" -> "all references to any objfile" * Added argument names to the prototype of is_addr_in_objfile according to = suggestion. * Fixed indentation of "macro" loops according to feedback. * Fixed indentation issues. Changes between v8 and v9: * Patch 4: New patch (fix add-symbol-file for 'info files'). * Patch 5: New patch (test add-symbol-file and 'info files'); * sym-file.exp: Fixed test name string. Changes between v7 and v8: * sym-file.exp: Call gdb_get_line_number with ${libfile}.c intead of $libsr= c. * Fixed typo in commit message for Patch 2/3. Changes between v6 and v7: * Changed disable_breakpoints_in_freed_objfile () from feedback: Use is_breakpoint () and is_tracepoint (). Add call to mark_breakpoint_location_modified (). * Changed command description according to suggestion. * Changed commit log message for new functions according to feedback. * Fixed nits in gdb/solib.c and testsuite/gdb.base/sym-file.exp. Changes between v5 and v6: * Changed syntax of the command according to feedback: remove-symbol-file FILENAME remove-symbol-file -a ADDRESS * Updated the documentation for the new syntax. * Updated the test for the new syntax. * Added check to only remove objfiles from the current program space. Changes between v4 and v5: * The address parameter can now be any address mapping into one of the sect= ions of the file to remove. This is more flexible and more judicious because t= he symbol file may have no text section, as pointed out in some reviews. * Move is_addr_in_objfile from breakpoint.c to objfiles.c. This new function is now used in both symfile.c and breakpoint.c. * is_addr_in_objfile returns now 0 if OBJFILE is NULL. * Updated the documentation to reflect the command change. * Removed double blank lines. * Reworded the log entries in the commit messages, as suggested. * The test was simplified using prepare_for_testing, as suggested. Changes between v3 and v4: * gdb/symfile.c: add missing space character in output string. * gdb/doc/gdb.texinfo: add usage example. Changes between v2 and v3: * gdb/breakpoints.c (disable_breakpoints_in_freed_objfile): Changed name of disable_breakpoints_in_free_objfile to disable_breakpoint= s_in_freed_objfile. Call observer_breakpoint_modified at most one time per breakpoint. * gdb/objfiles.h (struct objfile): Add comment for low_addr. * gdb/solib.c (remove_user_added_objfile): Don't check OBJF_SHARED anymore = to avoid leaving dangling pointers. * gdb/symfile.c (add_symbol_file_command): Parse and evaluate the address p= arameter only once. * gdb/symfile.c (remove_symbol_file_command): Don't use gdb_buildargv anymo= re. Ask the user for confirmation before removing a file. * gdb/doc/gdb.texinfo: The parameter of the command is now referred to as "= the address of the text section". * gdb/NEWS: Move the entry for remove-symbol-file to "Changes since GDB 7.6= ". The address parameter is now referred to as "the beginning of the text s= ection". * Fixed letter case of variables in comments. * Fixed indentation typos. Nicolas Blanc (5): New remove-symbol-file command. Documentation for the remove-symbol-file command. 'add-symbol-file' should update the current target sections. Function is_known_elf_target. Test adding and removing a symbol file at runtime. gdb/NEWS | 6 + gdb/breakpoint.c | 67 ++++++- gdb/doc/gdb.texinfo | 26 ++- gdb/doc/observer.texi | 4 + gdb/objfiles.c | 23 ++ gdb/objfiles.h | 2 + gdb/printcmd.c | 15 +- gdb/solib.c | 22 ++ gdb/symfile.c | 150 +++++++++++++- gdb/testsuite/gdb.base/sym-file-lib.c | 26 +++ gdb/testsuite/gdb.base/sym-file-loader.c | 353 ++++++++++++++++++++++++++= ++++ gdb/testsuite/gdb.base/sym-file-loader.h | 99 +++++++++ gdb/testsuite/gdb.base/sym-file-main.c | 79 +++++++ gdb/testsuite/gdb.base/sym-file.exp | 160 ++++++++++++++ gdb/testsuite/lib/gdb.exp | 15 ++ 15 files changed, 1034 insertions(+), 13 deletions(-) create mode 100644 = gdb/testsuite/gdb.base/sym-file-lib.c create mode 100644 gdb/testsuite/gdb.base/sym-file-loader.c create mode 100644 gdb/testsuite/gdb.base/sym-file-loader.h create mode 100644 gdb/testsuite/gdb.base/sym-file-main.c create mode 100644 gdb/testsuite/gdb.base/sym-file.exp -- 1.7.6.5 Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052