From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13009 invoked by alias); 29 May 2013 12:08:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12987 invoked by uid 89); 29 May 2013 12:08:41 -0000 X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.1 Received: from mga02.intel.com (HELO mga02.intel.com) (134.134.136.20) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 29 May 2013 12:08:40 +0000 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 29 May 2013 05:08:23 -0700 X-ExtLoop1: 1 Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga001.fm.intel.com with ESMTP; 29 May 2013 05:08:33 -0700 Received: from irsmsx152.ger.corp.intel.com (163.33.192.66) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.3.123.3; Wed, 29 May 2013 13:08:20 +0100 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.225]) by IRSMSX152.ger.corp.intel.com ([169.254.6.17]) with mapi id 14.03.0123.003; Wed, 29 May 2013 13:08:20 +0100 From: "Blanc, Nicolas" To: "lgustavo@codesourcery.com" CC: "gdb-patches@sourceware.org" , "palves@redhat.com" , "tromey@redhat.com" , "eliz@gnu.org" , "yao@codesourcery.com" Subject: RE: [patch v4 1/3] Create remove-symbol-file command. Date: Wed, 29 May 2013 12:08:00 -0000 Message-ID: <388084C8C1E6A64FA36AD1D656E485661A799D20@IRSMSX106.ger.corp.intel.com> References: <1369818805-14288-1-git-send-email-nicolas.blanc@intel.com> <1369818805-14288-2-git-send-email-nicolas.blanc@intel.com> <51A5CC72.2090000@codesourcery.com> In-Reply-To: <51A5CC72.2090000@codesourcery.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-05/txt/msg00992.txt.bz2 Hi Luis, Thanks for your feedback. I'll fix the nits. > I'm thinking, with a command called "remove-symbol-file" i would expect t= o provide some kind of filename to this command. Should the user also be ab= le to state a DSO name here and have it unloaded? > Maybe have the name translated to the base address used to unload the lib= rary internally? The first address parameter of the add-symbol-file command is a better way = to identify the file to remove than the file name because a file can be loa= ded multiple times at different addresses -- this case is important for me.= The user knows the "start address" very well since he typed it in for addi= ng the file. So I see no real benefit of adding a file-name parameter. This is what I wrote in the documentation: remove-symbol-file address The remove-symbol-file command removes all symbol information about the file loaded at address. address must be an expression that represents the = address of the text section of a file added by the user via the add-symbol-file command. In other words, the file to remove is identified by the first add= ress parameter of the add-symbol-file command: (gdb) add-symbol-file /home/user/gdb/mylib.so 0x7ffff7ff9480 add symbol table from file "/home/user/gdb/mylib.so" at .text_addr =3D 0x7ffff7ff9480 (y or n) y Reading symbols from /home/user/gdb/mylib.so...done. (gdb) remove-symbol-file 0x7ffff7ff9480 Remove symbol table from file "/home/user/gdb/mylib.so" at\ .text_addr =3D 0x7ffff7ff9480 (y or n) y (gdb)=09 remove-symbol-file does not repeat if you press RET after using it. Keeping the current syntax would be ok with you? Regards, Nicolas Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052