From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123543 invoked by alias); 10 Apr 2019 01:49:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 123454 invoked by uid 89); 10 Apr 2019 01:49:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=H*r:10.0.0 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 Apr 2019 01:49:06 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 440DD1E471; Tue, 9 Apr 2019 21:49:04 -0400 (EDT) Subject: Re: [PATCH 1/3] Remove some uses of "object_files" To: Tom Tromey , gdb-patches@sourceware.org References: <20190409180945.21621-1-tom@tromey.com> <20190409180945.21621-2-tom@tromey.com> From: Simon Marchi Message-ID: <386c2247-82ff-bb68-92b2-1680d2f0b997@simark.ca> Date: Wed, 10 Apr 2019 01:49:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 MIME-Version: 1.0 In-Reply-To: <20190409180945.21621-2-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-04/txt/msg00170.txt.bz2 On 2019-04-09 2:09 p.m., Tom Tromey wrote: > The "object_files" macro is sometimes used when iterating over > objfiles. This patch removes a few such uses in favor of the new > range adapter. > > gdb/ChangeLog > 2019-04-09 Tom Tromey > > * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach. > * minsyms.c (lookup_minimal_symbol): Use foreach. > (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name) > (lookup_minimal_symbol_solib_trampoline): Likewise. > * symfile.c (reread_symbols): Use foreach. LGTM. I would even suggest replacing the remaining few instances of object_files with current_program_space->objfiles_head and removing the macro completely. Simon