From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76687 invoked by alias); 24 May 2019 13:08:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76677 invoked by uid 89); 24 May 2019 13:08:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:759, H*UA:Macintosh X-HELO: mpv3-2015.case.edu Received: from mpv3-2015.CWRU.Edu (HELO mpv3-2015.case.edu) (129.22.103.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 May 2019 13:08:31 +0000 Received: from mpv6-2015.CWRU.Edu (EHLO mpv6-2015.case.edu) ([129.22.103.202]) by mpv3-2015.case.edu (MOS 4.4.8-GA FastPath queued) with ESMTP id AXV59375; Fri, 24 May 2019 09:08:20 -0400 (EDT) Received: from caleb.INS.CWRU.Edu (EHLO caleb.ins.cwru.edu) ([129.22.8.211]) by mpv6-2015.case.edu (MOS 4.4.8-GA FastPath queued) with ESMTP id CTA24734 (AUTH cpr); Fri, 24 May 2019 09:08:20 -0400 (EDT) Reply-To: chet.ramey@case.edu Cc: chet.ramey@case.edu, gdb-patches@sourceware.org, Pedro Alves Subject: Re: [Bug-readline] heap-buffer-overflow in update_line To: Tom de Vries , bug-readline@gnu.org References: <52f237e9-83e8-2a97-4766-e60b867ab914@suse.de> <79173bd4-f37e-c137-cf48-187047078bf0@suse.de> <17c0fa1d-7df4-5204-a8e6-104239d66e3c@suse.de> From: Chet Ramey Openpgp: preference=signencrypt Message-ID: <3853fa31-4574-f57f-d704-de9a34fe9d8b@case.edu> Date: Fri, 24 May 2019 13:08:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <17c0fa1d-7df4-5204-a8e6-104239d66e3c@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Junkmail-PrAS-Raw: score=10/90, refid=2.7.2:2019.5.24.123916:17:10.433, ip=, rules=__HAS_REPLYTO, __HAS_CC_HDR, __MULTIPLE_RCPTS_CC_X2, __CC_NAME, __CC_NAME_DIFF_FROM_ACC, __SUBJ_REPLY, __PHISH_SPEAR_SUBJ_PREDICATE, __BOUNCE_CHALLENGE_SUBJ, __BOUNCE_NDR_SUBJ_EXEMPT, __TO_MALFORMED_2, __TO_NAME, __TO_NAME_DIFF_FROM_ACC, __HAS_REFERENCES, __REFERENCES, __HAS_FROM, FROM_EDU_TLD, __HAS_MSGID, __SANE_MSGID, DATE_TZ_NA, __USER_AGENT, __MOZILLA_USER_AGENT, __MIME_VERSION, __IN_REP_TO, __CT, __CT_TEXT_PLAIN, __CTE, __REPLYTO_SAMEAS_FROM_ADDY, __REPLYTO_SAMEAS_FROM_ACC, __FROM_DOMAIN_IN_ANY_CC2, __TO_IN_SUBJECT2, __REPLYTO_SAMEAS_FROM_DOMAIN, __ANY_URI, __HTTPS_URI, __URI_WITH_PATH, __URI_NO_WWW, __CP_URI_IN_BODY, __SUBJ_ALPHA_NEGATE, __MULTIPLE_URI_TEXT, __URI_IN_BODY, __URI_NOT_IMG, __FORWARDED_MSG, __NO_HTML_TAG_RAW, BODY_SIZE_700_799, BODYTEXTP_SIZE_3000_LESS, __MIME_TEXT_P1, __MIME_TEXT_ONLY, __URI_NS, HTML_00_01, HTML_00_10, [TRUNCATED], so=2010-03-03 19:42:08, dmn=2016-08-03-0138 X-SW-Source: 2019-05/txt/msg00566.txt.bz2 On 5/23/19 3:28 PM, Tom de Vries wrote: > I did a further test-run to see if the original problem (PR24514 - > heap-buffer-overflow in update_line for utf8-identifiers.exp: > https://sourceware.org/bugzilla/show_bug.cgi?id=24514 ) was fixed, which > turned out not to be the case. > > I've analyzed this, and found it to be caused by the > init_line_structures part of the patch changing line_size, which does > not force a reallloc. I've fixed this by changing minsize instead. Thanks for the analysis and updated patch. Chet -- ``The lyf so short, the craft so long to lerne.'' - Chaucer ``Ars longa, vita brevis'' - Hippocrates Chet Ramey, UTech, CWRU chet@case.edu http://tiswww.cwru.edu/~chet/