From: Pedro Alves <pedro@palves.net>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Avoid expression parsing crash with unknown language
Date: Thu, 15 Jul 2021 17:28:11 +0100 [thread overview]
Message-ID: <383a2192-658c-59e0-7f7b-ac68ace3b2d1@palves.net> (raw)
In-Reply-To: <20210715161618.234526-1-tromey@adacore.com>
On 2021-07-15 5:16 p.m., Tom Tromey wrote:
> PR gdb/28093 points out that gdb crashes when language is set to
> "unknown" and expression parsing is attempted. At first I thought
> this was a regression due to the expression rewrite, but it turns out
> that older versions crash as well.
>
> This patch avoids the crash by changing the default expression parser
> to throw an exception. I think this is preferable -- the current
> behavior of silently doing nothing does not really make sense.
>
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28093
Looks good, thanks!
next prev parent reply other threads:[~2021-07-15 16:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 16:16 Tom Tromey
2021-07-15 16:28 ` Pedro Alves [this message]
2021-07-15 19:06 ` Tom Tromey
2021-07-17 18:37 ` Joel Brobecker
2021-07-19 17:08 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=383a2192-658c-59e0-7f7b-ac68ace3b2d1@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox