From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76062 invoked by alias); 4 May 2018 17:11:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76050 invoked by uid 89); 4 May 2018 17:11:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=tab, Hx-languages-length:1082, our X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 04 May 2018 17:10:59 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 96C504270963; Fri, 4 May 2018 17:10:57 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id EB66411166F4; Fri, 4 May 2018 17:10:56 +0000 (UTC) Subject: Re: [PATCH] Define GNULIB_NAMESPACE in unittests/string_view-selftests.c To: Joel Brobecker , Simon Marchi References: <1525382648-30186-1-git-send-email-simon.marchi@ericsson.com> <20180504165552.f4y7zcxzmgvwngel@adacore.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <38335bd5-7e46-23e2-a45b-da970a1b8680@redhat.com> Date: Fri, 04 May 2018 17:11:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180504165552.f4y7zcxzmgvwngel@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-05/txt/msg00102.txt.bz2 On 05/04/2018 05:55 PM, Joel Brobecker wrote: > What worries me is that I don't see what's preventing us from hitting > that issue outside of the unittests code? We know we can adjust our > own classes, but this problem occured with a system class, so we had > no choice but to use GNULIB_NAMESPACE. I worry that the transition > from no GNULIB_NAMESPACE to using GNULIB_NAMESPACE in a given unit > will leave some C system calls that should normally be covered by > gnulib silently now reverting to the system (buggy) version. Note that this is what led me to work on the whole wild/full matching for C++, the TAB improvements, etc. See: https://sourceware.org/ml/gdb-patches/2017-06/msg00012.html I haven't rebased/updated the cxx-gdb-namespace branch since, as I assumed it prudent to wait some time after a gdb is released with support for wildmatching. That has happened, so maybe we can consider going through with wrapping all of gdb in a namespace? Or is it still too soon? Thanks, Pedro Alves