From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 89F0F385B834 for ; Tue, 24 Mar 2020 02:49:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 89F0F385B834 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id F251E1E5F8; Mon, 23 Mar 2020 22:49:20 -0400 (EDT) Subject: Re: [PATCH 13/22] Convert read_indirect_line_string to a method To: Tom Tromey , gdb-patches@sourceware.org References: <20200322184523.28959-1-tom@tromey.com> <20200322184523.28959-14-tom@tromey.com> From: Simon Marchi Message-ID: <37bf2c71-7a4c-cdbc-38eb-5bbf32eb8318@simark.ca> Date: Mon, 23 Mar 2020 22:49:20 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200322184523.28959-14-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US-large Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-15.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Mar 2020 02:49:22 -0000 On 2020-03-22 2:45 p.m., Tom Tromey wrote: > @@ -18790,17 +18786,15 @@ read_indirect_string (struct dwarf2_per_objfile *dwarf2_per_objfile, bfd *abfd, > BUF is assumed to be in a compilation unit described by CU_HEADER. > Return *BYTES_READ_PTR count of bytes read from BUF. */ > > -static const char * > -read_indirect_line_string (struct dwarf2_per_objfile *dwarf2_per_objfile, > - bfd *abfd, const gdb_byte *buf, > +const char * > +dwarf2_per_objfile::read_line_string (const gdb_byte *buf, > const struct comp_unit_head *cu_header, > unsigned int *bytes_read_ptr) The comment above this definition should become /* See read.h. */ Simon