From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-135352-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 66415 invoked by alias); 26 Nov 2016 15:51:22 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 66406 invoked by uid 89); 26 Nov 2016 15:51:22 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=HX-PHP-Originating-Script:rcube.php
X-HELO: simark.ca
Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 26 Nov 2016 15:51:21 +0000
Received: by simark.ca (Postfix, from userid 33)	id C92EB1E86E; Sat, 26 Nov 2016 10:51:19 -0500 (EST)
To: Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH 11/22] Use std::vector for cli_ui_out_data::streams
X-PHP-Originating-Script: 33:rcube.php
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: 7bit
Date: Sat, 26 Nov 2016 15:51:00 -0000
From: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
In-Reply-To: <0be7cb40-1dc5-68d5-d2b4-1a4e5d47dd49@redhat.com>
References: <20161124152428.24725-1-simon.marchi@polymtl.ca> <20161124152710.25007-11-simon.marchi@polymtl.ca> <0be7cb40-1dc5-68d5-d2b4-1a4e5d47dd49@redhat.com>
Message-ID: <375715c1c8f70251190e5addd47ac7df@polymtl.ca>
X-Sender: simon.marchi@polymtl.ca
User-Agent: Roundcube Webmail/1.2.2
X-IsSubscribed: yes
X-SW-Source: 2016-11/txt/msg00892.txt.bz2

On 2016-11-24 13:40, Pedro Alves wrote:
> On 11/24/2016 03:26 PM, Simon Marchi wrote:
>> @@ -406,13 +404,14 @@ cli_out_set_stream (struct ui_out *uiout, struct 
>> ui_file *stream)
>>  {
>>    cli_out_data *data = (cli_out_data *) ui_out_data (uiout);
>>    struct ui_file *old;
>> -
>> -  old = VEC_pop (ui_filep, data->streams);
>> -  VEC_quick_push (ui_filep, data->streams, stream);
>> +
>> +  old = data->streams.back ();
>> +  data->streams.pop_back ();
>> +  data->streams.push_back (stream);
> 
> back() returns a reference, so this pop/push can be just:
> 
>      data->streams.back () = stream;

Oooh thanks, fixed locally.