From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40151 invoked by alias); 12 Mar 2019 17:09:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 40142 invoked by uid 89); 12 Mar 2019 17:09:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=0.2 required=5.0 tests=AWL,BAYES_50,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=H*RU:sk:sonic30, HX-Spam-Relays-External:sk:sonic30, HX-HELO:sk:sonic30, H*r:sk:sonic30 X-HELO: sonic303-20.consmr.mail.ir2.yahoo.com Received: from sonic303-20.consmr.mail.ir2.yahoo.com (HELO sonic303-20.consmr.mail.ir2.yahoo.com) (77.238.178.201) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Mar 2019 17:09:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1552410551; bh=TfWIBVXj7zrXFMY4cRZQtMF5V0yChZ+TexSIHC+pgHk=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject; b=hF4sG1bWZkFkXL0sqNDjkC0bnbJblOIQz64meFmrGxDTm3pJWpl7CAUl9Excs9s11VjCTgmiltmGUtEz7IKBaCsnFczS3ui2xcIUiwaESdcL04Luu+jJvk+/EmnoW60Rnt/Q3jKJWpxfbLup3YEf3cx3Ks4HHuaphXS/4h5+tbXerhh2F5SZSyidkJAOIivC01CSUKZd/7w+SXIJPBPe/VGRktujOqnqCw75PAyhmnY6lXobIwX2e+ZDfaG6T3v5HQL8nBWTuBK3YLeUmowLevA4pTJEQ1etDXPuhbYCAokcP3Xk6H54gx/dEwVfe0UIYQPYGLHRHR8vVmdqZzyllg== Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.ir2.yahoo.com with HTTP; Tue, 12 Mar 2019 17:09:11 +0000 Date: Tue, 12 Mar 2019 17:09:00 -0000 From: "Hannes Domani via gdb-patches" Reply-To: Hannes Domani To: GDB Patches Message-ID: <375483967.6114402.1552410513314@mail.yahoo.com> In-Reply-To: <87o96g3upj.fsf@tromey.com> References: <20190308210433.32683-1-tromey@adacore.com> <1828778750.3318305.1552141698307@mail.yahoo.com> <87o96g3upj.fsf@tromey.com> Subject: Re: [RFC 8.3 0/3] Some style fixes MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_6114401_1939498858.1552410513314" X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00246.txt.bz2 ------=_Part_6114401_1939498858.1552410513314 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-length: 1268 Am Dienstag, 12. M=C3=A4rz 2019, 17:48:12 MEZ hat Tom Tromey Folgendes geschrieben:=20 > >>>>> "Hannes" =3D=3D Hannes Domani via gdb-patches writes: > > Hannes> 1) Outside of TUI, escaped characters (< 040 and 0177) aren't han= dled correctly any more when > Hannes> list'ing some source code, resulting in an endless loop. > Hannes> See print_source_lines_base(), I just added "++iter" in the last = 2 if() blocks, that fixed it for me. > > Hannes> 2) In TUI, scrolling right with the arrow keys, the first keypres= s doesn't do anything. > Hannes> (that's just a very minor nuisance) > > Hannes> 3) Again in TUI, scrolling right handles TABS and escaped charact= ers as single characters, > Hannes> which just looks weird. > > Thanks, I will take a look at these. > > I suspect #2 is the nonl problem.=C2=A0 Could you try the patch I sent in > another branch of this thread? No, applying that doesn't fix this. In copy_source_line() it checks if (column < first_col), and because of the= ++column directly before, it basically starts with 1 instead of 0. Attached is a patch that fixes most of 2) and 3), but I ignored the handlin= g of escaped characters, because I just don't have them in any of my sources.= ------=_Part_6114401_1939498858.1552410513314 Content-Type: application/octet-stream Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Fix-scrolling-right-in-TUI.patch" Content-ID: <3c12b745-5d6d-5f27-58b8-becf9b3d442f@yahoo.com> Content-length: 2034 RnJvbSAwMmIxOGFkMGRhODVmZDBlYzYwODJiNWM4ZTMxYTNmOThmYzhhNWIw IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIYW5uZXMgRG9tYW5p IDxzc2Jzc2FAeWFob28uZGU+CkRhdGU6IFNhdCwgOSBNYXIgMjAxOSAxNToz MDowNyArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIEZpeCBzY3JvbGxpbmcgcmln aHQgaW4gVFVJLgoKLS0tCiBnZGIvdHVpL3R1aS1zb3VyY2UuYyB8IDIwICsr KysrKysrKysrKysrKysrLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTcgaW5zZXJ0 aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9nZGIvdHVp L3R1aS1zb3VyY2UuYyBiL2dkYi90dWkvdHVpLXNvdXJjZS5jCmluZGV4IDYz ZTc1MmNkMDQuLjE0MmNlODYzMzggMTAwNjQ0Ci0tLSBhL2dkYi90dWkvdHVp LXNvdXJjZS5jCisrKyBiL2dkYi90dWkvdHVpLXNvdXJjZS5jCkBAIC03Myw4 ICs3MywyMSBAQCBjb3B5X3NvdXJjZV9saW5lIChjb25zdCBjaGFyICoqcHRy LCBpbnQgbGluZV9ubywgaW50IGZpcnN0X2NvbCwKICAgICAgICsrY29sdW1u OwogICAgICAgLyogV2UgaGF2ZSB0byBwcm9jZXNzIGFsbCB0aGUgdGV4dCBp biBvcmRlciB0byBwaWNrIHVwIGFsbCB0aGUKIAkgZXNjYXBlcy4gICovCi0g ICAgICBpZiAoY29sdW1uIDwgZmlyc3RfY29sIHx8IGNvbHVtbiA+IGZpcnN0 X2NvbCArIGxpbmVfd2lkdGgpCi0JY29udGludWU7CisgICAgICBpZiAoY29s dW1uIDw9IGZpcnN0X2NvbCB8fCBjb2x1bW4gPiBmaXJzdF9jb2wgKyBsaW5l X3dpZHRoKQorCXsKKwkgIGlmIChjID09ICdcdCcpCisJICAgIHsKKwkgICAg ICBpbnQgaiwgbWF4X3RhYl9sZW4gPSB0dWlfdGFiX3dpZHRoOworCisJICAg ICAgLS1jb2x1bW47CisJICAgICAgZm9yIChqID0gY29sdW1uICUgbWF4X3Rh Yl9sZW47CisJCSAgIGogPCBtYXhfdGFiX2xlbiAmJiBjb2x1bW4gPCBmaXJz dF9jb2wgKyBsaW5lX3dpZHRoOworCQkgICBjb2x1bW4rKywgaisrKQorCQlp ZiAoY29sdW1uID49IGZpcnN0X2NvbCkKKwkJICByZXN1bHQucHVzaF9iYWNr ICgnICcpOworCSAgICB9CisJICBjb250aW51ZTsKKwl9CiAKICAgICAgIGlm IChjID09ICdcbicgfHwgYyA9PSAnXHInIHx8IGMgPT0gJ1wwJykKIAl7CkBA IC05NCw3ICsxMDcsOCBAQCBjb3B5X3NvdXJjZV9saW5lIChjb25zdCBjaGFy ICoqcHRyLCBpbnQgbGluZV9ubywgaW50IGZpcnN0X2NvbCwKIAl7CiAJICBp bnQgaiwgbWF4X3RhYl9sZW4gPSB0dWlfdGFiX3dpZHRoOwogCi0JICBmb3Ig KGogPSBjb2x1bW4gLSAoKGNvbHVtbiAvIG1heF90YWJfbGVuKSAqIG1heF90 YWJfbGVuKTsKKwkgIC0tY29sdW1uOworCSAgZm9yIChqID0gY29sdW1uICUg bWF4X3RhYl9sZW47CiAJICAgICAgIGogPCBtYXhfdGFiX2xlbiAmJiBjb2x1 bW4gPCBmaXJzdF9jb2wgKyBsaW5lX3dpZHRoOwogCSAgICAgICBjb2x1bW4r KywgaisrKQogCSAgICByZXN1bHQucHVzaF9iYWNrICgnICcpOwotLSAKMi4x NS4xLndpbmRvd3MuMgoK ------=_Part_6114401_1939498858.1552410513314--