From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id PiFaO4MT6GKrnB4AWB0awg (envelope-from ) for ; Mon, 01 Aug 2022 13:55:15 -0400 Received: by simark.ca (Postfix, from userid 112) id E20AA1EA05; Mon, 1 Aug 2022 13:55:15 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=freebsd.org header.i=@freebsd.org header.a=rsa-sha256 header.s=dkim header.b=CmPekbl1; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RDNS_DYNAMIC autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 558A51E9ED for ; Mon, 1 Aug 2022 13:55:15 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B449E3858000 for ; Mon, 1 Aug 2022 17:55:14 +0000 (GMT) Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by sourceware.org (Postfix) with ESMTPS id 04AF538582BC for ; Mon, 1 Aug 2022 17:55:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 04AF538582BC Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4LxQkb42t2z4Cxt; Mon, 1 Aug 2022 17:55:03 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LxQkb0wL2z3hfd; Mon, 1 Aug 2022 17:55:03 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1659376503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Juz5JGJqurOjIw1jzbPxZ5EpVBn3ZsjuiYpbKmHIzBY=; b=CmPekbl15KPEVZAtDhQbtswEoqnIOJccRBRX6100GtX/+fQHXYqnrAh/xV5fEhR+p7OsfR rJYLGxQugtQgYzqliHGy4LTjCqnNFzriFdgWF2gUuDiGpvHSLSbasE4XJiJNeZYimouApt MoOuIqU8tFO+JTNoSvcFUj6Xu3e+Li8/qz/N4JfdyrP7XugS5iaOlOCykcSErS7ropk2Aq n+A9T8Zbtz2soAKpZXX+vPNBun08MHY/KrPd7zRAG9/Y4NRIdF9f2Jk/HzQxPc1ZjVovIf UlsGCEQY34jCg6dQCZ5bfCx3BD78bv/xQgufQGow7Ct9fdG4CV6Wt+5cPZ4V+Q== Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4LxQkZ3bhcz15Qd; Mon, 1 Aug 2022 17:55:02 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <3740df12-8232-a866-72bf-7efdcceb13ba@FreeBSD.org> Date: Mon, 1 Aug 2022 10:55:01 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Enze Li , gdb-patches@sourceware.org References: From: John Baldwin Subject: Re: [PATCH] gdb/amd64: clean up unused variable In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1659376503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Juz5JGJqurOjIw1jzbPxZ5EpVBn3ZsjuiYpbKmHIzBY=; b=dJ9IScnetqU5DwhlkNRvsp+0wqsRFI+CW7oNacs+S057eDtIOoxvbJZzno60vXpsK6leYp 6tFahO+rlbYJrb/YX2W27RjIP67NO2jyma8d74WaJsNGhwNowFOlh651WVSdD05/UFrtXQ G137lMo2rIGcR2/u7iUCqIJ7PhFOTHfCd2nly/75Xv7lvyqAyiRfMi1W7oCqK/2C5Ro8kP WsFN47SEk4/1kQ9C+wByo3NEKqEw3y73M2FGaJREbrVmpQxBONSsXrm6PFhCoBjc0OVFbt fUWQWF86YHAAJvhsjxGG1HbMxc6lBuvu7+vTSrfCH+ao8PQl3E0ACCx/URy8CQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1659376503; a=rsa-sha256; cv=none; b=m4L21cz1R3hGZyl2Ehu4Yik73Eg2q6RYLb9oQ6q/WcHPpTThu/rAN0D+y5JSYlTEoW68ll buFPL36hSk/iBnerRwWjSARlugMqfniNIlotGaM2trcsSpb6Q8TrhHWF4zD9flgO041Fy3 NqEFnxvEAw6CWySk8Rf2V1SBKDlrU0EoQmj1757Cr7SpITg68caEIQ3XV+4q1NEuFhkwXu LBNOhoSzmc9MsIFI5amJuOtoHRYGORYs42YBDBO4Ly0O/PWtR1AYxjR8kHCPYHzG9xAsRq BU7Z1Lo+d2imcwJ2EdRp3G3ieC5WfWh5/kv9OBQkjGXsjXfaW7GOANyZ1wTDeA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: enze.li@gmx.com Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 7/30/22 9:14 PM, Enze Li via Gdb-patches wrote: > When building with clang 15, I got this, > > CXX amd64-tdep.o > amd64-tdep.c:1410:13: error: variable 'insn' set but not used[-Werror,-Wunused-but-set-variable] > gdb_byte *insn = insn_details->raw_insn + modrm_offset; > ^ > 1 error generated. > > The function that uses this variable has been removed in this commit, > > commit 870f88f7551b0f2d6aaaa36fb684b5ff8f468107 > Date: Mon Apr 18 13:16:27 2016 -0400 > > remove trivialy unused variables > > Fix this by removing unused variable. > > Tested by rebuilding on x86_64-linux with clang 15 and gcc 12. > --- > gdb/amd64-tdep.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/gdb/amd64-tdep.c b/gdb/amd64-tdep.c > index 0563b32a54bf..3fbbf20fc2b1 100644 > --- a/gdb/amd64-tdep.c > +++ b/gdb/amd64-tdep.c > @@ -1407,14 +1407,12 @@ fixup_riprel (struct gdbarch *gdbarch, > { > const struct amd64_insn *insn_details = &dsc->insn_details; > int modrm_offset = insn_details->modrm_offset; > - gdb_byte *insn = insn_details->raw_insn + modrm_offset; > CORE_ADDR rip_base; > int insn_length; > int arch_tmp_regno, tmp_regno; > ULONGEST orig_value; > > /* %rip+disp32 addressing mode, displacement follows ModRM byte. */ > - ++insn; This seems to orphan the comment. I think the comment can go. insn here was orphaned by commit 870f88f7551b0f2d6aaaa36fb684b5ff8f468107 which removed a different unused variable (disp) fetched from the modified insn location and which held the displacement value referenced by the comment. > /* Compute the rip-relative address. */ > insn_length = gdb_buffered_insn_length (gdbarch, dsc->insn_buf.data (), -- John Baldwin