From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 3C5263857C4D for ; Wed, 19 Aug 2020 02:56:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3C5263857C4D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 857FE1E009; Tue, 18 Aug 2020 22:56:15 -0400 (EDT) Subject: Re: [RFC PATCH] gdb: add linux_nat_debug_printf macro To: Tom Tromey , Simon Marchi via Gdb-patches Cc: Simon Marchi References: <20200702193034.22279-1-simon.marchi@efficios.com> <87y2nopsjz.fsf@tromey.com> From: Simon Marchi Message-ID: <3728b768-05d6-c6de-c28e-d059b71360db@simark.ca> Date: Tue, 18 Aug 2020 22:56:14 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <87y2nopsjz.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Aug 2020 02:56:21 -0000 On 2020-07-12 1:11 p.m., Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> To address both of these issues, I suggest adding this macro for > Simon> printing debug statements, which automatically includes the function > Simon> name. It also includes the `[linux-nat]` prefix to clarify which part > Simon> of GDB printed this (I think that ideally, all debug prints would > Simon> include such a tag). > > Yeah. After seeing your patch I think all the debug prints should be > done this way. > > Simon> The `__func__` magic symbol is used to get the function name. > Simon> Unfortunately, in the case of methods, it only contains the method name, > > We could check for GCC and use __PRETTY_FUNCTION__, though that is the > full signature, so it might be pretty long. I remember I tried it and didn't like it much. Printing longer identifiers didn't help readability. And usually we have enough context to know what the debug statement is about, especially with the [linux-nat] prefix. I pushed the patch, since the feedback was positive. Simon