From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23350 invoked by alias); 17 Oct 2019 01:14:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23318 invoked by uid 89); 17 Oct 2019 01:14:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (207.211.31.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Oct 2019 01:14:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571274861; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QxeGWSXWfQEi1Uv4ve63Sw5sz08uiQoeO/DtDFuEFak=; b=BN7InrNYP/vyTYYGR6BRbUhLJe1hhvgvJgpiZP05ixTW6zDQ7rw14TKC1IlyvrKwHfwGvt bTE9NpatjoSRng5NnF42mNndY01MoTq71aZp0RBA80Og83s7ZWm1d68wmfwnoHbZJy8B/x WL59+OfXd9i0ij8OYW+6/JDqcL5PfsU= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-331-aqWmSn14OySuy_WID-zhtg-1; Wed, 16 Oct 2019 21:14:20 -0400 Received: by mail-wr1-f69.google.com with SMTP id s9so185134wrw.23 for ; Wed, 16 Oct 2019 18:14:20 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id u1sm541409wmc.38.2019.10.16.18.14.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Oct 2019 18:14:16 -0700 (PDT) Subject: Re: [PATCH 10/23] Some get_last_target_status tweaks To: Tom Tromey References: <20190906232807.6191-1-palves@redhat.com> <20190906232807.6191-11-palves@redhat.com> <87v9u18foq.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <371b0191-73b3-846e-df59-faeb8a46067d@redhat.com> Date: Thu, 17 Oct 2019 01:14:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <87v9u18foq.fsf@tromey.com> X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2019-10/txt/msg00539.txt.bz2 On 9/9/19 7:53 PM, Tom Tromey wrote: >>>>>> "Pedro" =3D=3D Pedro Alves writes: >=20 > Pedro> - Declare nullify_last_target_wait_ptid in a header, and remove the > Pedro> local extern declaration from linux-fork.c. >=20 > Pedro> diff --git a/gdb/infrun.h b/gdb/infrun.h > Pedro> index 30374ee51c..042edbbb66 100644 > Pedro> --- a/gdb/infrun.h > Pedro> +++ b/gdb/infrun.h > Pedro> @@ -107,6 +107,8 @@ extern void get_last_target_status (ptid_t *pt= id, > Pedro> extern void set_last_target_status (ptid_t ptid, > Pedro> struct target_waitstatus status); >=20=20 > Pedro> +extern void nullify_last_target_wait_ptid (); >=20 > This could use an intro comment. >=20 I've added: +/* Clear the cached copy of the last ptid/waitstatus returned by + target_wait(). */ Also moved the intro comments of get_last_target_status / set_last_target_s= tatus to the header file. Thanks, Pedro Alves