From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19370 invoked by alias); 28 Sep 2017 22:06:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18956 invoked by uid 89); 28 Sep 2017 22:06:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=yours X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Sep 2017 22:06:52 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 085CF4E341; Thu, 28 Sep 2017 22:06:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 085CF4E341 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0E86618C57; Thu, 28 Sep 2017 22:06:49 +0000 (UTC) Subject: Re: [RFA 05/12] Remove some cleanups from stack.c To: Tom Tromey , gdb-patches@sourceware.org References: <20170928195011.27382-1-tom@tromey.com> <20170928195011.27382-6-tom@tromey.com> From: Pedro Alves Message-ID: <371879b9-b688-e74c-5d82-f3688f21eb5d@redhat.com> Date: Thu, 28 Sep 2017 22:06:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170928195011.27382-6-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00890.txt.bz2 On 09/28/2017 08:50 PM, Tom Tromey wrote: > This removes some cleanups from stack.c by using std::string or > gdb::unique_xmalloc_ptr. One cleanup remains in this file; I did not > remove it here because it is handled in another patch series that has > yet to be resolved. > > gdb/ChangeLog > 2017-09-28 Tom Tromey > > * stack.c (parse_frame_specification): Use std::string > (info_frame_command): Use gdb::unique_xmalloc_ptr. OK. The cp_remove_param-related changes reminded me of: https://sourceware.org/ml/gdb-patches/2017-06/msg00029.html (the last hunk) I think I'll apply that soon, once yours is in. Thanks, Pedro Alves