From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 80B5E385703C for ; Fri, 11 Sep 2020 13:59:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 80B5E385703C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2CD70AFDC; Fri, 11 Sep 2020 13:59:35 +0000 (UTC) Subject: Re: [PATCH v2] Enable gdb.cp/ambiguous.exp with GCC and clang To: Pedro Alves , Gary Benson Cc: gdb-patches@sourceware.org References: <1597670664-14171-1-git-send-email-gbenson@redhat.com> <4b7a4f2e-9e77-495a-759b-187aebb342aa@palves.net> <20200825142146.GA14101@blade.nx> <20200827103901.GA9478@blade.nx> <20200827150741.GA18029@blade.nx> <681377e5-17f6-7bf3-1dde-3b6d85bed70f@palves.net> <20200827161850.GA22365@blade.nx> <413512b9-dd0d-145c-52ca-5befae84b203@palves.net> From: Tom de Vries Autocrypt: addr=tdevries@suse.de; keydata= xsBNBF0ltCcBCADDhsUnMMdEXiHFfqJdXeRvgqSEUxLCy/pHek88ALuFnPTICTwkf4g7uSR7 HvOFUoUyu8oP5mNb4VZHy3Xy8KRZGaQuaOHNhZAT1xaVo6kxjswUi3vYgGJhFMiLuIHdApoc u5f7UbV+egYVxmkvVLSqsVD4pUgHeSoAcIlm3blZ1sDKviJCwaHxDQkVmSsGXImaAU+ViJ5l CwkvyiiIifWD2SoOuFexZyZ7RUddLosgsO0npVUYbl6dEMq2a5ijGF6/rBs1m3nAoIgpXk6P TCKlSWVW6OCneTaKM5C387972qREtiArTakRQIpvDJuiR2soGfdeJ6igGA1FZjU+IsM5ABEB AAHNH1RvbSBkZSBWcmllcyA8dGRldnJpZXNAc3VzZS5kZT7CwKsEEwEIAD4WIQSsnSe5hKbL MK1mGmjuhV2rbOJEoAUCXSW0JwIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAh CRDuhV2rbOJEoBYhBKydJ7mEpsswrWYaaO6FXats4kSgc48H/Ra2lq5p3dHsrlQLqM7N68Fo eRDf3PMevXyMlrCYDGLVncQwMw3O/AkousktXKQ42DPJh65zoXB22yUt8m0g12xkLax98KFJ 5NyUloa6HflLl+wQL/uZjIdNUQaHQLw3HKwRMVi4l0/Jh/TygYG1Dtm8I4o708JS4y8GQxoQ UL0z1OM9hyM3gI2WVTTyprsBHy2EjMOu/2Xpod95pF8f90zBLajy6qXEnxlcsqreMaqmkzKn 3KTZpWRxNAS/IH3FbGQ+3RpWkNGSJpwfEMVCeyK5a1n7yt1podd1ajY5mA1jcaUmGppqx827 8TqyteNe1B/pbiUt2L/WhnTgW1NC1QDOwE0EXSW0JwEIAM99H34Bu4MKM7HDJVt864MXbx7B 1M93wVlpJ7Uq+XDFD0A0hIal028j+h6jA6bhzWto4RUfDl/9mn1StngNVFovvwtfzbamp6+W pKHZm9X5YvlIwCx131kTxCNDcF+/adRW4n8CU3pZWYmNVqhMUiPLxElA6QhXTtVBh1RkjCZQ Kmbd1szvcOfaD8s+tJABJzNZsmO2hVuFwkDrRN8Jgrh92a+yHQPd9+RybW2l7sJv26nkUH5Z 5s84P6894ebgimcprJdAkjJTgprl1nhgvptU5M9Uv85Pferoh2groQEAtRPlCGrZ2/2qVNe9 XJfSYbiyedvApWcJs5DOByTaKkcAEQEAAcLAkwQYAQgAJhYhBKydJ7mEpsswrWYaaO6FXats 4kSgBQJdJbQnAhsMBQkDwmcAACEJEO6FXats4kSgFiEErJ0nuYSmyzCtZhpo7oVdq2ziRKD3 twf7BAQBZ8TqR812zKAD7biOnWIJ0McV72PFBxmLIHp24UVe0ZogtYMxSWKLg3csh0yLVwc7 H3vldzJ9AoK3Qxp0Q6K/rDOeUy3HMqewQGcqrsRRh0NXDIQk5CgSrZslPe47qIbe3O7ik/MC q31FNIAQJPmKXX25B115MMzkSKlv4udfx7KdyxHrTSkwWZArLQiEZj5KG4cCKhIoMygPTA3U yGaIvI/BGOtHZ7bEBVUCFDFfOWJ26IOCoPnSVUvKPEOH9dv+sNy7jyBsP5QxeTqwxC/1ZtNS DUCSFQjqA6bEGwM22dP8OUY6SC94x1G81A9/xbtm9LQxKm0EiDH8KBMLfQ== Message-ID: <36f90b5a-2994-69fc-35c3-be274679552f@suse.de> Date: Fri, 11 Sep 2020 15:59:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <413512b9-dd0d-145c-52ca-5befae84b203@palves.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Sep 2020 13:59:22 -0000 On 8/27/20 8:04 PM, Pedro Alves wrote: > On 8/27/20 5:18 PM, Gary Benson wrote: >> Pedro Alves wrote: >>> On 8/27/20 4:07 PM, Gary Benson wrote: >>>> Pedro Alves wrote: >>>>> On 8/27/20 11:39 AM, Gary Benson wrote: >>>>>> Luis Machado wrote: >>>>>>> I get the following, under Ubuntu 18.04 (GCC 7.x) with this commit... >>>>>>> >>>>>>> FAIL: gdb.cp/ambiguous.exp: print x.x >>>>>>> FAIL: gdb.cp/ambiguous.exp: print n.x >>>>>>> FAIL: gdb.cp/ambiguous.exp: print j.x >>>>>>> FAIL: gdb.cp/ambiguous.exp: print jva1.x >>>>>>> FAIL: gdb.cp/ambiguous.exp: print jva2.x >>>>>>> FAIL: gdb.cp/ambiguous.exp: print (A1)j >>>>>>> FAIL: gdb.cp/ambiguous.exp: print (A1)jva1 >>>>>>> >>>>>>> Is the test really supposed to run with older GCC's? >>>>>> >>>>>> Maybe not. Though, I don't know what version of GCC it ought to >>>>>> start working on, so it's hard to know what to do. I could leave >>>>>> the "-w" in for GCC < 10, and add an extra check to make it bail >>>>>> out for GCC <= your version, Luis? With a suitable comment to >>>>>> mention that that's not set in stone? >>>>> >>>>> I'm seeing it fail with GCC 9 and clang 10 as well. >>>>> >>>>> Actually, the testcase can't be working _anywhere_. It's testing a >>>>> feature that is gone from GDB. >>>> [snip] >>>>> ...search_struct_field does not handle the ambiguous field >>>>> case nowadays. Somehow it got lost over the years. >>>>> That seems like a regression. I wrote up a patch that adds >>>>> it back (though different), but it exposed other latent >>>>> bugs... Sigh. I'll post it soon. >>>> >>>> So the test would start passing if that patch was added? >>>> Should we leave the test alone, or XFAIL the cases that >>>> fail, or...? >>> >>> I'm adjusting / fixing the testcase at the same time as I'm >>> patching GDB. So for now, do nothing. >> >> Awesome, thank you. > > I've sent it now, here: > > [PATCH] Reject ambiguous C++ field accesses > https://sourceware.org/pipermail/gdb-patches/2020-August/171526.html > With the gdb 10 branching planned to happen soon, I've marked these FAILs as KFAIL, in order to make sure that these won't show up as "unexpected failure" in the gdb 10 release. Thanks, - Tom