From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27909 invoked by alias); 27 Jun 2017 15:35:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27811 invoked by uid 89); 27 Jun 2017 15:35:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,RCVD_IN_SORBS_SPAM,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Jun 2017 15:35:30 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1B7FAC04D2A4; Tue, 27 Jun 2017 15:35:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1B7FAC04D2A4 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1B7FAC04D2A4 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6799E87FBD; Tue, 27 Jun 2017 15:35:28 +0000 (UTC) Subject: Re: [PATCH 08/40] completion_list_add_name wrapper functions To: Yao Qi References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-9-git-send-email-palves@redhat.com> <8637alfv2m.fsf@gmail.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <36c8482a-1cdd-997f-2e7c-90d46e7cda22@redhat.com> Date: Tue, 27 Jun 2017 15:35:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <8637alfv2m.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00732.txt.bz2 On 06/27/2017 01:56 PM, Yao Qi wrote: >> gdb/ChangeLog: >> yyyy-mm-dd Pedro Alves >> >> * symtab.c (COMPLETION_LIST_ADD_SYMBOL) >> (MCOMPLETION_LIST_ADD_SYMBOL): Delete macros, replace with ... >> (completion_list_add_symbol, completion_list_add_msymbol): >> ... these new functions. >> (add_symtab_completions) >> (default_make_symbol_completion_list_break_on_1): Adjust. > > It is obvious. Patch is good to me. > Pushed in too. Thanks, Pedro Alves