RE: [patch] Do not disappoint on "Create a core file of GDB?"

Pierre Muller
2010-03-31T13:38:14Z

Nevertheless, the patch
http://sourceware.org/ml/gdb-cvs/2010-01/msg00131.html
caused a re-entry of 'abort' rule in the ARI critical at
http://sourceware.org/gdb/current/ari/

Because the script gdb_ari.sh expects exactly 4 occurences of abort()
in gdb/utils.c source.

As the fix is rather obvious (see below),
I committed it as obvious.

Pierre Muller
as ARI maintainer...
(not very active on that part lately :().

===================================================================
RCS file: /cvs/gdbadmin/ss/gdb_ari.sh,v
retrieving revision 1.99
diff -c -r1.99 gdb_ari.sh
*** gdb_ari.sh 6 Oct 2009 21:15:08 -0000 1.99
--- gdb_ari.sh 31 Mar 2010 13:27:38 -0000
***************
*** 637,643 ****
BEGIN { doc["abort"] = "\
Do not use abort, instead use internal_error; GDB should never abort"
category["abort"] = ari_regression
! fix("abort", "gdb/utils.c", 4)
}
/(^|[^_[:alnum:]])abort[[:space:]]*\(/ {
fail("abort")
--- 637,643 ----
BEGIN { doc["abort"] = "\
Do not use abort, instead use internal_error; GDB should never abort"
category["abort"] = ari_regression
! fix("abort", "gdb/utils.c", 3)
}
/(^|[^_[:alnum:]])abort[[:space:]]*\(/ {
fail("abort")

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Mark Kettenis
> Envoyé : Sunday, January 31, 2010 3:13 PM
> À : jan.kratochvil@redhat.com
> Cc : gdb-patches@sourceware.org
> Objet : Re: [patch] Do not disappoint on "Create a core file of GDB?"
>
> > Date: Sat, 30 Jan 2010 15:47:23 +0100
> > From: Jan Kratochvil <jan.kratochvil@redhat.com>
> >
> > On Sat, 30 Jan 2010 14:05:06 +0100, Mark Kettenis wrote:
> > > I fear that after you did that the "NOTE: GDB has only three calls
> to
> > > abort()." comment is no longer true.
> >
> > There were four calls and there are three calls now. The message has
> been
> > updated:
> > http://sources.redhat.com/cgi-
> bin/cvsweb.cgi/src/gdb/utils.c.diff?cvsroot=src&r1=1.221&r2=1.222
> > + abort (); /* NOTE: GDB has only three calls to
abort().
> */
> > - abort (); /* NOTE: GDB has only four calls to abort(). */
> > + abort (); /* NOTE: GDB has only three calls to abort(). */
> > - abort (); /* NOTE: GDB has only four calls to abort(). */
> > + abort (); /* NOTE: GDB has only three calls to abort().
> */
> > - abort (); /* NOTE: GDB has only four calls to abort().
> */
> > - abort (); /* NOTE: GDB has only four calls to abort().
> */
> >
> > and current HEAD:
> > $ grep 'GDB has only.*abort' *
> > utils.c: abort (); /* NOTE: GDB has only three calls to
> abort(). */
> > utils.c: abort (); /* NOTE: GDB has only three calls to
abort().
> */
> > utils.c: abort (); /* NOTE: GDB has only three calls to
> abort(). */
> >
> > The ChangeLog entry
> > http://sources.redhat.com/cgi-
> bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.11253&r2=1.11254
> > describes thise "four"->"three" word change by:
> > (internal_vproblem): Update the comment.
> > which may have been insufficient, sorry.
>
> Hmm, my diff-reading skills may have been affected by jetlag. Sorry
> for the noise!