Re: [patch] Do not disappoint on "Create a core file of GDB?"

Jan Kratochvil
2010-01-30T14:47:42Z

On Sat, 30 Jan 2010 14:05:06 +0100, Mark Kettenis wrote:
> I fear that after you did that the "NOTE: GDB has only three calls to
> abort()." comment is no longer true.

There were four calls and there are three calls now. The message has been
updated:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/utils.c.diff?cvsroot=src&r1=1.221&r2=1.222
+ abort (); /* NOTE: GDB has only three calls to abort(). */
- abort (); /* NOTE: GDB has only four calls to abort(). */
+ abort (); /* NOTE: GDB has only three calls to abort(). */
- abort (); /* NOTE: GDB has only four calls to abort(). */
+ abort (); /* NOTE: GDB has only three calls to abort(). */
- abort (); /* NOTE: GDB has only four calls to abort(). */
- abort (); /* NOTE: GDB has only four calls to abort(). */

and current HEAD:
$ grep 'GDB has only.*abort' *
utils.c: abort (); /* NOTE: GDB has only three calls to abort(). */
utils.c: abort (); /* NOTE: GDB has only three calls to abort(). */
utils.c: abort (); /* NOTE: GDB has only three calls to abort(). */

The ChangeLog entry
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.11253&r2=1.11254
describes thise "four"->"three" word change by:
(internal_vproblem): Update the comment.
which may have been insufficient, sorry.

Thanks,
Jan