From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19397 invoked by alias); 3 Nov 2017 01:21:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19116 invoked by uid 89); 3 Nov 2017 01:21:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:841, rfa X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 Nov 2017 01:21:03 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id vA31Ku5m012857 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 2 Nov 2017 21:21:01 -0400 Received: by simark.ca (Postfix, from userid 112) id 7830A1E533; Thu, 2 Nov 2017 21:20:56 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 6855E1E4C4; Thu, 2 Nov 2017 21:20:55 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 03 Nov 2017 01:21:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 06/13] Replace start_rbreak_breakpoints and end_rbreak_breakpoints In-Reply-To: <20171102223612.3642-7-tom@tromey.com> References: <20171102223612.3642-1-tom@tromey.com> <20171102223612.3642-7-tom@tromey.com> Message-ID: <368bfe6be1612beb89c174c35e0cc73a@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.2 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 3 Nov 2017 01:20:56 +0000 X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00058.txt.bz2 On 2017-11-02 18:36, Tom Tromey wrote: > static void > rbreak_command (char *regexp, int from_tty) > { > - struct cleanup *old_chain; > char *string = NULL; > int len = 0; > const char **files = NULL; > @@ -4550,8 +4541,7 @@ rbreak_command (char *regexp, int from_tty) > FUNCTIONS_DOMAIN, > nfiles, files); > > - start_rbreak_breakpoints (); > - old_chain = make_cleanup (do_end_rbreak_breakpoints, NULL); > + scoped_rbreak_breakpoints finalize; > for (const symbol_search &p : symbols) > { > if (p.msymbol.minsym == NULL) > @@ -4596,8 +4586,6 @@ rbreak_command (char *regexp, int from_tty) > MSYMBOL_PRINT_NAME (p.msymbol.minsym)); > } > } > - > - do_cleanups (old_chain); > } > Your patch LGTM. But how is the "string" string freed in rbreak_command? Simon