From: Tristan Gingold <gingold@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: FYI: fix build failure
Date: Mon, 05 Mar 2012 14:56:00 -0000 [thread overview]
Message-ID: <3684C6F7-4FFA-4C1E-BC29-76355680F219@adacore.com> (raw)
In-Reply-To: <87399nxfo1.fsf@fleche.redhat.com>
On Mar 5, 2012, at 3:53 PM, Tom Tromey wrote:
> I'm checking this in.
>
> I did a --enable-targets=all build and got a build failure:
>
> /home/tromey/gnu/archer/build/gdb/../../archer/gdb/ia64-vms-tdep.c:162: multiple definition of `_initialize_ia64_hpux_tdep'
> ia64-hpux-tdep.o:/home/tromey/gnu/archer/build/gdb/../../archer/gdb/ia64-hpux-tdep.c:431: first defined here
>
> The fix is to rename the VMS function, which seems obviously misnamed to
> me.
My fault. Sorry, I missed this renaming.
Thank you for fixing it.
Tristan.
>
> Tom
>
> 2012-03-05 Tom Tromey <tromey@redhat.com>
>
> * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Rename from
> _initialize_ia64_hpux_tdep.
>
> diff --git a/gdb/ia64-vms-tdep.c b/gdb/ia64-vms-tdep.c
> index 859c0b4..66920b1 100644
> --- a/gdb/ia64-vms-tdep.c
> +++ b/gdb/ia64-vms-tdep.c
> @@ -155,10 +155,10 @@ ia64_openvms_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
> }
>
> /* Provide a prototype to silence -Wmissing-prototypes. */
> -extern initialize_file_ftype _initialize_ia64_hpux_tdep;
> +extern initialize_file_ftype _initialize_ia64_vms_tdep;
>
> void
> -_initialize_ia64_hpux_tdep (void)
> +_initialize_ia64_vms_tdep (void)
> {
> gdbarch_register_osabi (bfd_arch_ia64, 0, GDB_OSABI_OPENVMS,
> ia64_openvms_init_abi);
prev parent reply other threads:[~2012-03-05 14:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 14:53 Tom Tromey
2012-03-05 14:56 ` Tristan Gingold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3684C6F7-4FFA-4C1E-BC29-76355680F219@adacore.com \
--to=gingold@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox