From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1678 invoked by alias); 17 Nov 2017 14:02:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1663 invoked by uid 89); 17 Nov 2017 14:02:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.7 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy= X-HELO: mail-wr0-f175.google.com Received: from mail-wr0-f175.google.com (HELO mail-wr0-f175.google.com) (209.85.128.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 Nov 2017 14:02:11 +0000 Received: by mail-wr0-f175.google.com with SMTP id 4so2210673wrt.0 for ; Fri, 17 Nov 2017 06:02:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=G+PF3fQuUg4U3m0Xc8RrE3J3MWrOMzJ5KU+XisnzYfQ=; b=XjYLW/FRp5QEwDamrswhZcepvBGnXRhOR1mbteChCRyr7PqLeYDRVoUNkOgZ1riQMB yyDWWThgnU0Gpb53opfEM1KxLC7scs/BFim/KCWekUBUeRsvqcuktQrf8BZ7aZDak12h RMwH+y/PtDeKo4lTGtfurTvr4QzU8Cd0eICE4w3+CSlTK4a3FM5Ga/asZmkDJ5GCdP96 r2OBO5wreRgU7STijzAruezIEjix6mNYiSNcmjITGWweH+EmMPzgFIDW+36RJdaSlufV 8Z+FxbhZiRTC+9kRh7dSWM1Llr21N9mogq+eV+YEHvyz6ysqhysSK/BU7E0j00s4vipx GRig== X-Gm-Message-State: AJaThX4oG8QsVMjE7/C0Ebb7h/uw0eoFYk3mAherj0JZztdDX8SKS+mQ ASFFCq+johxF3py7nRgkNK0BzCnNydw= X-Google-Smtp-Source: AGs4zMYBGi+pzIoGzaYjEWiwd9fWNFvnyWbp/EDsY9mt2ZdO2wonWM6AHvufethnLhN3etwK6vMhhA== X-Received: by 10.223.164.20 with SMTP id d20mr4883298wra.103.1510927328594; Fri, 17 Nov 2017 06:02:08 -0800 (PST) Received: from ?IPv6:2a02:c7f:ae6a:ed00:4685:ff:fe66:9f4? ([2a02:c7f:ae6a:ed00:4685:ff:fe66:9f4]) by smtp.gmail.com with ESMTPSA id y15sm8854656wrc.96.2017.11.17.06.02.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Nov 2017 06:02:07 -0800 (PST) Subject: Re: [python] Allow explicit locations in breakpoints. To: Eli Zaretskii Cc: simon.marchi@ericsson.com, keiths@redhat.com, gdb-patches@sourceware.org References: <04ccc2c4-7827-eedc-d8db-a83a0167acb6@redhat.com> <58311250-9ab1-39d1-99b6-07478bc8c2ab@redhat.com> <4768c7ad-cc3d-5702-fa93-40e9760d4ee8@ericsson.com> <81f2b22a-ba79-cc7c-ee85-95d2d433a90e@ericsson.com> <1765bb88-8ab0-bdcd-8551-69f8dff3bcb9@redhat.com> <31ad8fb7-0e20-13a5-45d1-c9fa67b76e27@ericsson.com> <83vai9ghh5.fsf@gnu.org> From: Phil Muldoon Message-ID: <36822509-7348-7682-a4b7-89569c8df839@redhat.com> Date: Fri, 17 Nov 2017 14:02:00 -0000 MIME-Version: 1.0 In-Reply-To: <83vai9ghh5.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00337.txt.bz2 On 17/11/17 13:30, Eli Zaretskii wrote: >> From: Phil Muldoon >> Date: Fri, 17 Nov 2017 11:02:08 +0000 >> >> I just realised this needs a doc review also. > > Doc review coming up. > >> diff --git a/gdb/NEWS b/gdb/NEWS >> index 9246659bfb..592fe70156 100644 >> --- a/gdb/NEWS >> +++ b/gdb/NEWS >> @@ -24,6 +24,9 @@ >> gdb.new_thread are emitted. See the manual for further >> description of these. >> >> + ** Python breakpoints can now accept explicit locations. See the >> + manual for a further description of this feature. > > I think "a further" should lose the "a" part. Also, how about > mentioning the node name in the manual where this is described? OK. >> +@code{break} command or, in the case of a watchpoint, by the >> +@code{watch} command. Alternatively, create a new a explicit location > ^^^^^^^^^^^^^^^^^^^^^^^ > The second "a" should be deleted. OK. The other comments refer to existing documentation that I have not actually changed. I formatted the paragraph with the additional sentence I added and re-formatted (the wrapping affected the whole paragraph). I have no problem making the changes you suggest, they are good, but can I please make them in another patchset so the changes made in this one stay related? For the purposes of clarity, the related changes in this patch are: +@defun Breakpoint.__init__ (spec @r{[}, type @r{[}, wp_class @r{[}, internal @r{[}, temporary @r{]}, source @r{]}, function @r{]}, label @r{]}, line @r{]]]]]]]]}) and +Alternatively, create a new a explicit location +breakpoint (@pxref{Explicit Locations}) according to the +specifications contained in the key words @var{source}, +@var{function}, @var{label} and @var{line}. Cheers Phil