From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cbpqHMZIiWBIIwAAWB0awg (envelope-from ) for ; Wed, 28 Apr 2021 07:36:38 -0400 Received: by simark.ca (Postfix, from userid 112) id 6D1121F11C; Wed, 28 Apr 2021 07:36:38 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6F76A1E01F for ; Wed, 28 Apr 2021 07:36:37 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 287013939C0D; Wed, 28 Apr 2021 11:36:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 287013939C0D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619609797; bh=q6drLGXSZi7ltGuPCLc/qS8quNAlE8cnMRdE7yzXfNE=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=MjfQkIlnrxmWwwX3YzlbP5/BJmfmMJwFCxeLRP5fO7qB/NEyqKglYHIVBf1K3emeC qm0hphPO0GzrYzIdzUOMrGCO7MDMV6UwAK8TFEuUf0UsxdNZaGUMBEs8PvIz/o5NTi TFathToA0hg7IQUszay0x/fk/iJhcGHqJefB8ABY= Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2088.outbound.protection.outlook.com [40.107.243.88]) by sourceware.org (Postfix) with ESMTPS id 0362E3939C33 for ; Wed, 28 Apr 2021 11:36:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0362E3939C33 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KB9WlIAyRq2oOwX/rdQJeQhkQ53CBVojRRodNKw+voRtJ1fBPp1igHc0xzUbRd+a04QeQe5JFDj2PMQmzg3i7dnW/PB5SeDAKigWuWQVOwIyNOHZ7c/APjlSad51nr4c8EOk29Y/WECUqUEk7EjuoUzyQ9w1NABwk7W44oaeiEr6JqKVFI8VzSssm4ecH94trV95GB6S8j06x4Zh4VlYIq++nPjXWGAogX+BxnYRtlUhp9WOcH+SX0tJ5p1MCeYn2kuOl5UuSH40AA3fpnDcxGa5cUBG9FLxP0Mcl46ZDKTaSB+cssA099tdbhNU5kfPTaIz2WcCnDrXh2Mp2YXE1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q6drLGXSZi7ltGuPCLc/qS8quNAlE8cnMRdE7yzXfNE=; b=KOl2yEtBrlXfz5XA8fiW9TdB2FGY5x0hExqH5U39oNXeqrFS5Czdujs2olYqiyQ/twu8KRlRHiId9brj9qYCbLffi/4NkJf8RcOwA1YW9e3NTTQAqogL7ZxgSe5esWz2uy1LMcdGNO5fW7T/scL/dSiKViDZntac4TCS8Lz1Vv/OGSFce1+kCL5c1Ze5IyKifAgBIcik4Ar5RhAn8uijmaxsa+CVZ9R2f2jsk/FRAD8BOID4cEwBRJEiAR2VnTFJU84m6uM1RhVlnWwbMfzohJd5oIdzQbuJt6ONYK12HAZsei+nEvuhALufQzf5Ak3eGTJIUVq1fljgKgeBmFSNdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) by DM6PR12MB3387.namprd12.prod.outlook.com (2603:10b6:5:3a::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.20; Wed, 28 Apr 2021 11:36:33 +0000 Received: from DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::49d0:1ee5:47ef:e0e5]) by DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::49d0:1ee5:47ef:e0e5%7]) with mapi id 15.20.4065.023; Wed, 28 Apr 2021 11:36:33 +0000 Subject: Re: [PATCH 09/43] Move push_dwarf_reg_entry_value to expr.c To: Simon Marchi , gdb-patches@sourceware.org References: <20210301144620.103016-1-Zoran.Zaric@amd.com> <20210301144620.103016-10-Zoran.Zaric@amd.com> Message-ID: <36655beb-b174-64b5-97a1-df41fc4e5516@amd.com> Date: Wed, 28 Apr 2021 12:36:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [2a00:23c7:5a85:6801:f5b0:44e8:2b3e:76c1] X-ClientProxiedBy: LO2P265CA0484.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::9) To DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2a00:23c7:5a85:6801:f5b0:44e8:2b3e:76c1] (2a00:23c7:5a85:6801:f5b0:44e8:2b3e:76c1) by LO2P265CA0484.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.27 via Frontend Transport; Wed, 28 Apr 2021 11:36:33 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 31c557fe-4fe9-4092-dc19-08d90a39dff6 X-MS-TrafficTypeDiagnostic: DM6PR12MB3387: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eP36butd1ShAw5Y1cjW21qduTQU55ix4BoQyATC1AtFb3vIoQQaOq3kltfZSWZnEmnGsG2SDlCrydJKmqg25Ldy/kBkRreReJuJo00ME+wpqcdQTjteCyHgtAmSHl8ZlR43YfoI6KkcCYEQ4r8yri7mqI/b++0jupXY+QKL5Xg7dhRCKechuZV8rTlhM9MXaTagUYc65GypRhMSdoVoVCzjrn9mAxHsSGHq4RXL4aMzRKusvvEHb3aWWy7u0xm1M3vbGZLB6joxwY0oE2nfxTQVDpJfd58Dv8ssjqk4/3rzblWIfk7TwkD664A06e6SriLByYooQzh1xBI8aHMEIyBkyuzdBFn3hJMRd5Uqtg5fegIbTz/B7SCb4yTlB/TiftgCw7lfth6XuB2QP2VYVgE3o3L6Ycg4hKhkWytq5LGYEOx5j8Shk9JbznzMlN8vDQZ9jk7GD/RkfJiBuoDcyauhjpHatTJWjnZSQ5NRv0odkrs+SVjoJG/IogJCbfu3+Br/bTPg4GHuxEvnmzKNJU7+8V0yEIKNPcRoBZmEPiHLuMStPXWX6V0fXP8CeztBXyPoV6+xSA/hPPXWYP9lNLgkZNd50ruL477PR/lKxD05m0mFGKqQLm5ZEM9QJMs1aOfMBTJ9Y/gqzqMe84PE9RXJYrvAS234RGeBJOnLYIcs1AwZNim+WolFHkz5qERK1 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2762.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(39860400002)(136003)(396003)(376002)(346002)(36756003)(38100700002)(2906002)(316002)(6666004)(5660300002)(478600001)(86362001)(8936002)(2616005)(53546011)(186003)(66476007)(8676002)(52116002)(31696002)(66556008)(31686004)(6486002)(16526019)(66946007)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?R283bElVS1FrbGkvMVJwOUM1UExvamZqd1ZLNitXRVNkSlZWSjdjK0lXbElS?= =?utf-8?B?c01URG1jZ29xU1g3QVdWV0tvZFJUSk82VUczcncxenNhVEpJQUpCVzlMRHdL?= =?utf-8?B?dmJKVWVYaC9SN1MzbFRpcHBDWS9LRzVZdWdDZDMzMmtxTEtLbHVjeUxEemxF?= =?utf-8?B?UlpyNjFPS3RLSENBekxDaTlkWG83UkNpNEJaOU9pbldieVhTVGNnN3RGZFYr?= =?utf-8?B?K3pRRTliMExtZm8rZExtdDMwTERmV2Jsa2RqdUdtOVV4eHh5QndHT1VLZmV1?= =?utf-8?B?eUVSNnZIOTViUVJYTFczdytEeUZxaDBmdGxnL3JPbnNIN3RNbTZVWGNnZFl3?= =?utf-8?B?MVB4R1ZKUkNKVUVpd2FUMlZoWkVEZzRMSUdpZ2FieXZ5NEVMdnVxWXRJOWIr?= =?utf-8?B?WmpXSXZZWmUwWXlFWS9KMTFtN1hLcGZVZDRsT2JGT2E5cU42a2JReFRCdmNL?= =?utf-8?B?cnVwNTdDVnJycnhiQ2dmZFVGNVhUTVo5WTdUNUxqQkdBVzNUQXJ6dElHWFJC?= =?utf-8?B?ZjBBZWFDTHVBd3FITGxDTzBDKzUrby90TXpwOE9pRU1lb3dydjlxOWF2L3RW?= =?utf-8?B?cVczM2ZsNUxQNm5ZdUEyYjhrbnhYZ3RYemdib0RFblA1U0puNkFSaFNETXFt?= =?utf-8?B?eFlUWVVTY0kvWDZ2MjhkRmZoUEM0anNnVWVsNEMwSWczTm0zN0JZN3hHY0lP?= =?utf-8?B?ZlBrVDUvT3Q2TkZ4dy9sdUt5UmE4bWV4SGlsWi9rSWtLM1ZDWE1HVWxZVGJD?= =?utf-8?B?eU0raUxwUmJIKy9PalVrbG1ORDhkcEFaWG5OYXpxQi9jYnBqMGtnd1ludWgv?= =?utf-8?B?R0FXejBiMXJ2M0dZN3Z2c21GYjR4L0drczFFUE0vblpOK05ZM041V2VMbis1?= =?utf-8?B?V2NWTDA0TWV5cW16VDR4a0lISFJBeEtpUXlyNlZURUtzY0ZJcGdpd0NydzA0?= =?utf-8?B?eUtmdk56bllYUEtBRjgrT3BqOHI0ZlloRTdDc2d5UmVHbkJCcStqS2dWNWdu?= =?utf-8?B?QVpybXMwNDljaStzd1IxeWp0QWgzQmxhTE5sa1FKcHpOZFk3ck1ySk9xb1Nr?= =?utf-8?B?ZEFaaGpCTFZWd1U1RE44NXpLTU5FeDRGb3laNGJqUmJ2bFhLUFRtR1hEV3Uy?= =?utf-8?B?VTY4TVFRYVN0ZWlaOHBRQ1ZkR0NKMzJDU3pjZzI2cm5HSHNFalpXSTN1ZktM?= =?utf-8?B?cDFLRFVLSk1LTlQxMGJTc1dTSGU1Syt1SjY0UWhpNkVScS9tN3NzNnN5dnYw?= =?utf-8?B?bThoOVBwQVZUTVBxTU5lc09PYVlzeERTQlVoK2ExMStWQm5oYUphK3Q3WVJZ?= =?utf-8?B?TmFNa0dRaXhwR3ROL3R4b1ErWFU0Zm9ueXJOWjlkcUt4OGpqalVsOFZ1c0ZY?= =?utf-8?B?YWtjZVlVaG1UK0VnbGM0SEtwNjZxeGo0bkc4bWlZU3lTWk53L0hvTkJjV0kx?= =?utf-8?B?RFhGc3F4SnZCL3NNbDNFNlcwNzNKeSthcFhEZ2EwdXpUdGNkWVJ3M3h3RVE1?= =?utf-8?B?Vi9MbEpZQkhwMTJCMkpMN1NXMzBrL3JocmJSU2ozNlNoZFF4SjFvMWZxMXhD?= =?utf-8?B?WGxqYWc2Y3lmN2o3U1BOOEJTa0lsVGp5ZldCZG5NZUszREtNbm01Q0JVdkJi?= =?utf-8?B?cGZjOE0wZkZRZzNpVnF6eWVuajBTOUNBeEdycFpRMmVBQ1JxYzdJb1FBUjRY?= =?utf-8?B?VVZ3N0U0M1U5V3F5SjZlVEp4UU94Q0MvQkNsMmhxd1czZldIcENoc1RxWVlG?= =?utf-8?B?UEpaV0tsbmkrZzdFSHk5WTlXWHpWVksvL3IyQllTVnpuN0NyQjJhaWdWVVlQ?= =?utf-8?B?MDJyd0NYZi91MXRadm54bUZFRUt6c2ZRd0FnVmh1c3hXaGJUazNzQ3JXaG9N?= =?utf-8?Q?B+QI7z5N32Ii+?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 31c557fe-4fe9-4092-dc19-08d90a39dff6 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2762.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2021 11:36:33.7496 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bTo8RTVr4Oz5uu/E2At1RtfGXBJaKpClITs7XVvbHwKF2N31GKL4tGXTbUXGha98//KX/fpuRvJeVjiv1s5FeA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3387 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Zoran Zaric via Gdb-patches Reply-To: Zoran Zaric Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 4/27/21 4:56 AM, Simon Marchi wrote: > [CAUTION: External Email] > >> diff --git a/gdb/dwarf2/expr.c b/gdb/dwarf2/expr.c >> index 872de16cd70..0b7f3c90728 100644 >> --- a/gdb/dwarf2/expr.c >> +++ b/gdb/dwarf2/expr.c >> @@ -268,6 +268,57 @@ dwarf_expr_context::read_mem (gdb_byte *buf, CORE_ADDR addr, >> read_memory (addr, buf, length); >> } >> >> +/* See expr.h. */ >> + >> +void >> +dwarf_expr_context::push_dwarf_reg_entry_value >> + (enum call_site_parameter_kind kind, >> + union call_site_parameter_u kind_u, >> + int deref_size) > > When the parameter list doesn't fit in the right of the name, we > typically to: > > void > dwarf_expr_context::push_dwarf_reg_entry_value > (enum call_site_parameter_kind kind, > union call_site_parameter_u kind_u, > int deref_size)o > > If we need to wrap, we might as well start completely on the left, that > leaves more space :). > > Simon > Thank you, I realized this way after I've created these patches :) I will change that in the next iteration and check for other similar places as well. Zoran