From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-137240-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 86440 invoked by alias); 23 Feb 2017 10:53:46 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 86424 invoked by uid 89); 23 Feb 2017 10:53:45 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Feb 2017 10:53:44 +0000
Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id D433F80467;	Thu, 23 Feb 2017 10:53:44 +0000 (UTC)
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4])	by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1NArhpj032564;	Thu, 23 Feb 2017 05:53:44 -0500
Subject: Re: [PATCH v2 28/31] Use ui_file_as_string throughout more
To: Yao Qi <qiyaoltc@gmail.com>
References: <1476839539-8374-1-git-send-email-palves@redhat.com> <1476968896-13600-1-git-send-email-palves@redhat.com> <86r32pb40h.fsf@gmail.com>
Cc: gdb-patches@sourceware.org
From: Pedro Alves <palves@redhat.com>
Message-ID: <36312e9e-69bd-7c25-7537-6fb1606d29b6@redhat.com>
Date: Thu, 23 Feb 2017 10:53:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <86r32pb40h.fsf@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2017-02/txt/msg00617.txt.bz2

On 02/23/2017 10:22 AM, Yao Qi wrote:

>>  
>>    /* Value of this item.  */
>>    struct value *value;
>> @@ -67,6 +67,6 @@ struct varobj_iter_ops
>>        if ((ITER) != NULL)		       \
>>  	{				       \
>>  	  (ITER)->ops->dtor (ITER);	       \
>> -	  xfree (ITER);		       \
>> +	  delete (ITER);		       \
> 
> We don't need to use "delete" for varobj_iter, because you didn't add
> std::string member in varobj_iter.  This change causes an ASAN error,

Whoops.

> reverting the change above fixes the error.  We can also C++-fy
> varobj_iter, but I'd like to do in another patch.  How is the patch below?

LGTM.

Thanks,
Pedro Alves