From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73378 invoked by alias); 10 Jul 2018 03:38:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72520 invoked by uid 89); 10 Jul 2018 03:38:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=belonging, cust X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Jul 2018 03:38:42 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 0CCEC1E08D; Mon, 9 Jul 2018 23:38:41 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1531193921; bh=mbKV2+zozEsqdXE1/jpNJHnw526p3+bgp8kLC+GdqK8=; h=Subject:To:References:From:Date:In-Reply-To:From; b=KS6WmgaYR35aDf3dvqGi3dYOQD11yxXV/hbXEyUx8dBc5WHd4hxC8/kvlqtMP8I9D RHVQrAhuYnPiHZhRMdbz2uqQdbwHuPwtrQJ5e7CaBfrMQKUFE+z4rJ1XaWlRO3FHFc idSmK+LMTx3JFEu6XY4swgPxWwtX5wxnC5Yjoy+g= Subject: Re: [RFA 29/42] Move the symbol lists to buildsym_compunit To: Tom Tromey , gdb-patches@sourceware.org References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-30-tom@tromey.com> From: Simon Marchi Message-ID: <362705eb-9df0-3e02-ce2b-e5bb3cf5b207@simark.ca> Date: Tue, 10 Jul 2018 03:38:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180523045851.11660-30-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00245.txt.bz2 On 2018-05-23 12:58 AM, Tom Tromey wrote: > @@ -1551,26 +1556,27 @@ augment_type_symtab (void) > complaint (&symfile_complaints, > _("Line numbers recorded in a type symtab")); > > - if (file_symbols != NULL) > + if (*get_file_symbols () != NULL) > { > struct block *block = BLOCKVECTOR_BLOCK (blockvector, STATIC_BLOCK); > > /* First mark any symbols without a specified symtab as belonging > to the primary symtab. */ > - set_missing_symtab (file_symbols, cust); > + set_missing_symtab (buildsym_compunit->m_file_symbols, cust); > > - dict_add_pending (BLOCK_DICT (block), file_symbols); > + dict_add_pending (BLOCK_DICT (block), buildsym_compunit->m_file_symbols); > } I find it a bit odd to use get_file_symbols () in the "if" but buildsym_compunit->m_file_symbols later. I guess it would make sense for what will eventually become a method of buildsym_compunit to access the field directly. The same occurs at different places, with different fields. Otherwise, LGTM considering Keith's comments. Simon