From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53175 invoked by alias); 2 Oct 2017 09:00:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53120 invoked by uid 89); 2 Oct 2017 09:00:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=lynx, satisfactory, Hx-languages-length:1049 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 Oct 2017 09:00:39 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v9290WwW011926 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 2 Oct 2017 05:00:37 -0400 Received: by simark.ca (Postfix, from userid 112) id DDCD91E53B; Mon, 2 Oct 2017 05:00:32 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 1C3D11E515; Mon, 2 Oct 2017 05:00:29 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 02 Oct 2017 09:00:00 -0000 From: Simon Marchi To: Joel Brobecker Cc: Simon Marchi , gdb-patches@sourceware.org, qiyaoltc@gmail.com Subject: Re: [PATCH] nto & lynx x86: call init_target_desc In-Reply-To: <20170922151408.pmyflf36v6jh2xj2@adacore.com> References: <1506092746-17214-1-git-send-email-simon.marchi@ericsson.com> <20170922151408.pmyflf36v6jh2xj2@adacore.com> Message-ID: <356f1abe1566f622570dc5be92d3c32d@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 2 Oct 2017 09:00:33 +0000 X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00014.txt.bz2 On 2017-09-22 17:14, Joel Brobecker wrote: > Hi Simon, > > On Fri, Sep 22, 2017 at 05:05:46PM +0200, Simon Marchi wrote: >> In gdbserver, target descriptions need to be initialized by calling >> init_target_desc. Because i386_create_target_description is shared >> with >> GDB, it doesn't do that, the callers must take care of it. These two >> platforms currently don't. >> >> I am not able to build them, so I couldn't test. >> >> gdb/gdbserver/ChangeLog: >> >> * lynx-i386-low.c (lynx_i386_arch_setup): Call init_target_desc. >> * nto-x86-low.c (nto_x86_arch_setup): Likewise. > > For LynxOS, go right ahead. I haven't been able to build GDBserver > on LynxOS ever since we switched to C++, as there is no satisfactory > C++ compiler on this platform that I could find or build. I'm hoping > this will change sometime, but in the meantime, best effort is the > best we can do... In this case, it looks quite reasonable. > > Thanks for doing that. Thanks, I'll push the patch as-is then. Simon