From: Carl Love via Gdb-patches <gdb-patches@sourceware.org>
To: will schmidt <will_schmidt@vnet.ibm.com>,
Pedro Alves <pedro@palves.net>,
Kevin Buettner <kevinb@redhat.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH V5] PowerPC: fix for gdb.base/eh_return.exp
Date: Wed, 08 Jun 2022 08:33:46 -0700 [thread overview]
Message-ID: <356aac133a99cf293d7f4673412224d29b4a53be.camel@us.ibm.com> (raw)
In-Reply-To: <6d82b4b8f30815f5dd98c001a8fe25632eb14a5a.camel@vnet.ibm.com>
Will, Pedro, Kevin, GDB maintainers:
I have made the additional fixes to the comments and the setting of the
clang options as mentioned by Will in version 4. I do not have an
environment where gdb can be built with clang. But I did check that
the clang options are properly passed to the compile command.
Unfortunately, extensive testing of gdb built with XLC and clang are
beyond the scope of this patch as I do not have access to such systems.
Per the comments from Kevin, the patch was updated to check for the gcc
and xlc compilers on PowerPC. The patch was also tested and verified
on AIX which uses the gcc compiler to build gdb. The attempt to build
gdb using the xlc compiler fails due to unrelated compiler errors. The
xlc options to disable the Traceback Table was verified but that was
it.
I have updated the patch per the comments from Will. The new version
of the patch uses a PowerPC specific gcc option to suppress the
generation of the Traceback Table information. The Traceback
information for this function is contained in the .long statements
following the last instruction in the function. The Traceback table
consists of a series of bit fields. The assembler tries to interpret
the Traceback Table as instructions. If the bits in the Traceback
Table happen to match a known instruction, the assembler will print a
bogus instruction, otherwise the assembler just prints the bits using
the .long statement. Unfortunately, the disassembler does not know how
to locate the Traceback Table information at the end of a function.
With this patch, the Traceback Table is disabled, so the last
instruction of the function is accurately found. Previously, the break
point was set at the last .long statement which gdb will never reach.
The test now passes as gdb successfully executes to the identified last
instruction.
Note, the use of the gcc mtraceback option is not valid on other
architectures.
I have tested the patch on Linux Power 10 with gcc, AIX with the gcc
and Intel with gcc.
Please let me know if this patch is acceptable. Thanks for the input
and help with the patch.
Carl Love
------------------------------------------------------------------
next prev parent reply other threads:[~2022-06-08 15:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 20:07 [PATCH] " Carl Love via Gdb-patches
2022-05-06 18:08 ` Kevin Buettner via Gdb-patches
2022-05-06 21:16 ` Pedro Alves
2022-05-06 22:45 ` will schmidt via Gdb-patches
2022-05-09 19:17 ` [PATCH V2] " Carl Love via Gdb-patches
2022-05-09 20:57 ` will schmidt via Gdb-patches
2022-05-10 11:43 ` Pedro Alves
2022-05-11 21:52 ` Carl Love via Gdb-patches
2022-05-11 21:52 ` [PATCH V3] " Carl Love via Gdb-patches
2022-05-11 22:48 ` Kevin Buettner via Gdb-patches
2022-05-12 16:00 ` Carl Love via Gdb-patches
2022-06-02 16:52 ` Carl Love via Gdb-patches
2022-06-08 18:32 ` Pedro Alves
2022-06-08 18:51 ` Carl Love via Gdb-patches
2022-06-09 15:24 ` Carl Love via Gdb-patches
2022-06-02 17:00 ` [PATCH V4] " Carl Love via Gdb-patches
2022-06-07 17:54 ` will schmidt via Gdb-patches
2022-06-08 15:33 ` Carl Love via Gdb-patches [this message]
2022-06-08 15:36 ` [PATCH V5] " Carl Love via Gdb-patches
2022-06-08 16:29 ` will schmidt via Gdb-patches
2022-07-13 17:07 ` [Ping] " Carl Love via Gdb-patches
2022-07-15 13:41 ` Ulrich Weigand via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=356aac133a99cf293d7f4673412224d29b4a53be.camel@us.ibm.com \
--to=gdb-patches@sourceware.org \
--cc=cel@us.ibm.com \
--cc=kevinb@redhat.com \
--cc=pedro@palves.net \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox