From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3454 invoked by alias); 11 Oct 2018 09:23:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3444 invoked by uid 89); 11 Oct 2018 09:23:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=(unknown), BuildBot X-HELO: EUR03-VE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr50083.outbound.protection.outlook.com (HELO EUR03-VE1-obe.outbound.protection.outlook.com) (40.107.5.83) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Oct 2018 09:23:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IsRR0ei3FkzjxihbQT5bAq/pzJtxd0wH3V/2pzc8EVE=; b=Xj5qjkor4iScEtR7bqcAqlxplem+vWHpjTq4bVwEMUzJP24xA0QIoYByy2qZC55A+Nppy/pOCND7cgQojm7IiYEqCbbYneccadqG2aBQjetkCkA40dwwIxlgDA4uTLYLt8JDRY/2hv+f0oPTpQtmtNvXCXV8ylNTmO3AQa++M9A= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.226.148) by DB6PR0802MB2567.eurprd08.prod.outlook.com (10.172.252.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.21; Thu, 11 Oct 2018 09:23:44 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::748a:5f72:2321:bc11]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::748a:5f72:2321:bc11%6]) with mapi id 15.20.1228.020; Thu, 11 Oct 2018 09:23:44 +0000 From: Alan Hayward To: Sergio Durigan Junior CC: Ramana Radhakrishnan , Simon Marchi , GDB Patches , Simon Marchi , nd , Pedro Alves Subject: Re: Status of the AArch* builders Date: Thu, 11 Oct 2018 09:23:00 -0000 Message-ID: <355AA6DE-FAB1-425B-8CE2-6E1508E57F88@arm.com> References: <20180606151629.36602-1-alan.hayward@arm.com> <20180606151629.36602-3-alan.hayward@arm.com> <9FBBFBF2-9363-49AA-8BC3-20E4E0AFBFED@arm.com> <5862fa9c22cc48d86256686e74d60f20@polymtl.ca> <82743c0795488492486076685b9f8828@polymtl.ca> <93f7cb8434f463508b3fc3cfbcd29ef0@polymtl.ca> <877en43qx1.fsf@redhat.com> <644470E6-AEB8-4F84-890C-7496EC8BB419@arm.com> <8736xr4ukx.fsf@redhat.com> <6b1500d9-bc31-aa09-586f-d451b910d880@foss.arm.com> <7BC78EF8-06BE-439B-835B-0F0847BF785F@arm.com> <877ejf50qo.fsf_-_@redhat.com> <87a7o7ot6r.fsf@redhat.com> In-Reply-To: <87a7o7ot6r.fsf@redhat.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) Content-Type: text/plain; charset="utf-8" Content-ID: <87F5A98AD6CBB047A82E90430F9E4B38@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00273.txt.bz2 DQoNCj4gT24gMjQgU2VwIDIwMTgsIGF0IDE1OjM5LCBTZXJnaW8gRHVyaWdh biBKdW5pb3IgPHNlcmdpb2RqQHJlZGhhdC5jb20+IHdyb3RlOg0KPiANCj4g T24gTW9uZGF5LCBTZXB0ZW1iZXIgMjQgMjAxOCwgQWxhbiBIYXl3YXJkIHdy b3RlOg0KPiANCj4+PiBPbiAyMCBTZXAgMjAxOCwgYXQgMjI6MTUsIFNlcmdp byBEdXJpZ2FuIEp1bmlvciA8c2VyZ2lvZGpAcmVkaGF0LmNvbT4gd3JvdGU6 DQo+Pj4gSGkgZ3V5cywNCj4+PiANCj4+PiBKdXN0IGEgcGluZyB0byBzZWUg aWYgeW91IGhhdmUgcHJvZ3Jlc3NlZCBvbiB0aGlzLiAgSSd2ZSBsZWZ0IHRo ZSBBQXJjaCoNCj4+PiBidWlsZGVycyB0aGVyZSwgYW5kIG5vdyB0aGV5J3Jl ICpyZWFsbHkqIGJlaGluZCAobW9yZSB0aGFuIDEwMDAgYnVpbGRzDQo+Pj4g aW4gdGhlIHF1ZXVlKSwgYW5kIGF0IGxlYXN0IG9uZSBvZiB0aGUgYnVpbGRz bGF2ZXMgaXMgb2ZmbGluZS4NCj4+PiANCj4+PiBJIHdpbGwgdGVtcG9yYXJp bHkgcmVtb3ZlIHRoZSBidWlsZGVycyBub3csIGJ1dCBpdCB3b3VsZCBiZSBy ZWFsbHkgbmljZQ0KPj4+IHRvIGtlZXAgaGF2aW5nIEFBcmNoKiBidWlsZGVy cyBpbiBvdXIgQnVpbGRCb3QuDQo+Pj4gDQo+Pj4gVGhhbmtzIGEgbG90LA0K Pj4gDQo+PiANCj4+IFJhbWFuYSBoYXMgZ290IHNvbWUgYWFyY2g2NCBtYWNo aW5lcyB1cCBvbiBwYWNrZXQubmV0IGZvciB1c2UgaW4gYnVpbGRib3QgaW5z dGVhZA0KPj4gb2YgdGhlIGV4aXN0aW5nIG1hY2hpbmVzLiBJIHRoaW5rIGEg ZmV3IHRoaW5ncyBqdXN0IG5lZWQgZmluYWxpc2luZyBiZWZvcmUgdGhleSBj YW4NCj4+IGJlIGhhbmRlZCBvdmVyLg0KPiANCj4gVGhhdCdzIGdyZWF0IG5l d3MuICBUaGFua3MgZm9yIGRvaW5nIHRoYXQuDQo+IA0KPj4gT25jZSB0aGF0 4oCZcyBkb25lIEkgY2FuIGdldCBidWlsZGJvdCBzZXQgdXAgb24gdGhlbS4g QXJlIHRoZXJlIHNvbWUgc2ltcGxlIGluc3RydWN0aW9ucw0KPj4gZm9yIGdl dHRpbmcgdGhpcyBnb2luZz8NCj4gDQo+IFRoZXJlIGFyZSBpbnN0cnVjdGlv bnMgb24gb3VyIHdpa2k6DQo+IA0KPiAgaHR0cHM6Ly9zb3VyY2V3YXJlLm9y Zy9nZGIvd2lraS9CdWlsZEJvdCNIb3dfdG9fYWRkX3lvdXJfYnVpbGRzbGF2 ZQ0KPiANCj4gQnV0IHBsZWFzZSBkbyBsZXQgbWUga25vdyBpZiB5b3UgbmVl ZCBhbnkgaGVscC4gIEkgY2FuIHRha2UgY2FyZSBvZiB0aGUNCj4gY29uZmln dXJhdGlvbiBvbiBteSBzaWRlLCBzbyB5b3UgZG9uJ3QgaGF2ZSB0byBzdWJt aXQgYSBwYXRjaCBmb3IgdGhlDQo+IG1hc3Rlci5jZmcgZmlsZSAoYWx0aG91 Z2ggeW91IGNhbiBpZiB5b3Ugd2FudCkuDQo+IA0KDQpUaGUgbWFjaGluZSBp cyBub3cgcmVhZHkgZm9yIGJ1aWxkYm90IQ0KDQpBYXJjaDY0LCBVYnVudHUg MTYuMDQuNSBMVFMsIDk2IGNvcmVzDQoNCknigJl2ZSBzZXR1cCBidWlsZGJv dC1zbGF2ZS0wLjguMTQgaW4gYSB2aXJ0dWFsZW52Lw0KKE9kZGx5LCBJIGhh ZCB0byBpbnN0YWxsIHR3aXN0ZWQ9PTE2LjQuMSwgYXMgYW55dGhpbmcgbmV3 ZXIgdGhhbiB0aGF0IGNhdXNlZCBhIGhhbmcpLg0KDQpJ4oCZdmUgbWFudWFs bHkgY2hlY2tlZCB5b3UgY2FuIGJ1aWxkIGdkYiBhbmQgcnVuIHRoZSB0ZXN0 c3VpdGUuDQoNCk15IHJlY2VudCBleHBlcmltZW50cyB3aXRoIHRoZSB0ZXN0 c3VpdGUgb24gQWFyY2g2NCBzaG93IGFsbCB0aGUgdGhyZWFkZWQgdGVzdHMN CmFyZSBxdWl0ZSByYWN5IG9uIGEgZnVsbHkgbG9hZGVkIHVidW50dSwgd2hl cmVhcyBvbiByZWRoYXQvc3VzZSB0aGV5IGFyZSBmYWlybHkNCnN0YWJsZS4g SeKAmW0gc3RpbGwgbG9va2luZyBpbnRvIHdoeSB0aGlzIGlzLiBCdXQsIGlu IHRoZSBzaG9ydC10ZXJtIG1heWJlIHdlIHNob3VsZA0KcmVzdHJpY3QgdGhl IG51bWJlciBvZiBqb2JzIHRvIDMyIChvciBtYXliZSBldmVuIGZld2VyPykN Cg0KU2VyZ2lvLCBjb3VsZCB5b3UgcGxlYXNlIGFkZCB0aGUgcmVsZXZhbnQg c2VydmVyIGNvbmZpZy4NCg0KDQpUaGFua3MsDQpBbGFuLg== >From gdb-patches-return-151556-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Oct 11 11:33:55 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 119441 invoked by alias); 11 Oct 2018 11:33:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 119430 invoked by uid 89); 11 Oct 2018 11:33:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=Commercial, Managing, Directors, H*f:sk:2018092 X-HELO: mga17.intel.com Received: from mga17.intel.com (HELO mga17.intel.com) (192.55.52.151) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Oct 2018 11:33:53 +0000 Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Oct 2018 04:33:51 -0700 Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga004.jf.intel.com with ESMTP; 11 Oct 2018 04:33:47 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.213]) by IRSMSX151.ger.corp.intel.com ([169.254.4.71]) with mapi id 14.03.0319.002; Thu, 11 Oct 2018 12:33:30 +0100 From: "Metzger, Markus T" To: Pierre Marsais , "gdb-patches@sourceware.org" Subject: RE: [PATCH v4 1/3] Add support for recording xsave x86 instruction Date: Thu, 11 Oct 2018 11:33:00 -0000 Message-ID: References: <20180921003827.1525-1-pierre.marsais@lse.epita.fr> <20181006001539.32414-1-pierre.marsais@lse.epita.fr> In-Reply-To: <20181006001539.32414-1-pierre.marsais@lse.epita.fr> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00274.txt.bz2 Content-length: 2764 Hello Pierre, > + if (rfbm & ~X86_XSTATE_ALL_MASK) { > + printf_unfiltered (_("Process record does not support XSAV= E " > + "instruction with RFBM=3D%" PRIx64 ".= \n"), > + rfbm); The indentation looks a bit off. > + opcode =3D (opcode << 8) | ir.modrm; > + goto no_support; > + } > + > + uint64_t tmpu64; > + if (i386_record_lea_modrm_addr (&ir, &tmpu64)) > + return -1; > + > + uint64_t legacy_size =3D 160; /* x87 xsave size */ > + if (rfbm & X86_XSTATE_SSE) { > + if (ir.regmap[X86_RECORD_R8_REGNUM]) > + legacy_size =3D 416; /* 64-bit sse xsave size */ > + else > + legacy_size =3D 288; /* 32-bit sse xsave size */ > + } > + if (record_full_arch_list_add_mem (tmpu64, legacy_size)) > + return -1; > + > + uint64_t size =3D X86_XSTATE_SIZE (rfbm) - 512; > + if (record_full_arch_list_add_mem (tmpu64 + 512, size)) > + return -1; This stores the full xsave area header. XSAVE only writes the first 8 byte= s. Also it turns out the macros are not correct, either. Jan Beulich sent a patch to fix XSAVE handling: https://sourceware.org/ml/gdb-patches/2018-10/msg00261.html We'd need to do a similar analysis here. > +uint32_t get_xsave_buffer_size (void) { Please use the GNU coding style also in tests. > +# This test tests some i386 general instructions for reverse execution. > +# > + > +if {![supports_reverse] || ![supports_process_record]} { > + return > +} You'd typically log them as unsupported. Not sure if you need to check supports_reverse, as well. > +gdb_test "break $end_xsave_test" \ > + "Breakpoint $decimal at .* line $end_xsave_test\." \ > + "set breakpoint at end of xsave_test" > + > +set test "continue to end of xsave_test" > +gdb_test_multiple "continue" $test { > + -re " end xsave_test .*\r\n$gdb_prompt $" { > + pass $test > + } > + -re " Illegal instruction.*\r\n$gdb_prompt $" { > + untested i386-xsave-reverse > + return -1 > + } > +} Wouldn't it be easier to check for XSAVE support separately? The tests don't really cover that record is not saving too much. I think both tests would pass if we recorded the entire page. Regards, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928