From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13694 invoked by alias); 8 Jul 2018 16:46:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13670 invoked by uid 89); 8 Jul 2018 16:46:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 08 Jul 2018 16:45:59 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 8A8AB1E059; Sun, 8 Jul 2018 12:45:57 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1531068357; bh=HIrrIVAWfo5LRXya9fjeXNSERVRbbNNfJ09AVwdAAlE=; h=Subject:To:References:From:Date:In-Reply-To:From; b=uS08P2BwVfnz2FcP6LNAQo7tMXxcd/IzTBuqQcdjdxwKHS7D0I3Doc87CwrlBJhvZ g6aVyG8tcQSzs6Biajc9j/0lMDAfFc4IMzExeiSRZBnDiEeh7NcU+CK/5MjCp91/Xx mF0UV2B+D+bi370I9It61UAtfdWNsVjqNtgMOn1o= Subject: Re: [RFA 11/42] Move processing_gcc to stabsread To: Tom Tromey , gdb-patches@sourceware.org References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-12-tom@tromey.com> From: Simon Marchi Message-ID: <354ad4b7-836b-8d13-6af2-111047624416@simark.ca> Date: Sun, 08 Jul 2018 16:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180523045851.11660-12-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00194.txt.bz2 On 2018-05-23 12:58 AM, Tom Tromey wrote: > processing_gcc is also only used by stabsread -- it is set by the > DWARF reader, but this turns out not to be needed. So, this patch > moves processing_gcc and removes the assignment from the DWARF reader. Any idea if the assignment of processing_gcc_compilation in go32-nat.c is useful? In looks very strange to me to set that in nat code rather than in symbol-reading code... Either way, it LGTM, I am fine if you leave it there to stay on the safe side, since I suppose you couldn't test that change easily. Simon