From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1279 invoked by alias); 7 May 2011 13:50:05 -0000 Received: (qmail 1240 invoked by uid 22791); 7 May 2011 13:50:03 -0000 X-SWARE-Spam-Status: No, hits=0.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_BL_SPAMCOP_NET,RCVD_IN_DNSWL_NONE,RFC_ABUSE_POST,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from nm11-vm1.bullet.mail.sp2.yahoo.com (HELO nm11-vm1.bullet.mail.sp2.yahoo.com) (98.139.91.241) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Sat, 07 May 2011 13:49:48 +0000 Received: from [98.139.91.69] by nm11.bullet.mail.sp2.yahoo.com with NNFMP; 07 May 2011 13:49:47 -0000 Received: from [98.139.91.4] by tm9.bullet.mail.sp2.yahoo.com with NNFMP; 07 May 2011 13:49:47 -0000 Received: from [127.0.0.1] by omp1004.mail.sp2.yahoo.com with NNFMP; 07 May 2011 13:49:47 -0000 Received: (qmail 95511 invoked by uid 60001); 7 May 2011 13:49:47 -0000 Message-ID: <35206.88376.qm@web112501.mail.gq1.yahoo.com> Received: from [122.167.230.134] by web112501.mail.gq1.yahoo.com via HTTP; Sat, 07 May 2011 06:49:46 PDT References: <341905.10459.qm@web112513.mail.gq1.yahoo.com> <208397.95006.qm@web112517.mail.gq1.yahoo.com> <4DA27006.1080607@codesourcery.com> <763549.92092.qm@web112506.mail.gq1.yahoo.com> <335149.24692.qm@web112515.mail.gq1.yahoo.com> <592215.58786.qm@web112508.mail.gq1.yahoo.com> <172713.29831.qm@web112503.mail.gq1.yahoo.com> Date: Sat, 07 May 2011 13:50:00 -0000 From: paawan oza Subject: Re: [PATCH] arm reversible : To: =?iso-8859-1?Q?Petr_Hluz=EDn?= Cc: gdb@sourceware.org, gdb-patches@sourceware.org In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00209.txt.bz2 Hi Petr and Tom, I have implemented most of your comments.. The comments which I could not put it in are below with explanation. 1) ARM_RECORD_ARCH_LIST_ADD_REG is used only at 2 places, but probably I wa= nted=20 to=20 give clear interface where it just takes only one argument, register number. I should have done it for memory, but have not done yet. sure, it hides local variable usage and it doesnt look good, but my intensi= on=20 was to give clear interface=20 to function process_record modifiers. I am still thinking over it. 2) > + uint32_t opcode; /* insn opcode. */ I understand that above is one of the fields of arm_insn_record, but why I = am=20 usiong it as global field, because the decoding bits by this field kind of global and common to most o= f the=20 insns. probably I would like to just extract it once and use anywhere, but=20 unfortunately I have extracted in every function and seems local, will work on that though. 3)=20 + start_address =3D start_address + 4 - start_address =3D start_address - 4 in two of the four cases. If you have a look at the code, start_address initialization is the key fac= tor=20 for addressing mode. not how start_address later gets incremented.. so even in decrement mode,=20 increment is necessary but initialization is different. 4) In arm_handle_coproc_data_proc_insn(): > + tdep->arm_swi_record(reg_cache); When this line is executed this function still returns -1 (i.e. failure). I guess the two if's are intended to return success then. oza: the coprocessor insns are not implemented and syscall record too. so i= n=20 both cases we return -1. 5) The return value is never tested. What is its meaning? The parsed args seem to be stored as a side-effect. Where are they stored? (Answers should go to comments.) (Since this is an indirect call, the documentation should be more verbose than usual cases.) Oza: swi basically equivalent to sysenter an int80 insn on x86, so systemca= ll is=20 implemented that way. I am going to work on that implementation in phase 3. phase 2 does not support it. 6)=20 Tom: I still need to take care of endianess issue, which I will in the comi= ng=20 stage. Note: updated patch will be mailed in the next mail. Regards, OZa.