From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic308-18.consmr.mail.ir2.yahoo.com (sonic308-18.consmr.mail.ir2.yahoo.com [77.238.178.146]) by sourceware.org (Postfix) with ESMTPS id 35CFC385BF81 for ; Wed, 8 Apr 2020 22:17:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 35CFC385BF81 X-YMail-OSG: MJPrPsEVM1le1mWKtba6_WCwcrQOzHNXQP4SRTGdScr1bauWJW_Z7GEA45E.EoC wodMqnNGhYR.XRRIhnmulTcmehVI.NENiWCZkD8IDa2Sn8aIYI8m31MVhiX8iS8ytHRpT0lYW14N rKQh32Kq4A.wxqLgPir0Ko2KKxV4Uw0u1PRGSevNUr21HdrfpjRMWCq5FIt2kPVnPM_gcrSQ_9gY 3Ltxo9T3OELNmieCqZHIzUfImEjAnh7CMAU.SZoepP_55nbJHHQ93MRl7NOEydtege7e4OjCdHDN q_352Hj0IDUh8lp6kdrykNBFpvA2O7_kQU11_ymdH0KrV55dWxS3dwWx2bpmEabXMMVrJq7izI1. yjU9iB7M7BDZPg4RFJoXWDDCkLClj2Zjg9lVjRZ4aXkkws43XW.Eoam7oBw_Vw4xr3OBl_9FLQQa NgyGogWceWbtoVOR0N.XyL9BIZYg7R8Sk_6.eiQzIYjWBv1xRTVUV3WS0RUBWNMj49Cgbsy8iGAO wEnDeTtM6zwxlUnTjPdxC5FhaIwmTUOiSmCGC09Vc2f_Zz85V_IDIYsDDzYn1r.8_7iqCqtB1sef gDMOaNSNVgyj8zguWtiv.qVC2m8tKAvXUm46HTDepbA3oe1fUqhLi1uTbylJFt4BEBOZgJnM.jSE PgBjF2nP0myKxZPInL_laUM9K4AIcdXKqRwDQylUCghdw3fFW.a_dh4YprESd42lVxosf19Klasc ZlY23T5zj.gfzT3S6fQqYPF1gvNm4_VqpPhsyQCgx2kXA3qyvgLWkAWjLIvKOSq3UrESQiGyn63P sookGlyo6LJNjVIo_TBb1QRLpx0HOhQvkwnwO4QutPYP2Q2V.gestdbUe8gZYNtjNvkgL1ZVIJU5 xJRy7z4rRmuZ1eOzLsgu8AK7pQ4tsziUvqFArMfXL3rJSs6OnlcWLTgUppDwollECQgv.mL0av8z 9PeAhul_KyqToTT7ZRhatsZzbFMKYt184LnrWs4K.vPSK7W2k7_NBlHuROH_g.YyIe12CCP9687s 7WwZ19qQcaDDmOMZfW2u6xbuVgwTETjrwFJwghLApY_Eb2zisDOk0id8lL835txOhLpZ5olsZutv V.RJmBigLif4EsClbbQye_Y_0dHdXFj9nn8mM6AvcZrURglW9SJ3zecFr4ply0br7WBLKHcGCpox IS262TR9.M3TlAMx1Yovx9bFRHYOob2bkdF_zEEnTgbIqRuMwkQfWydui97AAHT0Afa3T1AXvlx0 2GZY_kfoXemkc0FT67TdcOOXaOhjHW_pHgTg9uoQIJYuVcnEzHtvHMXCP8exYIE1hQRRWwS.cyh6 Z8iobmg_wJxA- Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.ir2.yahoo.com with HTTP; Wed, 8 Apr 2020 22:17:21 +0000 Date: Wed, 8 Apr 2020 22:17:17 +0000 (UTC) From: Hannes Domani To: Gdb-patches Message-ID: <352012716.4805895.1586384237188@mail.yahoo.com> In-Reply-To: <87pnchogza.fsf@tromey.com> References: <20200313190855.28662-1-tromey@adacore.com> <87pnchogza.fsf@tromey.com> Subject: Re: [PATCH v3 00/29] Windows code sharing + bug fix MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.15620 YMailNorrin Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:71.0) Gecko/20100101 Firefox/71.0 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Apr 2020 22:17:25 -0000 Am Mittwoch, 8. April 2020, 22:33:18 MESZ hat Tom Tromey Folgendes geschrieben: > >>>>> "Tom" =3D=3D Tom Tromey writes: > > Tom> This is v3 of the series to share a lot of the Windows code between > Tom> gdb and gdbserver.=C2=A0 It also fixes a bug that a customer reporte= d; in > Tom> fact this fix was the origin of this series.=C2=A0 See patch #11 for > Tom> details on the bug. > > Tom> I think this addresses all the review comments.=C2=A0 It's somewhat = hard to > Tom> be sure since they were done in gerrit, and extracting comments from > Tom> that is a pain.=C2=A0 Also I think I had sent v2 before I updated my > Tom> scripts to preserve the gerrit change ID, so it is in gerrit twice. > Tom> Anyway, the reviews happened around Nov 2019, so you can find some i= n > Tom> the mailing list archives. > > Tom> I tested this largely by hand.=C2=A0 I also ran it through the AdaCo= re test > Tom> suite, where it did ok.=C2=A0 (There were some issues, but I think t= hey are > Tom> largely unrelated; some things like gdb printing paths that the test > Tom> suite didn't really recognize.) > > Tom> I've also updated this to handle the WOW64 stuff, but only in a > Tom> minimal way -- I didn't try to make this work in gdbserver. > > I'm checking this in now. > Let me know if there are any issues. I seems I kinda missed to actually use Wow64SuspendThread when I implemente= d the WOW64 stuff. I never noticed any problems, and SuspendThread actually seems to work fine for WOW64 processes, but that might just be luck (or depend on the Windows version). You moved the SuspendThread stuff now into nat/windows-nat.c, so that complicates the situation a bit (but it's also the reason I noticed). Maybe I should just try to implement the WOW64 stuff for gdbserver as well,= and then try to move more shared stuff into nat/windows-nat.c? Hannes