From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23050 invoked by alias); 16 Sep 2014 14:00:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23025 invoked by uid 89); 16 Sep 2014 14:00:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: na01-bn1-obe.outbound.protection.outlook.com Received: from mail-bn1on0138.outbound.protection.outlook.com (HELO na01-bn1-obe.outbound.protection.outlook.com) (157.56.110.138) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 16 Sep 2014 14:00:00 +0000 Received: from BY2PR03MB175.namprd03.prod.outlook.com (10.242.36.148) by BY2PR03MB176.namprd03.prod.outlook.com (10.242.36.153) with Microsoft SMTP Server (TLS) id 15.0.1024.12; Tue, 16 Sep 2014 13:59:56 +0000 Received: from BY2PR03MB175.namprd03.prod.outlook.com ([169.254.5.168]) by BY2PR03MB175.namprd03.prod.outlook.com ([169.254.5.25]) with mapi id 15.00.1024.012; Tue, 16 Sep 2014 13:59:55 +0000 From: "catalin.udma@freescale.com" To: Pedro Alves , Marcus Shawcroft CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH v2] aarch64/gdbserver: fix floating point registers display Date: Tue, 16 Sep 2014 14:00:00 -0000 Message-ID: <351e10391d8241209dd7815d74482a81@BY2PR03MB175.namprd03.prod.outlook.com> References: <1408690493-5243-1-git-send-email-catalin.udma@freescale.com> <5405D022.7040101@redhat.com> In-Reply-To: <5405D022.7040101@redhat.com> x-ms-exchange-transport-fromentityheader: Hosted x-microsoft-antispam: BCL:0;PCL:0;RULEID:;UriScan:; x-forefront-prvs: 03361FCC43 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(164054003)(377454003)(51704005)(377424004)(189002)(479174003)(24454002)(199003)(31966008)(87936001)(21056001)(54356999)(108616004)(99286002)(76576001)(77096002)(106116001)(19580395003)(74316001)(20776003)(101416001)(76176999)(66066001)(97736003)(83072002)(76482001)(99396002)(90102001)(33646002)(106356001)(92566001)(64706001)(95666004)(50986999)(85852003)(2656002)(4396001)(105586002)(19580405001)(86362001)(77982003)(79102003)(107046002)(85306004)(83322001)(74502003)(81542003)(81342003)(46102003)(74662003)(80022003)(24736002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR03MB176;H:BY2PR03MB175.namprd03.prod.outlook.com;FPR:;MLV:sfv;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-SW-Source: 2014-09/txt/msg00538.txt.bz2 DQo+IE9uIDA5LzAyLzIwMTQgMDI6NDcgUE0sIE1hcmN1cyBTaGF3Y3JvZnQg d3JvdGU6DQo+ID4+IGdkYi9nZGJzZXJ2ZXIvDQo+ID4+IDIwMTQtMDgtMTIg IENhdGFsaW4gVWRtYSAgPGNhdGFsaW4udWRtYUBmcmVlc2NhbGUuY29tPg0K PiA+Pg0KPiA+PiAgICAgICAgICogbGludXgtYWFyY2g2NC1sb3cuYyAoQUFS Q0g2NF9GUFNSX1JFR05PKTogTmV3IGRlZmluZS4NCj4gPj4gICAgICAgICAo QUFSQ0g2NF9GUENSX1JFR05PKTogTGlrZXdpc2UuDQo+ID4+ICAgICAgICAg KEFBUkNINjRfTlVNX1JFR1MpOiBVcGRhdGUgdG8gaW5jbHVkZSBmcHNyL2Zw Y3IgcmVnaXN0ZXJzLg0KPiA+PiAgICAgICAgIChhYXJjaDY0X2ZpbGxfZnBy ZWdzZXQpOiBBZGQgbWlzc2luZyBmcHNyL2ZwY3IgcmVnaXN0ZXJzLg0KPiA+ PiAgICAgICAgIChhYXJjaDY0X3N0b3JlX2ZwcmVnc2V0KTogTGlrZXdpc2Uu DQo+ID4NCj4gPiBUaGlzIGxvb2tzIGdvb2QgdG8gbWUuLi4uDQo+ID4gLi4g aG93ZXZlci4uLiBJIGNhbid0IGFwcHJvdmUgeW91ciBwYXRjaCBoZXJlIGlu IGdkYiBsYW5kLg0KPiANCj4gPHJ1YmJlcnN0YW1wPiBPSyA8L3J1YmJlcnN0 YW1wPg0KPiANCj4gUGxlYXNlIHB1c2guDQo+IA0KPiBUaGFua3MsDQo+IFBl ZHJvIEFsdmVzDQpbQ2F0YWxpbiBVZG1hXSBBcmUgdGhlcmUgYW55IHVwZGF0 ZXMgd2l0aCB0aGlzIHBhdGNoPw0KSSBzZWUgaXQncyBub3QgcHVzaGVkIG9u IG1hc3Rlci4NClRoYW5rcywNCkNhdGFsaW4NCg== >From gdb-patches-return-115948-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Sep 16 14:26:05 2014 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 9630 invoked by alias); 16 Sep 2014 14:26:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 9618 invoked by uid 89); 16 Sep 2014 14:26:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 16 Sep 2014 14:26:01 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8GEPrUF028058 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 16 Sep 2014 10:25:54 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8GEPpvu002064; Tue, 16 Sep 2014 10:25:52 -0400 Message-ID: <5418486F.7030506@redhat.com> Date: Tue, 16 Sep 2014 14:26:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 To: Pierre Muller , gdb-patches@sourceware.org Subject: Re: [pushed] Add test to make sure GDB knows which "kind" of watchpoint the target has References: <1410873512-762-1-git-send-email-palves@redhat.com> <000601cfd1b1$718bd600$54a38200$@muller@ics-cnrs.unistra.fr> <54183ACC.7060001@redhat.com> In-Reply-To: <54183ACC.7060001@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-09/txt/msg00539.txt.bz2 Content-length: 2092 On 09/16/2014 02:27 PM, Pedro Alves wrote: > On 09/16/2014 02:23 PM, Pierre Muller wrote: >>> + gdb_assert {$sw_watch_pc == $sw_watch_pc} "hw watchpoint stops at >>> right instruction" >> Shouldn't this be >> {$sw_watch_pc == $hw_watch_pc}? > > Argh... Right you are. > > Many thanks, > Pedro Alves > I've pushed the obvious fix. Thanks again Pierre. --------- >From 635856f584de7af4b21bb72688c05cd6d9a0aec6 Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Tue, 16 Sep 2014 14:27:57 +0100 Subject: [PATCH] Fix watchpoint-stops-at-right-insn.exp Silly typo... gdb/testsuite/ 2014-09-16 Pedro Alves * gdb.base/watchpoint-stops-at-right-insn.exp (test): Compare software and hardware addresses, not software address against itself. --- gdb/testsuite/ChangeLog | 6 ++++++ gdb/testsuite/gdb.base/watchpoint-stops-at-right-insn.exp | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index c2588d3..c06ba4d 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,5 +1,11 @@ 2014-09-16 Pedro Alves + * gdb.base/watchpoint-stops-at-right-insn.exp (test): Compare + software and hardware addresses, not software address against + itself. + +2014-09-16 Pedro Alves + * gdb.base/watchpoint-stops-at-right-insn.c: New file. * gdb.base/watchpoint-stops-at-right-insn.exp: New file. diff --git a/gdb/testsuite/gdb.base/watchpoint-stops-at-right-insn.exp b/gdb/testsuite/gdb.base/watchpoint-stops-at-right-insn.exp index 9ad6080..6039c4c 100644 --- a/gdb/testsuite/gdb.base/watchpoint-stops-at-right-insn.exp +++ b/gdb/testsuite/gdb.base/watchpoint-stops-at-right-insn.exp @@ -168,7 +168,7 @@ proc test {always_inserted} { set hw_watch_pc [get_pc "get hw watchpoint PC"] - gdb_assert {$sw_watch_pc == $sw_watch_pc} "hw watchpoint stops at right instruction" + gdb_assert {$sw_watch_pc == $hw_watch_pc} "hw watchpoint stops at right instruction" } } -- 1.9.3