From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8OKWLHSzvV93eQAAWB0awg (envelope-from ) for ; Tue, 24 Nov 2020 20:29:24 -0500 Received: by simark.ca (Postfix, from userid 112) id B491D1F0AB; Tue, 24 Nov 2020 20:29:24 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=MAILING_LIST_MULTI,RDNS_NONE autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6B2CC1E58E for ; Tue, 24 Nov 2020 20:29:24 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 32A1039540BE; Wed, 25 Nov 2020 01:29:24 +0000 (GMT) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by sourceware.org (Postfix) with ESMTPS id DE01A39540BE for ; Wed, 25 Nov 2020 01:29:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DE01A39540BE Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wr1-f66.google.com with SMTP id g14so278041wrm.13 for ; Tue, 24 Nov 2020 17:29:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ThyDOcn2HLG8B6XZfgaHWvsGvZtgR3QJD94qG7GhKo0=; b=hVZ+VNmPfMfEAtXpS3qM2A+3LSuiu+WmPoGgYSbiUqUtNb+OYBCDn9l9vNQVfSoSiT qcIpJZJIIOZ3RjuFymfiQqVGTEOJuWpUwOqIBeT4CgpDkD1yK3ac6M/1re5oAgKFZbl8 8KmJMTQmTBHpOWkXogEy4FIpdaNjo2GkkOcSkv0pvAlXdYRwp3abSsmrpx+tug6BaLIm T2wxEsT/3GOx0KyWkU+8UxaI7WRuNEqyRIhzn2ieHLHh2kgtkP9C8NQLJDTlVBLh/Pts xyVlIFCnp1mWS5wTqxLxPpaN9qTYxzZCPR7xW0QPDsTFCJZe1HffPRqnAsV6vj1WJvHA ppJw== X-Gm-Message-State: AOAM5307+Dv4EIVSo9vEisrwd1Qo4DV9j0B0Rm1J/cvSn5Q1q/wGEekV G+9Du8QrC47E8IqfooUhdRVSv+fr47DYog== X-Google-Smtp-Source: ABdhPJwFaHLN3R9YHH7tDpStLx31vDFlR2oGCwcKOwf78voSczMIU4Ts+qhLAAp8kf68ncCBTNRx2g== X-Received: by 2002:a5d:414e:: with SMTP id c14mr1280760wrq.256.1606267760311; Tue, 24 Nov 2020 17:29:20 -0800 (PST) Received: from ?IPv6:2001:8a0:f91f:e900:1d90:d745:3c32:c159? ([2001:8a0:f91f:e900:1d90:d745:3c32:c159]) by smtp.gmail.com with ESMTPSA id y11sm1106892wmj.36.2020.11.24.17.29.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Nov 2020 17:29:19 -0800 (PST) Subject: Re: [PATCH 05/12] gdb: rename displaced_step_fixup to displaced_step_finish To: Simon Marchi , gdb-patches@sourceware.org References: <20201110214614.2842615-1-simon.marchi@efficios.com> <20201110214614.2842615-6-simon.marchi@efficios.com> From: Pedro Alves Message-ID: <34f2bad8-a187-6f42-709e-aaf4dde81f0a@palves.net> Date: Wed, 25 Nov 2020 01:29:18 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20201110214614.2842615-6-simon.marchi@efficios.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 11/10/20 9:46 PM, Simon Marchi via Gdb-patches wrote: > This is a preparatory patch to reduce a little bit the diff size of the > main patch later in this series. It renames the displaced_step_fixup > function in infrun.c to displaced_step_finish. > > The rationale is to better differentiate the low and high level > operations. > > We first have the low level operation of writing an instruction to a > displaced buffer, called "copy_insn". The mirror low level operation to > fix up the state after having executed the instruction is "fixup". The > high level operation of preparing a thread for a displaced step (which > includes doing the "copy_insn" and some more bookkeeping) is called > "prepare" (as in displaced_step_prepare). The mirror high level > operation to cleaning up after a displaced step (which includes doing > the "fixup" and some more bookkeeping) is currently also called "fixup" > (as in displaced_step_fixup), just like the low level operation. > > I think that choosing a different name for the low and high level > cleanup operation makes it clearer, hence "finish". > > gdb/ChangeLog: > > * infrun.c (displaced_step_fixup): Rename to... > (displaced_step_finish): ... this, update all callers. OK.