From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20627 invoked by alias); 14 Dec 2009 12:51:18 -0000 Received: (qmail 20616 invoked by uid 22791); 14 Dec 2009 12:51:17 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (212.99.106.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Dec 2009 12:51:13 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id E8D9529000C; Mon, 14 Dec 2009 13:51:10 +0100 (CET) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lmY3lHJVC2Td; Mon, 14 Dec 2009 13:51:10 +0100 (CET) Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mel.act-europe.fr (Postfix) with ESMTP id 438A329000A; Mon, 14 Dec 2009 13:51:10 +0100 (CET) Subject: Re: [RFA] Move buildid stuff from symfile.c to elfread.c Mime-Version: 1.0 (Apple Message framework v1077) Content-Type: text/plain; charset=us-ascii From: Tristan Gingold In-Reply-To: Date: Mon, 14 Dec 2009 12:51:00 -0000 Cc: gdb-patches ml Content-Transfer-Encoding: quoted-printable Message-Id: <34C67EA0-3DB2-4095-BBA8-C06E2D169191@adacore.com> References: <81FAA351-3C2E-4023-B373-5078D9D66A4A@adacore.com> To: tromey@redhat.com X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00182.txt.bz2 On Dec 11, 2009, at 8:20 PM, Tom Tromey wrote: >>>>>> "Tristan" =3D=3D Tristan Gingold writes: >=20 > Tristan> I have also added a new function, protocol_bfd_open to make > Tristan> common an idiom used 3 times. I haven't found a better name > Tristan> but suggrestions are very welcome. >=20 > Andreas' suggestion seems good to me. >=20 > Tristan> +/* If NAME is a remote name open the file using remote protocol= , otherwise > Tristan> + open it normaly. */ >=20 > Typo, should be "normally". >=20 > This is ok with the typo fix and the rename. Thanks, committed with the typo fix and the rename. Tristan.