From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sMPxCG6oUmgyNxMAWB0awg (envelope-from ) for ; Wed, 18 Jun 2025 07:52:14 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=HucJ0xKM; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2095E1E11C; Wed, 18 Jun 2025 07:52:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HTML_MESSAGE, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=unavailable autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B75A21E089 for ; Wed, 18 Jun 2025 07:52:13 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 41CB23857830 for ; Wed, 18 Jun 2025 11:52:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 41CB23857830 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=HucJ0xKM Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 61B3638252D1 for ; Wed, 18 Jun 2025 11:51:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 61B3638252D1 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 61B3638252D1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1750247491; cv=none; b=aIe6BvFDqFKotVnWPInzRLbCmy3vvUquSK1NfEa1+PvbwvLhC36M1rYt8oNYMm8ySGRAljoeWTSGRYky91Y2ES/1uOdU4z45lnDO0KpuCFR9N0zsRH1/LcFPh5kcPcuDT2SZwKkJHDdvmPJKzmdsWGJrCetvQdqpdp7RVVsq+gU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1750247491; c=relaxed/simple; bh=1NPgGw+47MBEF/9UuwX5RuFEUVrJjZeAWi81MqT0J2o=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=awDYeghIs+iz2UJqmYB08v59BtAJtCrCfX9BK/pG5NWLThKjDFTE7Iir0DPYm4JCbjqnw/uqU9kZYVzL4VNYJ9ZJracs6bbLay3IMFRfiEoGbWbf5uL9nihJ/a5/o5RIfarNr0Aymzbq4O6FcnT5vVOvwLQGahsEzNvNAmSRGQ8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 61B3638252D1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750247491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RsW0XtTOKp8XInAqgNXSvt10rNPmPPVwgqakqjjhT34=; b=HucJ0xKMCALg25AsEEHgd7Wl9jCFBfXyBPTQVpQ3DwIfqFy+HXN2evGVd3EjsnIwpzhTPw WsAx6NQlsVLiLMucPSftBDP8wrNhgHpfT2MvUgR6XzdNp6UGGFt0YHf+ojE//frq6xa9vq ztx4aMSss7gECTzfASXA8ut7nooIV3s= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-626-0evPajvkNWWFeVcRGGITXA-1; Wed, 18 Jun 2025 07:51:29 -0400 X-MC-Unique: 0evPajvkNWWFeVcRGGITXA-1 X-Mimecast-MFC-AGG-ID: 0evPajvkNWWFeVcRGGITXA_1750247489 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6fad1f7f175so12506416d6.1 for ; Wed, 18 Jun 2025 04:51:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750247489; x=1750852289; h=in-reply-to:from:content-language:references:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=RsW0XtTOKp8XInAqgNXSvt10rNPmPPVwgqakqjjhT34=; b=Q00UeB5E4cJ46vlQmexngXdu4+30aNiOQpGuq5EifSgkUnW6iPUuVoWJNkVeYVcND8 S1eJx1pGg66Mm5o5MJ78rSe+/B+g9qi46gW3BIeaGf6X3FhGzLEHDJnRvrje3BcoQXQN CEej49eRBMOE7IA0xlhEKubNU1kRCJQdrIzdlMMsE4eOyRseCZbkxxzLsdfljBU0upof 6AANVEEzWql3XQEAgL5HEYUPaIXgnHNMomr3ncBAfXTTAAZBwLrBRQMFrYZEQyVZEbwt 3lKoCGDP/b96Ohz2DYSrtAWrLYEt4tAKwA1lTRYlMM6UJZ56BeOdZIVV1sOKzQr6Wj43 bTOw== X-Forwarded-Encrypted: i=1; AJvYcCX3abG3dgT5CTtIkwiyhVeON0ZxBzqLa0OLOwXxF2BbmsmDMekuRajUlwUXOlj7pwAVkRV8MFhZlVfwSA==@sourceware.org X-Gm-Message-State: AOJu0YxoaCrsGGRSsEcZ0fKUZuGIm0QbNH4aWGhw/DJmK15vgTMQDAzm S6NUE60B4YnwItEDb6hv8FX+7fMsYd34w56kyRe2Erh1yMAxM3y9Hn6o4LpLX4AuD64KhTkjHQS 1OLpSWSrNbh9N1vDDoFfpWQxWvkI6SzSbhMeAN0nCJ81fO/y+Lm589p7etbpUxgo= X-Gm-Gg: ASbGncs7xNgSsoxncm5YLOlxyLEVR3uOxh6Kw6cVYK27jhnA4WnN+DnKVFisJ2dxQUZ sZoI3vnJUbai7fPk8+Ihdn//0x/v3jctp4+IvwglsaqHDh8ati4/4v1ALL6JGVvgZOorXLUYceK iQNTc4VbR7aPD+zOjDdTQkQV6cOZvgTqJPYLL96b0QwzrQIHeP8SHQtkreSwFzq3oVw739Sr3sW USQaZb53WHvWIE7R1iyisEvg2vLtAaloNcnqTAgGJ6JdVEfl2MkBk83dwh4kDeAxQEpm1pn2OLL f/6ZXCzcAV5oNYJuL2LwctvtzgnfcVRe2w== X-Received: by 2002:a05:6214:21a7:b0:6f8:c773:26e with SMTP id 6a1803df08f44-6fb68bb3e8amr31658996d6.18.1750247489261; Wed, 18 Jun 2025 04:51:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHJ6FwsFN+yCZThBu/M2TJlshL1P6pP6dBkq/UwcL+txcp4yXDQqx/eTYNT9hEc5Qu+vxNqag== X-Received: by 2002:a05:6214:21a7:b0:6f8:c773:26e with SMTP id 6a1803df08f44-6fb68bb3e8amr31658586d6.18.1750247488738; Wed, 18 Jun 2025 04:51:28 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:9a69::1000? ([2804:14d:8084:9a69::1000]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fb522b1397sm36759666d6.70.2025.06.18.04.51.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jun 2025 04:51:28 -0700 (PDT) Message-ID: <348dddac-02ff-4750-afb6-cf87ea9aded2@redhat.com> Date: Wed, 18 Jun 2025 08:51:25 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/6] gdb/progspace: add solib_ops pointer in program_space To: Simon Marchi , Simon Marchi , gdb-patches@sourceware.org References: <20250616193443.16703-1-simon.marchi@efficios.com> <20250616193443.16703-5-simon.marchi@efficios.com> <1085bd17-956a-449a-bb9d-eb89a90ac7fc@simark.ca> From: Guinevere Larsen In-Reply-To: <1085bd17-956a-449a-bb9d-eb89a90ac7fc@simark.ca> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: e83GT5zLabfOuxL2s0Pdf5T-1WZy4gIvyCditeYJ1Do_1750247489 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="------------QjrLlAr6A8KVNd9DhxMEjJpr" Content-Language: en-US X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This is a multi-part message in MIME format. --------------QjrLlAr6A8KVNd9DhxMEjJpr Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/17/25 5:33 PM, Simon Marchi wrote: >> Thanks for working on this series! I have one very minor nit in this patch, but with that fixes, you can feel free to add my review tag >> >> Reviewed-By: Guinevere Larsen >> >> Feel free to add it to patches 1-4 as well, as I looked over them and they all LGTM. I still don't feel qualified to offer it for patch 6, though. > Thank you! > > Given your review, I plan to push this series probably tomorrow. You > can start rebasing and adjusting your series on top, and then I can > hopefully review it this week (note that I'm off this Friday, so it > would have to be Thursday max). I'll rebase and try to get it ready to send to the list by tomorrow, but I'll also go on vacation starting friday and only return July 7th, so if that series gets approved before GDB 17 branches, I'll need someone to push it for me. -- Cheers, Guinevere Larsen She/Her/Hers --------------QjrLlAr6A8KVNd9DhxMEjJpr Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit
On 6/17/25 5:33 PM, Simon Marchi wrote:
Thanks for working on this series! I have one very minor nit in this patch, but with that fixes, you can feel free to add my review tag

Reviewed-By: Guinevere Larsen <guinevere@redhat.com>

Feel free to add it to patches 1-4 as well, as I looked over them and they all LGTM. I still don't feel qualified to offer it for patch 6, though.

Thank you!

Given your review, I plan to push this series probably tomorrow.  You
can start rebasing and adjusting your series on top, and then I can
hopefully review it this week (note that I'm off this Friday, so it
would have to be Thursday max).

I'll rebase and try to get it ready to send to the list by tomorrow, but I'll also go on vacation starting friday and only return July 7th, so if that series gets approved before GDB 17 branches, I'll need someone to push it for me.

-- 
Cheers,
Guinevere Larsen
She/Her/Hers
--------------QjrLlAr6A8KVNd9DhxMEjJpr--