From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Received: (qmail 19045 invoked from network); 19 Mar 2004 00:34:49 -0000 Received: from unknown (HELO mail-out3.apple.com) (17.254.13.22) by sources.redhat.com with SMTP; 19 Mar 2004 00:34:49 -0000 Received: from mailgate1.apple.com (a17-128-100-225.apple.com [17.128.100.225]) by mail-out3.apple.com (8.12.11/8.12.11) with ESMTP id i2J0YmFY029180 for ; Thu, 18 Mar 2004 16:34:48 -0800 (PST) Received: from relay1.apple.com (relay1.apple.com) by mailgate1.apple.com (Content Technologies SMTPRS 4.3.6) with ESMTP id ; Thu, 18 Mar 2004 16:34:48 -0800 Received: from [17.201.22.21] (moleja.apple.com [17.201.22.21]) by relay1.apple.com (8.12.11/8.12.11) with ESMTP id i2J0YkHK026057; Fri, 19 Mar 2004 00:34:46 GMT In-Reply-To: <4059FEA9.4030401@gnu.org> References: <6994FFF8-786D-11D8-9229-000393D457E2@apple.com> <4059FEA9.4030401@gnu.org> Mime-Version: 1.0 (Apple Message framework v613) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <3489FABC-793D-11D8-A2F0-000393D457E2@apple.com> Content-Transfer-Encoding: 7bit Cc: gdb-patches@sources.redhat.com From: Jason Molenda Subject: Re: RFC patch mi-cmds.c table format (pedantic) Date: Fri, 19 Mar 2004 00:34:00 -0000 To: Andrew Cagney X-SW-Source: 2004-03/txt/msg00445.txt.bz2 On Mar 18, 2004, at 11:55 AM, Andrew Cagney wrote: > First, have a look at: > http://sources.redhat.com/cgi-bin/gnatsweb.pl?cmd=view%20audit- > trail&database=gdb&pr=496 Ah, I hadn't seen that. How do you envision the cli-mapped mi commands working (e.g. -gdb-set), where files in the gdb/ directory are registering the commands? >> the mi-cmds table changed from this format: >> {"break-info", "info break %s", 0}, >> {"break-insert", 0, 0, mi_cmd_break_insert}, >> to this format: >> { "break-info", { "info break", 1 }, NULL, NULL }, >> { "break-insert", { NULL, 0 }, 0, mi_cmd_break_insert}, >> As you can see here, the use of 0 vs NULL is inconsistent, > > That's cos it was converted using an emacs macro. Emacs? Ah, well, I think we can all see the problem right there. :-) >> ok, but perhaps don't bother with the trailing initializers. OK I'll come up with a real/tested patch. The trailing initializers -- you don't mean this kind of change, do you? >> - { "exec-step", { NULL, 0 }, mi_cmd_exec_step}, >> + { "exec-step", { NULL, 0 }, mi_cmd_exec_step, NULL}, I think you were talking about the final NULL entry. > Should I ask what motived this? Our GUI guys asked for -exec-abort to be implemented so I had cause to look at our tasty-fresh-mid-merge sources for the first time, where we're just picking up FSF gdb changes from the last year or so. J