From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cOyiKOHt8GLVuSIAWB0awg (envelope-from ) for ; Mon, 08 Aug 2022 07:05:05 -0400 Received: by simark.ca (Postfix, from userid 112) id A3C151EA06; Mon, 8 Aug 2022 07:05:05 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256 header.s=google header.b=KGiaMw4k; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3FDEF1E9ED for ; Mon, 8 Aug 2022 07:05:05 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A6003385737E for ; Mon, 8 Aug 2022 11:05:04 +0000 (GMT) Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id 20EC93858281 for ; Mon, 8 Aug 2022 11:04:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 20EC93858281 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wr1-x42d.google.com with SMTP id z12so10442084wrs.9 for ; Mon, 08 Aug 2022 04:04:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=lEuW+Tld2VRgTuDKFbDRTRmt0WyJYEq4HU/jM4IEp18=; b=KGiaMw4kIi16BAZ5tmbVcKS0ag5zt2cws/INEk37+Txxm1Xn6abbMXb7MjXM+l+tBZ blhdqTRjzLuVt9BTtSFVV25iujYP0hFsO4awsjVftdgJIu4z/KM+DOQFFnvcR54SbV00 BpmzV+WemmJfL4H6XlygYNenAQYVR8GkJO/npxBXBL3udpUbSTdpS+fw2c4R2UJY9Xiw myWINYnclhqrdMJmeCecVQouG28kX4uTqkf4+oEkGpjZQXnYTUsJ/oRZcUg1a0wsBs41 CgwKKiY+vZ5AB4stpmp0r+66cwlWTnhmKVwWa9JxBO+Bra65tlygX3NN9Felz9NAU/ZI YzYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=lEuW+Tld2VRgTuDKFbDRTRmt0WyJYEq4HU/jM4IEp18=; b=vgJhWNy97XVNndsc6/m/FgVk73tr3WF0/b76u/eC6hmPOPL3+hxWDfMR/knRcs7ke9 6Jsk4zXhESi4FAldMaVycW2Y3EW2rcDvWsDwlBUbvcw7V4VOrOvtC7Ax9zjwrveaG77f elRtsA0yCZk+2MBYMcNJj3zmddhQi14T0jFkt3Boc3ZOBZ8MvvPFtKRU7NaibGn5IjFJ lRV4NaOVcqycZ988eXhz7kKu+JobOslEH+udrZUEebvQaZj+Ro/dVaoL/LRS8O6AfMis 8bdbAy9+pWCI+nfLiAoW+r2jTF5q52Qmp4wF+L9SRzFqKCxTMKJRK0pRxwkvyraqSzJY oTJA== X-Gm-Message-State: ACgBeo1s0M/o2P6fTQ2DJUyo0Awmo2XQ9sdjwZzQ24QO0ivxdN/HvEgD WjShCPrqgsWhtstA9gkTXxMf9w== X-Google-Smtp-Source: AA6agR6xTTRnRYh8AGuzBIhRMx4FfJf065JzXWVXZLopgcoclmBdiuVlwNEtL6ZnAjQPi/0H8Z1yWQ== X-Received: by 2002:a5d:648c:0:b0:220:7aa9:a13c with SMTP id o12-20020a5d648c000000b002207aa9a13cmr10814318wri.269.1659956691879; Mon, 08 Aug 2022 04:04:51 -0700 (PDT) Received: from [192.168.0.78] ([212.69.42.53]) by smtp.gmail.com with ESMTPSA id u13-20020a5d434d000000b0021e74ef5ae8sm11123015wrr.21.2022.08.08.04.04.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Aug 2022 04:04:51 -0700 (PDT) Message-ID: <3480a85f-09e5-8c24-826c-a3fd563a013c@embecosm.com> Date: Mon, 8 Aug 2022 12:04:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCHv4 0/2] Make thread_info executing and resumed state more consistent Content-Language: en-US To: Andrew Burgess , gdb-patches@sourceware.org References: <20220113183406.3577620-1-aburgess@redhat.com> From: Craig Blackmore In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 21/04/2022 17:45, Andrew Burgess via Gdb-patches wrote: > And I'm back on this patch again! > > I've rebased this onto current master and done some testing. I > haven't found any regressions, but as I've said before, this change > touches every target, and my testing on anything other than GNU/Linux > (x86-64) is pretty thin, so I'm fully expecting this to introduce some > issues - these issues _should_ be limited to assertion failures when > threads are not in the expected states, I would hope there's no > crashes being introduced. > > There's been no significant changes since v3. I have split out a > little bit of the debug printing code (the new #1 patch), but the > second patch is pretty much the same as v3. > > V3 was given a cautious OK, but I wanted to advertise this patch again > in case anyone wants to object before I merge this. Hi Andrew, Do you still intend to merge the second patch in this series? Thanks, Craig > All feedback is welcome. > > Thanks, > Andrew > > --- > > Andrew Burgess (2): > gdb: add some additional thread status debug output > gdb: make thread_info executing and resumed state more consistent > > gdb/aix-thread.c | 4 +- > gdb/bsd-kvm.c | 2 +- > gdb/bsd-uthread.c | 4 +- > gdb/corelow.c | 9 +++- > gdb/darwin-nat.c | 2 +- > gdb/fbsd-nat.c | 4 +- > gdb/fork-child.c | 3 ++ > gdb/gdbthread.h | 24 ++++++--- > gdb/gnu-nat.c | 13 +++-- > gdb/go32-nat.c | 2 +- > gdb/inf-ptrace.c | 4 +- > gdb/infcmd.c | 84 +++++++++++++++++++++---------- > gdb/infrun.c | 96 +++++++++++++++++++++++++++++++----- > gdb/infrun.h | 26 ++++++++++ > gdb/linux-nat.c | 8 +-- > gdb/linux-thread-db.c | 2 +- > gdb/netbsd-nat.c | 4 +- > gdb/nto-procfs.c | 2 +- > gdb/obsd-nat.c | 4 +- > gdb/process-stratum-target.c | 4 +- > gdb/procfs.c | 12 ++--- > gdb/ravenscar-thread.c | 4 +- > gdb/remote-sim.c | 2 +- > gdb/remote.c | 21 +++++--- > gdb/sol-thread.c | 4 +- > gdb/thread.c | 40 +++++++++++---- > gdb/tracectf.c | 3 +- > gdb/tracefile-tfile.c | 2 +- > gdb/windows-nat.c | 12 ++++- > 29 files changed, 295 insertions(+), 106 deletions(-) >