From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85947 invoked by alias); 4 May 2017 16:42:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85929 invoked by uid 89); 4 May 2017 16:42:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy= X-HELO: mail-wm0-f42.google.com Received: from mail-wm0-f42.google.com (HELO mail-wm0-f42.google.com) (74.125.82.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 04 May 2017 16:42:24 +0000 Received: by mail-wm0-f42.google.com with SMTP id m123so588696wma.0 for ; Thu, 04 May 2017 09:42:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=P52tlypIL8UVQHPbHvkW8HUiLxNntNeTeD54N7uS3UQ=; b=CWPQY0ZOBaeMIqDXzTGjPn71DswUAsYFoUlv5X7xmD+we9WHVEJ0xjE8e9sbaGo3Vr 8qySd7TJ87BQdTTWH8OpPGi2PnL/iUISZHKlewV1u1ShH2Zltenr/i9WmAyj0cfDYpdC GIHnPemyWY7281Lkn2/YPUCEevEqHuEdDIgAVltU9PU9j5ZlsUbcF5G+bGOHjs9XoMuN 602XJV9LfFfAxhagg157SWOk4zzLVbCQwjNERejMYorQLOe0HkaPqEXnI8Es7m3pMwp9 frEhoDzLt5yiLXap6Me4CeaUukX183jmUdDk3pFcPxyYpeX7gwiw7H0L6//zh/QNenV4 SfcQ== X-Gm-Message-State: AN3rC/71ovhJExCPmRJfBz6gTLspuWer6k8qAAYA3TMuqJSqphvnryGb q5YtIPwxTyxb9ex5rgONhg== X-Received: by 10.28.33.66 with SMTP id h63mr2669808wmh.86.1493916144602; Thu, 04 May 2017 09:42:24 -0700 (PDT) Received: from [192.168.0.102] ([37.189.166.198]) by smtp.gmail.com with ESMTPSA id j124sm1937811wmg.13.2017.05.04.09.42.23 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 May 2017 09:42:23 -0700 (PDT) Subject: Re: Oh dear. I regret to inform you that commit 'RAII-fy make_cleanup_restore_current_thread & friends' might be unfortunate To: gdb-patches@sourceware.org References: From: Pedro Alves Message-ID: <34792dd0-088c-a1d1-9125-70c8585c21bd@redhat.com> Date: Thu, 04 May 2017 16:42:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-05/txt/msg00116.txt.bz2 On 05/04/2017 05:06 PM, gdb-buildbot@sergiodj.net wrote: > g++ -g -O2 -I. -I../../binutils-gdb/gdb -I../../binutils-gdb/gdb/common -I../../binutils-gdb/gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I../../binutils-gdb/gdb/../include/opcode -I../../binutils-gdb/gdb/../opcodes/.. -I../../binutils-gdb/gdb/../readline/.. -I../../binutils-gdb/gdb/../zlib -I../bfd -I../../binutils-gdb/gdb/../bfd -I../../binutils-gdb/gdb/../include -I../libdecnumber -I../../binutils-gdb/gdb/../libdecnumber -I../../binutils-gdb/gdb/gnulib/import -Ibuild-gnulib/import -DTUI=1 -pthread -I/usr/include/guile/2.0 -I/usr/include/python2.7 -I/usr/include/python2.7 -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable -Wno-sign-compare -Wno-narrowing -Wformat-nonliteral -Werror -c -o interps.o -MT interps.o -MMD -MP -MF .deps/interps.Tpo ../../binutils-gdb/gdb/interps.c > In file included from ../../binutils-gdb/gdb/infrun.c:26:0: > ../../binutils-gdb/gdb/inferior.h: In function void handle_vfork_child_exec_or_exit(int): > ../../binutils-gdb/gdb/inferior.h:553:39: error: *((void*)(& maybe_restore_inferior)+40).scoped_restore_current_inferior::m_saved_inf may be used uninitialized in this function [-Werror=maybe-uninitialized] > { set_current_inferior (m_saved_inf); } > ^ > ../../binutils-gdb/gdb/infrun.c:940:6: note: *((void*)(& maybe_restore_inferior)+40).scoped_restore_current_inferior::m_saved_inf was declared here > maybe_restore_inferior; > ^~~~~~~~~~~~~~~~~~~~~~ > In file included from ../../binutils-gdb/gdb/inferior.h:46:0, > from ../../binutils-gdb/gdb/infrun.c:26: > ../../binutils-gdb/gdb/progspace.h:274:47: error: *((void*)(& maybe_restore_inferior)+32).scoped_restore_current_program_space::m_saved_pspace may be used uninitialized in this function [-Werror=maybe-uninitialized] > { set_current_program_space (m_saved_pspace); } > ^ > ../../binutils-gdb/gdb/infrun.c:940:6: note: *((void*)(& maybe_restore_inferior)+32).scoped_restore_current_program_space::m_saved_pspace was declared here > maybe_restore_inferior; > ^~~~~~~~~~~~~~~~~~~~~~ Fun, looks like gdb::optional related ... Thanks, Pedro Alves