From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108303 invoked by alias); 29 Jan 2018 11:01:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108288 invoked by uid 89); 29 Jan 2018 11:01:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=-3.5 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=can, that, can=e2, Hx-exchange-antispam-report-cfa-test:3231101?= X-HELO: EUR03-DB5-obe.outbound.protection.outlook.com Received: from mail-eopbgr40045.outbound.protection.outlook.com (HELO EUR03-DB5-obe.outbound.protection.outlook.com) (40.107.4.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 29 Jan 2018 11:01:29 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0577.eurprd08.prod.outlook.com (10.163.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Mon, 29 Jan 2018 11:01:25 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::c95:81b8:c681:ae2]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::c95:81b8:c681:ae2%17]) with mapi id 15.20.0444.016; Mon, 29 Jan 2018 11:01:25 +0000 From: Alan Hayward To: Omair Javaid CC: Philipp Rudo , "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH v2 5/8] Use tdesc types in gdbserver tdesc Date: Mon, 29 Jan 2018 11:01:00 -0000 Message-ID: <346CC31C-E52E-4461-845F-9975F53254AF@arm.com> References: <7C97CC6A-92CB-4702-820D-206022F07102@arm.com> <771B81D3-D1C8-4D94-9713-3AD466DBA5F8@arm.com> <20180125141259.544597d6@ThinkPad> In-Reply-To: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM3PR08MB0577;7:iMuzhET7dkHIvIDKYdUAo/64b0qzy8kntoriOEzZ2FBhGiKm7LCfUjHS5myZbEBiGAXFJtWKggFQY322C+9cI3zIWbNTAL3V4DBMAvcEH89M1Y9QcW66Jc82li7NHrugdCdwS3jWGXwVHhzaddSHEod/zUxwIc3oPcXuHNWe2d7T/lin9U7CnGBPoENfKsD+tYk3xI1ClKRjlzTMRqSUYacoEFPAJVfjpgY85z166OWo29Yr5JZovSlrIEk1OQMF x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 5e81e574-550a-4773-7c40-08d56707a41a x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020);SRVR:AM3PR08MB0577; x-ms-traffictypediagnostic: AM3PR08MB0577: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(8121501046)(5005006)(3231101)(944501161)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041288)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(6072148)(201708071742011);SRVR:AM3PR08MB0577;BCL:0;PCL:0;RULEID:;SRVR:AM3PR08MB0577; x-forefront-prvs: 0567A15835 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(376002)(39860400002)(346002)(39380400002)(396003)(366004)(43544003)(189003)(199004)(8936002)(478600001)(72206003)(4326008)(76176011)(3660700001)(2906002)(26005)(3280700002)(6436002)(2900100001)(5660300001)(93886005)(53936002)(6512007)(68736007)(4743002)(36756003)(106356001)(33656002)(99286004)(6506007)(6246003)(14454004)(54906003)(97736004)(3846002)(305945005)(316002)(83716003)(5250100002)(25786009)(81156014)(81166006)(7736002)(82746002)(8676002)(102836004)(6116002)(66066001)(6486002)(186003)(229853002)(6916009)(86362001)(2950100002)(105586002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR08MB0577;H:AM3PR08MB0101.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: CJhECZKltBzGqCElryzHwwZIR80N+/Sd/oBzqsh3bJgaAJubtIn4SCzTOGpWNe071JAko1YrQwKfjjyUHDaNJQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <62593D6A999AEB46B863AA2947F5F566@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e81e574-550a-4773-7c40-08d56707a41a X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jan 2018 11:01:25.7643 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0577 X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00586.txt.bz2 DQo+IA0KPiBXaXRoIHRkZXNjX2ZlYXR1cmVzLCB0ZGVzY190eXBlX3dpdGhf ZmllbGRzIGV0Yy4gYmVpbmcgbm8gbG9uZ2VyIG9wYXF1ZSBhbmQNCj4gc28g bWFueSBmdW5jdGlvbnMgc2hhcmVkIG1hbnkgb2YgdGhlbSBjb3VsZCBiZSBt YWRlIGNsYXNzIG1ldGhvZHMuIEhvd2V2ZXINCj4gdGhhdCBleGNlZWRzIHRo ZSBzY29wZSBvZiB0aGlzIHBhdGNoIHNldCwgYnV0IHNob3VsZCBiZSBrZXB0 IGluIG1pbmQgZm9yIHRoZQ0KPiBmdXR1cmUuDQoNClRoZSAiW1BBVENIXSBV c2UgdmlzaXRvcnMgZm9yIG1ha2VfZ2RiX3R5cGXigJ0gcGF0Y2ggc2hvdWxk IHRha2UgY2FyZSBvZiBhIGxhcmdlIHNldCBvZiB0aGVtLg0KDQo+IA0KPiBB cHBhcmVudGx5LCBpdCBtYXkgc2VlbSBiZXR0ZXIgdG8gbW92ZSB0aGUgd2hv bGUgdGFyZ2V0IGRlc2NyaXB0aW9uIGNvZGUgdG8gYSBjb21tb24gbG9jYXRp b24gYW5kIHNoYXJlIGl0IGJldHdlZW4gZ2RiIGFuZCBnZGJzZXJ2ZXIuIA0K PiANCj4gVGFyZ2V0IGRlc2NyaXB0aW9ucyBhcmUgYXJjaGl0ZWN0dXJlIHNw ZWNpZmljIGJ1dCBhdCB0aGUgc2FtZSB0aW1lIHRhcmdldCBkZXNjcmlwdGlv biBjbGFzcyBjb2RlIGlzIGFyY2hpdGVjdHVyZSBpbmRlcGVuZGVudC4gU28g YXMgaGlnaGxpZ2h0ZWQgYnkgUGhpbGxpcCB0aGlzIGNvZGUgc2hvdWxkIGJl IG1vdmVkIG91dCBvZiBhcmMvIGZvbGRlciBhbmQgcGxhY2VkIGVsc2V3aGVy ZS4NCj4gDQoNCkFncmVlZC4NCklzIGNvbW1vbi8gdGhlIGJlc3QgcGxhY2U/ IEkgY2Fu4oCZdCBzZWUgYW55IG90aGVyIGRpcmVjdG9yeSB0aGF0IGxvb2tz IHJpZ2h0LiANCg0KPiBJdCBtYXkgc2VlbSBhIGNsZWFuIGFwcHJvYWNoIHRv IGNyZWF0ZSB0aGUgZGl2aXNpb24gbm93IGFuZCBhbHNvIHJlZmFjdG9yIGNv ZGUgbm93IHRoYW4gZG9pbmcgaXQgaW4gYSBsYXRlciBwYXRjaC4gT25seSBn b3RjaGEgaGVyZSBpcyB0aGF0IHRoaXMgY29kZSBpcyB1c2VkIGJ5IG11bHRp cGxlIHRhcmdldHMgc28gbmVlZCB0byBiZSB0ZXN0ZWQgYWdncmVzc2l2ZWx5 Lg0KDQpUaGF04oCZcyB3aHkgSSBkaWRu4oCZdCB3YW50IHRvIHJlZmFjdG9y IHRvbyBtdWNoIGluIG9uZSBzZXQuDQoNCg0KVGhhbmtzLA0KQWxhbi4= >From gdb-patches-return-145113-listarch-gdb-patches=sources.redhat.com@sourceware.org Mon Jan 29 11:31:00 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 41004 invoked by alias); 29 Jan 2018 11:31:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 40995 invoked by uid 89); 29 Jan 2018 11:30:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 29 Jan 2018 11:30:53 +0000 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w0TBPUSh042406 for ; Mon, 29 Jan 2018 06:30:52 -0500 Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) by mx0a-001b2d01.pphosted.com with ESMTP id 2ft008qdky-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 29 Jan 2018 06:30:51 -0500 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 29 Jan 2018 11:30:47 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 29 Jan 2018 11:30:44 -0000 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w0TBUiZX43253894; Mon, 29 Jan 2018 11:30:44 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 57E4D4203F; Mon, 29 Jan 2018 11:23:53 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3688842047; Mon, 29 Jan 2018 11:23:53 +0000 (GMT) Received: from ThinkPad (unknown [9.152.212.63]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 29 Jan 2018 11:23:53 +0000 (GMT) Date: Mon, 29 Jan 2018 11:31:00 -0000 From: Philipp Rudo To: Alan Hayward Cc: Omair Javaid , "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH v2 5/8] Use tdesc types in gdbserver tdesc In-Reply-To: <346CC31C-E52E-4461-845F-9975F53254AF@arm.com> References: <7C97CC6A-92CB-4702-820D-206022F07102@arm.com> <771B81D3-D1C8-4D94-9713-3AD466DBA5F8@arm.com> <20180125141259.544597d6@ThinkPad> <346CC31C-E52E-4461-845F-9975F53254AF@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 x-cbid: 18012911-0008-0000-0000-000004C6F387 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18012911-0009-0000-0000-00001E5A8583 Message-Id: <20180129123042.4a1674d6@ThinkPad> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-29_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801290154 X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00587.txt.bz2 Content-length: 1659 Hi Alan, On Mon, 29 Jan 2018 11:01:25 +0000 Alan Hayward wrote: > >=20 > > With tdesc_features, tdesc_type_with_fields etc. being no longer opaque= and > > so many functions shared many of them could be made class methods. Howe= ver > > that exceeds the scope of this patch set, but should be kept in mind fo= r the > > future.=20=20 >=20 > The "[PATCH] Use visitors for make_gdb_type=E2=80=9D patch should take ca= re of a large set of them. I was more thinking of functions like tdesc_add_* and tdesc_create_* (inclu= ding tdesc_create_reg). They are not covered by your make_gdb_type patch. The = way I see it the changes needed to be made are quite small. Unfortunately they require to regenerate the cfiles making the resulting patches large and hard to read. Philipp =20 > >=20 > > Apparently, it may seem better to move the whole target description cod= e to a common location and share it between gdb and gdbserver.=20 > >=20 > > Target descriptions are architecture specific but at the same time targ= et description class code is architecture independent. So as highlighted by= Phillip this code should be moved out of arc/ folder and placed elsewhere. > >=20=20=20 >=20 > Agreed. > Is common/ the best place? I can=E2=80=99t see any other directory that l= ooks right.=20 >=20 > > It may seem a clean approach to create the division now and also refact= or code now than doing it in a later patch. Only gotcha here is that this c= ode is used by multiple targets so need to be tested aggressively.=20=20 >=20 > That=E2=80=99s why I didn=E2=80=99t want to refactor too much in one set. >=20 >=20 > Thanks, > Alan.