From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50335 invoked by alias); 31 Jan 2019 17:24:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50322 invoked by uid 89); 31 Jan 2019 17:24:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR02-HE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr10070.outbound.protection.outlook.com (HELO EUR02-HE1-obe.outbound.protection.outlook.com) (40.107.1.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 31 Jan 2019 17:24:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gxDZPTogAIGTtiQB7Oxq4guw8XCcB3ZteEj5+2/ihnU=; b=Zfxv0W2mPii4LqzrqejaHaSNVpWSvxDLmZhfiGNqDn9FL+9xWWdTHW77D2BvQ6H7odvPZ7Z+THjDSK9mEhajAascoIJGOqhnKx9ehLuozK7g9HhqM2hdbOkyfVYxPnSVc45Kb2pQoAyXg/20fv/pVtkIdqZ1WazyS0ZJSZe19Ho= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) by DB6PR0802MB2405.eurprd08.prod.outlook.com (10.172.250.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1580.17; Thu, 31 Jan 2019 17:24:51 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::acd7:a958:2aaa:562e]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::acd7:a958:2aaa:562e%5]) with mapi id 15.20.1580.017; Thu, 31 Jan 2019 17:24:51 +0000 From: Alan Hayward To: Joel Brobecker CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH] Readline: Cleanup some warnings Date: Thu, 31 Jan 2019 17:24:00 -0000 Message-ID: <3463805B-A8BF-4C20-ACE3-C21AE3F7DB62@arm.com> References: <20190130085716.75179-1-alan.hayward@arm.com> <20190131075907.GA313@adacore.com> In-Reply-To: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 Content-Type: text/plain; charset="utf-8" Content-ID: <68F287970080BF44A9E497AF59345C85@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00622.txt.bz2 DQoNCj4gT24gMzEgSmFuIDIwMTksIGF0IDEwOjAyLCBBbGFuIEhheXdhcmQg PEFsYW4uSGF5d2FyZEBhcm0uY29tPiB3cm90ZToNCj4gDQo+IA0KPiANCj4+ IE9uIDMxIEphbiAyMDE5LCBhdCAwNzo1OSwgSm9lbCBCcm9iZWNrZXIgPGJy b2JlY2tlckBhZGFjb3JlLmNvbT4gd3JvdGU6DQo+PiANCj4+PiAoUG9zdGVk IHRoaXMgZmlyc3QgdG8gYmludXRpbHMsIHRoZW4gd2FzIGRpcmVjdGVkIGJh Y2sgaGVyZSBhbmQNCj4+PiBwb2ludGVkIGF0IHRoZSB1cHN0cmVhbSByZWFk bGluZS4gIExvb2tpbmcgYXQgdGhlIHVwc3RyZWFtDQo+Pj4gcmVhZGxpbmUg aXQgaGFzIGFscmVhZHkgZml4ZWQgdGhlIGlzc3VlcyBiZWxvdyBpbiB0aGUg c2FtZSB3YXkuDQo+Pj4gVGVzdGVkIGJ5IHJ1bm5pbmcgdGhlIGdkYiB0ZXN0 c3VpdGUgLSBjb3VsZG4ndCBzZWUgYSByZWFkbGluZQ0KPj4+IHNwZWNpZmlj IHN1aXRlLikgDQo+Pj4gDQo+Pj4gQ2xlYW51cCB0aGUgcmVhZGxpbmUgd2Fy bmluZ3MgdGhhdCBnZGIgYnVpbGRib3QgY29tcGxhaW5zIGFib3V0Lg0KPj4+ IA0KPj4+IFRvIHByZXZlbnQgd2N3aWR0aCBtaXNzaW5nIGRlY2xhcmF0aW9u IHdhcm5pbmdzLCBhZGQgdGhlIFNPVVJDRSAvDQo+Pj4gRVhURU5TSU9OIG1h Y3JvcyB0byBjb25maWcuaW4gdGhhdCBoYXZlIGFscmVhZHkgY2hlY2tlZCBm b3IgaW4NCj4+PiBjb25maWd1cmUuICBVc2UgdGhlIGV4YWN0IHNhbWUgbGlz dCBhcyBHREIgLSBpdCBzZWVtZWQgc2Vuc2libGUNCj4+PiB0byBhZGQgYWxs IG9mIHRoZW0uDQo+Pj4gDQo+Pj4gRW5zdXJlIHBpZCBpcyBhIGxvbmcgYmVm b3JlIHByaW50aW5nIGFzIG9uZS4gIEFsc28gZml4IEdOVSBzdHlsZS4NCj4+ PiANCj4+PiBDaGVjayB0aGUgcmV0dXJuIHZhbHVlIG9mIHdyaXRlIHRoZSBz YW1lIHdheSBhcyBoaXN0b3J5X2RvX3dyaXRlICgpLg0KPj4+IA0KPj4+IFRo ZXNlIGNoYW5nZXMgYXJlIGNvbnNpc3RlbnQgd2l0aCB1cHN0cmVhbSByZWFk bGluZS4NCj4+PiANCj4+PiByZWFkbGluZS9DaGFuZ2VMb2cuZ2RiOg0KPj4+ IA0KPj4+IDIwMTktMDEtMzAgIEFsYW4gSGF5d2FyZCAgPGFsYW4uaGF5d2Fy ZEBhcm0uY29tPg0KPj4+IA0KPj4+IAkqIGNvbmZpZy5oLmluOiBBZGQgU09V UkNFL0VYVEVOU0lPTiBtYWNyb3MuDQo+Pj4gCSogaGlzdGZpbGUuYyAoaGlz dG9yeV90cnVuY2F0ZV9maWxlKTogQ2hlY2sgcmV0dXJuIG9mIHdyaXRlLg0K Pj4+IAkqIHV0aWwuYzogRW5zdXJlIHBpZCBpcyBsb25nLg0KPj4gDQo+PiBJ ZiBpdCBpcyBhIGJhY2twb3J0DQo+IA0KPiBUZWNobmljYWxseSwgbm90IGEg YmFjayBwb3J0IGJlY2F1c2UgSSB3cm90ZSB0aGUgY2hhbmdlcyB0aGVuIHJl YWxpc2VkDQo+IHRoZXkgYXJlIHRoZSBzYW1lIGFzIHVwc3RyZWFtLiAgSnVz dCBhIHF1aWNrIHRob3VnaHQgLSB3b3VsZCBpdCBoZWxwDQo+IHdpdGggZnV0 dXJlIHJlYmFzaW5nIGlmIEkgZW5zdXJlZCB0aGUgY2hhbmdlcyB3ZXJlICpl eGFjdGx5KiB0aGUgc2FtZT8NCj4gKEZvciBleGFtcGxlLCB0aGUgY29uZmln LmguaW4gY2hhbmdlcyBhcmUgaW4gYSBkaWZmZXJlbnQgcGxhY2UgaW4gdGhl IA0KPiBmaWxlIHdpdGggZGlmZmVyZW50IGNvbW1lbnRzKS4NCj4gDQo+PiBm cm9tIG1haW5saW5lIHJlYWRsaW5lLCBhbmQgeW91J3ZlIHJ1bg0KPj4gdGhl IHRlc3RzdWl0ZSAocmVhZGxpbmUgaXMgYmVpbmcgbmVjZXNzYXJpbHkgZXh0 ZW5zaXZlbHkgY292ZXJlZCwNCj4+IGJ1dCBhdCBsZWFzdCBpdCBpcyB1c2Vk IGltcGxpY2l0bHksIHNpbmNlIGl0IHByb3ZpZGVzIHRoZSBmcmFtZXdvcmsN Cj4+IGZvciB0aGUgaW50ZXJhY3RpdmUgcHJvbXB0LCB3aGljaCBpcyBiZWlu ZyBkcml2ZW4gdmlhIGV4cGVjdC90Y2wpLA0KPj4gaXQncyBPSyB0byBwdXNo Lg0KDQpUaGlua2luZyBhYm91dCB3aGF0IHlvdSBzYWlkLCBJ4oCZdmUgdXBk YXRlZCB0aGUgY29uZmlnLmguaW4gY29kZSBzbyBpdA0KaXMgYSBkaXJlY3Qg YmFja3BvcnQsIGFuZCBwdXNoZWQuICBGdW5jdGlvbmFsbHkgaXTigJlzIHRo ZSBzYW1lIGFzIHRoZQ0Kb3JpZ2luYWwgdmVyc2lvbi4gUGF0Y2ggcGFzdGVk IGJlbG93Lg0KDQoNCg0KZGlmZiAtLWdpdCBhL3JlYWRsaW5lL2NvbmZpZy5o LmluIGIvcmVhZGxpbmUvY29uZmlnLmguaW4NCmluZGV4IDg2ZDg2Y2ZhM2Qu LmMxOTRlNzYxYTQgMTAwNjQ0DQotLS0gYS9yZWFkbGluZS9jb25maWcuaC5p bg0KKysrIGIvcmVhZGxpbmUvY29uZmlnLmguaW4NCkBAIC0xLDUgKzEsMTUg QEANCiAvKiBjb25maWcuaC5pbi4gIE1haW50YWluZWQgYnkgaGFuZC4gKi8N Cg0KKy8qIFRlbXBsYXRlIGRlZmluaXRpb25zIGZvciBhdXRvY29uZiAqLw0K KyN1bmRlZiBfX0VYVEVOU0lPTlNfXw0KKyN1bmRlZiBfQUxMX1NPVVJDRQ0K KyN1bmRlZiBfR05VX1NPVVJDRQ0KKyN1bmRlZiBfUE9TSVhfU09VUkNFDQor I3VuZGVmIF9QT1NJWF8xX1NPVVJDRQ0KKyN1bmRlZiBfUE9TSVhfUFRIUkVB RF9TRU1BTlRJQ1MNCisjdW5kZWYgX1RBTkRFTV9TT1VSQ0UNCisjdW5kZWYg X01JTklYDQorDQogLyogRGVmaW5lIE5PX01VTFRJQllURV9TVVBQT1JUIHRv IG5vdCBjb21waWxlIGluIHN1cHBvcnQgZm9yIG11bHRpYnl0ZQ0KICAgIGNo YXJhY3RlcnMsIGV2ZW4gaWYgdGhlIE9TIHN1cHBvcnRzIHRoZW0uICovDQog I3VuZGVmIE5PX01VTFRJQllURV9TVVBQT1JUDQpkaWZmIC0tZ2l0IGEvcmVh ZGxpbmUvaGlzdGZpbGUuYyBiL3JlYWRsaW5lL2hpc3RmaWxlLmMNCmluZGV4 IGZmZmViM2ZkMzEuLjU2Y2JiZjA0OTggMTAwNjQ0DQotLS0gYS9yZWFkbGlu ZS9oaXN0ZmlsZS5jDQorKysgYi9yZWFkbGluZS9oaXN0ZmlsZS5jDQpAQCAt NDA3LDcgKzQwNyw4IEBAIGhpc3RvcnlfdHJ1bmNhdGVfZmlsZSAoZm5hbWUs IGxpbmVzKQ0KICAgICAgdHJ1bmNhdGUgdG8uICovDQogICBpZiAoYnAgPiBi dWZmZXIgJiYgKChmaWxlID0gb3BlbiAoZmlsZW5hbWUsIE9fV1JPTkxZfE9f VFJVTkN8T19CSU5BUlksIDA2MDApKSAhPSAtMSkpDQogICAgIHsNCi0gICAg ICB3cml0ZSAoZmlsZSwgYnAsIGNoYXJzX3JlYWQgLSAoYnAgLSBidWZmZXIp KTsNCisgICAgICBpZiAod3JpdGUgKGZpbGUsIGJwLCBjaGFyc19yZWFkIC0g KGJwIC0gYnVmZmVyKSkgPCAwKQ0KKyAgICAgICBydiA9IGVycm5vOw0KDQog I2lmIGRlZmluZWQgKF9fQkVPU19fKQ0KICAgICAgIC8qIEJlT1MgaWdub3Jl cyBPX1RSVU5DLiAqLw0KZGlmZiAtLWdpdCBhL3JlYWRsaW5lL3V0aWwuYyBi L3JlYWRsaW5lL3V0aWwuYw0KaW5kZXggZDQwMmZjZTg0Mi4uMTNiZDAwYzA5 YyAxMDA2NDQNCi0tLSBhL3JlYWRsaW5lL3V0aWwuYw0KKysrIGIvcmVhZGxp bmUvdXRpbC5jDQpAQCAtNTE1LDExICs1MTUsMTEgQEAgX3JsX3Ryb3BlbiAo KQ0KICAgICAgICAgICAoc2hfZ2V0X2Vudl92YWx1ZSAoIlRFTVAiKQ0KICAg ICAgICAgICAgPyBzaF9nZXRfZW52X3ZhbHVlICgiVEVNUCIpDQogICAgICAg ICAgICA6ICIuIiksDQotICAgICAgICAgIGdldHBpZCgpKTsNCisgICAgICAg ICAgZ2V0cGlkICgpKTsNCiAjZWxzZQ0KLSAgc3ByaW50ZiAoZm5idWYsICIv dmFyL3RtcC9ybHRyYWNlLiVsZCIsIGdldHBpZCgpKTsNCisgIHNwcmludGYg KGZuYnVmLCAiL3Zhci90bXAvcmx0cmFjZS4lbGQiLCAobG9uZykgZ2V0cGlk ICgpKTsNCiAjZW5kaWYNCi0gIHVubGluayhmbmJ1Zik7DQorICB1bmxpbmsg KGZuYnVmKTsNCiAgIF9ybF90cmFjZWZwID0gZm9wZW4gKGZuYnVmLCAidysi KTsNCiAgIHJldHVybiBfcmxfdHJhY2VmcCAhPSAwOw0KIH0NCg0KDQo= >From gdb-patches-return-153733-listarch-gdb-patches=sources.redhat.com@sourceware.org Fri Feb 01 08:05:42 2019 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 35352 invoked by alias); 1 Feb 2019 08:05:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 35342 invoked by uid 89); 1 Feb 2019 08:05:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 01 Feb 2019 08:05:40 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 530235602B; Fri, 1 Feb 2019 03:05:38 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id YnC+BFkptF8n; Fri, 1 Feb 2019 03:05:38 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id EC15F56028; Fri, 1 Feb 2019 03:05:37 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 4EDE5857A7; Fri, 1 Feb 2019 12:05:33 +0400 (+04) Date: Fri, 01 Feb 2019 08:05:00 -0000 From: Joel Brobecker To: Alan Hayward Cc: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH] Readline: Cleanup some warnings Message-ID: <20190201080533.GA31043@adacore.com> References: <20190130085716.75179-1-alan.hayward@arm.com> <20190131075907.GA313@adacore.com> <3463805B-A8BF-4C20-ACE3-C21AE3F7DB62@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3463805B-A8BF-4C20-ACE3-C21AE3F7DB62@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2019-02/txt/msg00000.txt.bz2 Content-length: 976 > >> If it is a backport > > > > Technically, not a back port because I wrote the changes then realised > > they are the same as upstream. Just a quick thought - would it help > > with future rebasing if I ensured the changes were *exactly* the same? > > (For example, the config.h.in changes are in a different place in the > > file with different comments). > > > >> from mainline readline, and you've run > >> the testsuite (readline is being necessarily extensively covered, > >> but at least it is used implicitly, since it provides the framework > >> for the interactive prompt, which is being driven via expect/tcl), > >> it's OK to push. > > Thinking about what you said, I’ve updated the config.h.in code so it > is a direct backport, and pushed. Functionally it’s the same as the > original version. Patch pasted below. Thank you. It's always better if it is an exact backport, because it facilitates future resyncs with the upstream versions. -- Joel