From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MLdaBNhZg2QlpyIAWB0awg (envelope-from ) for ; Fri, 09 Jun 2023 12:56:56 -0400 Received: by simark.ca (Postfix, from userid 112) id 0F5011E124; Fri, 9 Jun 2023 12:56:56 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=freebsd.org header.i=@freebsd.org header.a=rsa-sha256 header.s=dkim header.b=k58kIcgH; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,RDNS_DYNAMIC autolearn=unavailable autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7184A1E111 for ; Fri, 9 Jun 2023 12:56:55 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9B5863858C52 for ; Fri, 9 Jun 2023 16:56:54 +0000 (GMT) Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id A69A93858C41 for ; Fri, 9 Jun 2023 16:56:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A69A93858C41 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4Qd6gC3Bd9z48Tw; Fri, 9 Jun 2023 16:56:39 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Qd6gC2362z3ntl; Fri, 9 Jun 2023 16:56:39 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686329799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cte3fs5Ci8/WlXwoJd9Ef1Pd6j+HuhMpexnabUWgmi8=; b=k58kIcgHJ1nS6GdgWC/KYE0qMUQJ88/abOQKMaWPtH6w90pF5AIktq/1kk5K8KCPExtTVu XRBoDm/cXmDruoRTYIPmxjW23iWpZ3Tdq4jn+IP5c2O2MDBZEKXmlKLkVy1xJARzEHLLpe s2oK6e8r+NC6fg6LfvSoyl5op6gIAWavW75odQiQGc/IIsEO0l+OshJdMPqu3oYcK0K1sX JqdHRrJ6mlYf6Ob3T3jpEN1p9Nao31n4i7irzESB3SbJQRkGJBoTt5rYhMKHm7LHm/OzzC hT8CWlUIlv57wnOjlpzhJ7VnM9cOEX93NP0YamptPO8xWE53DzejFxXRsbFxcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686329799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cte3fs5Ci8/WlXwoJd9Ef1Pd6j+HuhMpexnabUWgmi8=; b=Oh66DhMiUO6j48pzmWyMbFeyr57QCHTN1bhKYc7KpXtD90CvHvO4NUcKdTSJ+LIQsn13Du RroL+kPgoJziBF7Nwxl31FW0I2WHFQJUkynhkrW2qXC0lGgQ5V/TlnpSG+r7Ep2DtoSzSw aocYxSFQDnMKYKdSvhNtMJzy7YH8oNSPOBfhKE10DnaQpLdMVwce5tmj9eai/ltxUzgpDi nCPamV0o+L9xNQtssFINy0oZzyqRRxb2NQf8gtxE0oiVUaNp0wcoqKI5KXvKPqEk+ATV/a H1zzUssOrUNWKefK24VFEp9i2Os6q2U8MfA75ogG1Qk0vDxC5IWI5LIKgCYrwA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1686329799; a=rsa-sha256; cv=none; b=ex8m2E5r3vcOofheiDZBitjGuJtwR2irZJjTZEA1AP3hhgWSd1/5HEtrnZmuRWe9fIOmhw gK427Pfkxev4011SdyVh4P7uGWE8EVMsF003AR2qhoqbrfcKutYobgMbYfDxl9GgNK1uK9 M5UrJ20QeP6AQOQzG3q1HSjTT0MwMtkQARKBxPxznqCItra1gW+FOQfAU2O5WYbUJlPyOP AU6COzRE+h8yGBwnOnO7PF07wdC+jERkiYvGrpKk6boRdSCFpdPvY7x20VSGCap4Za3h3J u8PfaO21qMbd58rSpQ77T+kZwdLAndAHXifBjgngPV5icP/EYk5wihwQLHnf+A== Received: from [IPV6:2601:648:8680:16b0:b8bd:ccc7:cf3f:2632] (unknown [IPv6:2601:648:8680:16b0:b8bd:ccc7:cf3f:2632]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Qd6gB6G5RzJKQ; Fri, 9 Jun 2023 16:56:38 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <3458accc-ca2a-99aa-166e-6546c62ee9f8@FreeBSD.org> Date: Fri, 9 Jun 2023 09:56:37 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3] gdb tests: Allow for "LWP" in thread IDs from info threads. Content-Language: en-US From: John Baldwin To: Simon Marchi , gdb-patches@sourceware.org References: <20230418201305.61272-1-jhb@FreeBSD.org> <10ba4b3e-19e0-2889-47de-67667db21af1@simark.ca> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 5/26/23 10:51 AM, John Baldwin wrote: > On 5/12/23 7:15 AM, John Baldwin wrote: >> On 5/9/23 1:56 PM, John Baldwin wrote: >>> On 5/9/23 12:01 PM, Simon Marchi wrote: >>>> On 4/18/23 16:13, John Baldwin wrote: >>>>> Several tests assume that the first word after a thread ID in 'info >>>>> threads' output is "Thread". However, several targets use "LWP" >>>>> instead such as the FreeBSD and NetBSD native targets. The Linux >>>>> native target also uses "LWP" if libthread_db is not being used. >>>>> >>>>> Add a tdlabel_re global variable as a regular-expression for a thread >>>>> label in `info threads' that matches either "thread" or "LWP". >>>>> >>>>> Some other tests in the tree don't require a specific word, and >>>>> some targets may use other first words (e.g. OpenBSD uses "thread" >>>>> and Ravenscar threads use "Ravenscar Thread"). >>>> >>>> That LGTM, I don't really see another way: >>>> >>>> Approved-By: Simon Marchi >>>> >>>> One nit is that I prefer to use the ${::tdlabel_re} notation instead of >>>> the global keyword, but it's not a dealbreaker. >>>> >>>> And just one question: >>>> >>>>> diff --git a/gdb/testsuite/gdb.trace/report.exp b/gdb/testsuite/gdb.trace/report.exp >>>>> index 14db2511d40..a5b7ccf4ba5 100644 >>>>> --- a/gdb/testsuite/gdb.trace/report.exp >>>>> +++ b/gdb/testsuite/gdb.trace/report.exp >>>>> @@ -380,7 +380,7 @@ proc use_collected_data { data_source } { >>>>> >>>>> # There is always a thread of an inferior, either a live one or >>>>> # a faked one. >>>>> - gdb_test "info threads" "\\* ${decimal} (process|Thread) \[0-9\.\]+\[ \t\].*" >>>>> + gdb_test "info threads" "\\* ${decimal} ${tdlabel_re} \[0-9\.\]+\[ \t\].*" >>>> >>>> This one said "process" as well, I guess it's not important? >>> >>> Hummm, it didn't regress on Linux, but on some other native target that >>> doesn't support threads it might regress I guess. normal_pid_to_str >>> uses "process " and is the defalt for target::pid_to_str. >>> >>> Probably tdlabel_re should permit "process" as a word as well: >>> >>> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp >>> index 527c84599ca..6ded65e31c4 100644 >>> --- a/gdb/testsuite/lib/gdb.exp >>> +++ b/gdb/testsuite/lib/gdb.exp >>> @@ -283,7 +283,7 @@ set inferior_exited_re "(?:\\\[Inferior \[0-9\]+ \\(\[^\n\r\]*\\) exited)" >>> >>> # A regular expression that matches the first word of a thread >>> # description after the thread number info 'info threads' >>> -set tdlabel_re "(Thread|LWP)" >>> +set tdlabel_re "(process|Thread|LWP)" >>> >>> # A regular expression that matches a value history number. >>> # E.g., $1, $2, etc. >>> >>> (I'd also have to reword the commit log a bit to mention this case if so.) >> >> Just to be sure, are you still ok with this patch with this tweak? > > Ping, here's the updated log message to match: > > gdb tests: Allow for "LWP" in thread IDs from info threads. > > Several tests assume that the first word after a thread ID in 'info > threads' output is "Thread". However, several targets use "LWP" > instead such as the FreeBSD and NetBSD native targets. The Linux > native target also uses "LWP" if libthread_db is not being used. > Targets that do not support threads use "process" as the first word > via normal_pid_to_str. > > Add a tdlabel_re global variable as a regular-expression for a thread > label in `info threads' that matches either "process", "Thread", or > "LWP". > > Some other tests in the tree don't require a specific word, and > some targets may use other first words (e.g. OpenBSD uses "thread" > and Ravenscar threads use "Ravenscar Thread"). Ping, this is mostly a small change to a previously approved patch, just not sure what the threshold is for if a fixup change is small enough to still count as approved, etc. -- John Baldwin