Re: submition of i386.record.floating.point.patch

Hui Zhu
2009-05-31T15:44:47Z

Hi Oza,

Thanks for your works. Before I read your patch, I have some ideas
with your RFA:

1. Please don't post compress package. I did it in before. But it's
not friendly for review.

2. Post the readme and changelog to the Email body. If you like, post
the patch to the email body too. A lof of people like it.

3. Maybe you can post some test example to test the patch.

I suggest you re-send a rfa that post most thing to email body. And
if you want, you can post the url to
http://sourceware.org/gdb/wiki/ReversibleDebugging "Support i386 more
better".

Thanks,
Hui

On Sun, May 31, 2009 at 19:49, paawan oza <paawan1982@yahoo.com> wrote:
> Hello,
>
> I have been working on reversible debugging-i386 floating point support for last couple of weeks.
> I would like to submit the patch for review.
>
> please find the package attached.
> package contains following.
>
> 1) Description
> 2) ChangeLog (I am not sure it follows proper formatting)
> 3) The Patch.
>
> please consider it for review and kindly send your comments.
>
> Regards,
> Oza.
>
>
>
>
>
>
> --- On Sun, 5/31/09, Hui Zhu <teawater@gmail.com> wrote:
>
>> From: Hui Zhu <teawater@gmail.com>
>> Subject: Re: floating point support for i386 done, for record/replay
>> To: "paawan oza" <paawan1982@yahoo.com>
>> Cc: "gdb ml" <gdb@sourceware.org>
>> Date: Sunday, May 31, 2009, 11:02 AM
>> I think maybe you can post your patch
>> and your example to gdb-patch to
>> let people review it.
>>
>> Hui
>>
>> On Sun, May 31, 2009 at 01:46, paawan oza <paawan1982@yahoo.com>
>> wrote:
>> >
>> > Hi Hui,
>> > I have been going through GNU doc about how I can
>> submit the patch (floating point record support).
>> > the process looked bit complicated as the patch
>> involves more than 15 lines of change.
>> > I am not sure how to go ahead, because this is the
>> very first time I am contributing.
>> > please guide me with that.
>> > I will be waiting for your reply.
>> > Regards,
>> > Oza.
>> >
>> > --- On Thu, 5/28/09, paawan oza <paawan1982@yahoo.com>
>> wrote:
>> >
>> >> From: paawan oza <paawan1982@yahoo.com>
>> >> Subject: i386, floating point support done for
>> record/replay
>> >> To: "Hui Zhu" <teawater@gmail.com>
>> >> Cc: "gdb ml" <gdb@sourceware.org>
>> >> Date: Thursday, May 28, 2009, 1:25 PM
>> >>
>> >> Hi Hui,
>> >>
>> >> I have finished the implementation part for i386
>> floating
>> >> point support
>> >> for record/replay.
>> >> I have tested with some small programs, and it
>> gives
>> >> results as expected.
>> >> (As there are lots of floating point insns, not
>> every insn
>> >> is tested, but coding is simple)
>> >> I am quiet excited about the patch and nervous at
>> the same
>> >> time, as it is my first contribution : )
>> >> I have just concentrated mainly on making the
>> things work,
>> >> rather than optimizing it.
>> >> please feel free to suggest any design change.
>> >>
>> >> please let me know how I can go ahead.
>> >>
>> >> Regards,
>> >> Oza.
>> >>
>> >>
>> >>
>> >>
>> >> --- On Sun, 5/24/09, Hui Zhu <teawater@gmail.com>
>> >> wrote:
>> >>
>> >> > From: Hui Zhu <teawater@gmail.com>
>> >> > Subject: Re: floating point support i386
>> >> implementation partially done
>> >> > To: "paawan oza" <paawan1982@yahoo.com>
>> >> > Cc: "gdb ml" <gdb@sourceware.org>
>> >> > Date: Sunday, May 24, 2009, 9:27 AM
>> >> > On Sun, May 24, 2009 at 03:03, paawan
>> >> > oza <paawan1982@yahoo.com>
>> >> > wrote:
>> >> > >
>> >> > > Hi Hui,
>> >> > >
>> >> > > floating point support patch is over for
>> the
>> >> case
>> >> > > where ModR/M Byte is Within 00H to BFH.
>> >> > >
>> >> > > there are some doubts.
>> >> > >
>> >> > > 1) the insns like,
>> >> > > FRSTOR, FLDENV, FLDCW (which loads
>> floating
>> >> point
>> >> > environment registers like status, control,
>> tag etc..
>> >> > initializing part)
>> >> > > I think we need to record those also,
>> upon
>> >> executing
>> >> > such insns.
>> >> > > what is your opinion?
>> >> > If this reg can be access by gdb, I think you
>> need
>> >> deal
>> >> > with them.
>> >> >
>> >> > >
>> >> > >
>> >> > > otherwise, patch is ready : ),
>> >> > > of course I need to work on REG= support
>> to
>> >> finish the
>> >> > rest of the record of FPU support.
>> >> > >
>> >> > Great!
>> >> >
>> >> > Thanks,
>> >> > Hui
>> >> >
>> >>
>> >>
>> >>
>> >>
>> >
>> >
>> >
>> >
>>
>
>
>