From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66735 invoked by alias); 12 Feb 2020 00:51:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66725 invoked by uid 89); 12 Feb 2020 00:51:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-17.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=H*r:10.0.0 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Feb 2020 00:51:31 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 28C361ED42; Tue, 11 Feb 2020 19:51:29 -0500 (EST) Subject: Re: [PATCH 1/8] Don't forward-declare struct objfile in frame.h To: Tom Tromey , gdb-patches@sourceware.org References: <20200208152758.29385-1-tom@tromey.com> <20200208152758.29385-2-tom@tromey.com> From: Simon Marchi Message-ID: <343e1e02-e8cb-5512-298c-1b596dbb46a4@simark.ca> Date: Wed, 12 Feb 2020 00:51:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <20200208152758.29385-2-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg00423.txt.bz2 On 2020-02-08 10:27 a.m., Tom Tromey wrote: > dwarf2/frame.h forward-declares struct objfile, but there's no need > for this. > > gdb/ChangeLog > 2020-02-08 Tom Tromey > > * dwarf2/frame.h (struct objfile): Don't forward declare. > > Change-Id: I4d54d46ac9422eeb64dc5f0b934792e77a875aa5 > --- > gdb/ChangeLog | 4 ++++ > gdb/dwarf2/frame.h | 1 - > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/gdb/dwarf2/frame.h b/gdb/dwarf2/frame.h > index a0ec3615a45..dd7315c8515 100644 > --- a/gdb/dwarf2/frame.h > +++ b/gdb/dwarf2/frame.h > @@ -23,7 +23,6 @@ > #define DWARF2_FRAME_H 1 > > struct gdbarch; > -struct objfile; > struct frame_info; > struct dwarf2_per_cu_data; > struct agent_expr; > -- > 2.17.2 > I'd say "dwarf2/frame.h" in the subject, since there's also a frame.h in the gdb directory. But other than that, I think you could push patches like this one right away. Simon