From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78200 invoked by alias); 27 Apr 2017 09:52:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76860 invoked by uid 89); 27 Apr 2017 09:52:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR01-VE1-obe.outbound.protection.outlook.com Received: from mail-ve1eur01on0053.outbound.protection.outlook.com (HELO EUR01-VE1-obe.outbound.protection.outlook.com) (104.47.1.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Apr 2017 09:52:11 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1047.13; Thu, 27 Apr 2017 09:52:10 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::c065:778f:9924:8660]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::c065:778f:9924:8660%14]) with mapi id 15.01.1047.019; Thu, 27 Apr 2017 09:52:10 +0000 From: Alan Hayward To: Yao Qi CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH] Remove MAX_REGISTER_SIZE from regcache.c Date: Thu, 27 Apr 2017 09:52:00 -0000 Message-ID: <3418367D-9E13-49C7-9C9B-91B0DC1AB0A4@arm.com> References: <562B2F6F-F3C6-4A76-9489-57539F396C94@arm.com> <868tnvukjh.fsf@gmail.com> <7359B5C0-BF61-42E2-9886-B322C1825865@arm.com> <0DADF920-69B9-4F96-A153-6965E56B5DA8@arm.com> <868tneq1xj.fsf@gmail.com> <86efx0ljsv.fsf@gmail.com> <86r30ep4ml.fsf@gmail.com> In-Reply-To: <86r30ep4ml.fsf@gmail.com> authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com; x-microsoft-exchange-diagnostics: 1;AM3PR08MB0101;7:lMmO4fQTqmhRM0poWcJMH68VHltoGTPk+7JKRKQNTt0qk2Fbo8PblnPCNPPElM4YDa+Eww6BillyzwQvz/wkI2mb0N9zdXxGU1lqbh0Py6DmVd48RsFdN7PPcHSOOOSAEkhubmpV7Jqx2d6d743axgFQYDveTe2DhJxSgdCeUuYfphlH+kB23VOJljHrEFWUm/pnWrca42Uhob4WprThJAsJMyMd7H1P+mULHQ7ZXZek4RXD1HwXZvlIbVN+1UtYFD9vEJeGxMK8Xru0U2r0EK+rUbBOsI1hL4gCg63k8HSwlXMYpRe0vhOzHXnwyjy/pU5eERnCMPV01i1o5hzTyw== x-ms-office365-filtering-correlation-id: ad3a8dbb-1579-4318-c586-08d48d5312cc x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081);SRVR:AM3PR08MB0101; nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041248)(20161123562025)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(20161123564025)(6072148);SRVR:AM3PR08MB0101;BCL:0;PCL:0;RULEID:;SRVR:AM3PR08MB0101; x-forefront-prvs: 029097202E x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39850400002)(39450400003)(39840400002)(39860400002)(39410400002)(39400400002)(377424004)(24454002)(53936002)(6916009)(2950100002)(6506006)(33656002)(3660700001)(6436002)(6486002)(99286003)(2906002)(3280700002)(8936002)(6512007)(93886004)(8676002)(54906002)(6306002)(81166006)(2900100001)(86362001)(36756003)(305945005)(66066001)(7736002)(189998001)(39060400002)(3846002)(110136004)(4326008)(6246003)(38730400002)(25786009)(50986999)(76176999)(54356999)(6116002)(102836003)(1411001)(5250100002)(53546009)(5660300001)(83716003)(82746002)(229853002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR08MB0101;H:AM3PR08MB0101.eurprd08.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <47FA31FD5DEEE1448DB11A6B8398FC3C@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2017 09:52:10.1893 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0101 X-SW-Source: 2017-04/txt/msg00730.txt.bz2 DQo+IE9uIDI3IEFwciAyMDE3LCBhdCAxMDo0MywgWWFvIFFpIDxxaXlhb2x0 Y0BnbWFpbC5jb20+IHdyb3RlOg0KPiANCj4gQWxhbiBIYXl3YXJkIDxBbGFu LkhheXdhcmRAYXJtLmNvbT4gd3JpdGVzOg0KPiANCj4+IE9rIHRvIGNvbW1p dD8NCj4+IA0KPj4gQWxhbi4NCj4+IA0KPj4gMjAxNy0wNC0yNiAgQWxhbiBI YXl3YXJkICA8YWxhbi5oYXl3YXJkQGFybS5jb20+DQo+PiANCj4+IAkqIHJl Z2NhY2hlLmMgKHJlZ2NhY2hlX3NhdmUpOiBBdm9pZCBidWZmZXIgdXNlLg0K Pj4gCShyZWdjYWNoZV9kdW1wKTogQXZvaWQgYnVmZmVyIHVzZS4NCj4gDQo+ IEhpIEFsYW4sDQo+IFBhdGNoIGlzIGdvb2QgdG8gbWUsIGJ1dCBpdCBoYXMg Y29uZmxpY3Qgd2l0aCBteSBwYXRjaGVzDQo+IA0KPiAgW1BBVENIIDAvNl0g Q2xhc3MtZnkgcmVnY2FjaGUgaW4gR0RCDQo+ICBodHRwczovL3NvdXJjZXdh cmUub3JnL21sL2dkYi1wYXRjaGVzLzIwMTctMDQvbXNnMDA2ODQuaHRtbA0K PiANCj4gQ2FuIHlvdSBwb3N0cG9uZSBwdXNoaW5nIHRoaXMgcGF0Y2ggdW50 aWwgbXkgcGF0Y2hlcyBhcmUgY29tbWl0dGVkPyAgWW91DQo+IHRoZW4gbmVl ZCB0byByZWJhc2UgeW91ciBwYXRjaC4gIEkndmUgcmViYXNlZCBteSBwYXRj aCBzZXRzIHR3aWNlIGJlZm9yZQ0KPiBJIHBvc3RlZCB0aGVtLiAgQ29uc2lk ZXJpbmcgdGhlIHNpemUgb2YgeW91ciBwYXRjaCwgaXQgdGFrZXMgbGVzcw0K PiBlZmZvcnQgdG8gcmViYXNlIHlvdXJzLg0KPiANCg0KVGhhdOKAmXMgZmlu ZS4gTXkgcmViYXNlIHNob3VsZCBiZSBlYXN5IGVub3VnaC4NCklmIHlvdSBy ZW1lbWJlciwgY291bGQgeW91IGxldCBtZSBrbm93IHdoZW4geW91IGhhdmUg cHVzaGVkIHlvdXIgcGF0Y2guDQoNCg0KQWxhbi4NCg0K >From gdb-patches-return-138647-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Apr 27 10:12:09 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 31154 invoked by alias); 27 Apr 2017 10:12:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 31067 invoked by uid 89); 27 Apr 2017 10:12:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-spam-relays-external:209.85.192.196, H*RU:209.85.192.196, wondering X-HELO: mail-pf0-f196.google.com Received: from mail-pf0-f196.google.com (HELO mail-pf0-f196.google.com) (209.85.192.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Apr 2017 10:12:05 +0000 Received: by mail-pf0-f196.google.com with SMTP id a188so8559136pfa.2 for ; Thu, 27 Apr 2017 03:12:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=4Etiala3nNBHA9H14/1GZENhKaohZedIfQepNNXn2f8=; b=sRvXSYYHQjRIRZ4h2vgCBZUCblclEdw1OimM8Da2goKUD5XK9e2757LPC0YEoo8b+E hYoNTD91KGQKYOeBDo6IIYj6h+GNp/FybfpA+scFN06KtBRxmWGGpium9nPhLtgGfqpQ AvO/G8oh6X+rJ3yBIsSJxfdTZLfEU2F2qXL2qFwsdxHu4/TMZgO5GZx3Ej9/D9LtId/f gpPjw9KXmZxSGdQC3ZfeFPhwlxM3tfLM7IzgJioAVueLfT//+HLOryNjijJ6AenKonu5 bcFDZADnX53AgZU8k+7a9qG4oFZb6ZrQ52rYUq56WusyAO9X031+P7o0GsMX9+CwSC0T 0NiQ== X-Gm-Message-State: AN3rC/6DNya5ea9R1IythqDYVSJ+EbhFtnEsS2IcBsHZkBcJzTSVivQk F/CU0L9qN5mUuVeo1lDcUo4Wq1uZPA== X-Received: by 10.99.55.78 with SMTP id g14mr4780283pgn.191.1493287926245; Thu, 27 Apr 2017 03:12:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.155.97 with HTTP; Thu, 27 Apr 2017 03:12:05 -0700 (PDT) In-Reply-To: <86vapqp6j6.fsf@gmail.com> References: <728178DD-B9FD-4695-A7FF-F13B829DFD2E@gmail.com> <864lyfp0b7.fsf@gmail.com> <86vapqp6j6.fsf@gmail.com> From: RAJESH DASARI Date: Thu, 27 Apr 2017 10:12:00 -0000 Message-ID: Subject: Re: Reg : gdb crash is seen while attaching a process to gdb. To: Yao Qi Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2017-04/txt/msg00731.txt.bz2 Content-length: 2711 Hi , Yes it worked for me. Thanks, Rajesh Dasari. On Thu, Apr 27, 2017 at 2:32 PM, Yao Qi wrote: > RAJESH DASARI writes: > > [Move it to gdb-patches@sourceware.org] > >> Could someone please provide comments. >> >> diff --git a/gdb/mips-linux-nat.c b/gdb/mips-linux-nat.c >> index 9d22773..68641f8 100644 >> --- a/gdb/mips-linux-nat.c >> +++ b/gdb/mips-linux-nat.c >> @@ -634,9 +634,20 @@ mips_linux_new_thread (struct lwp_info *lp) >> &watch_readback_valid, 0)) >> return; >> >> + long r; >> + r=3D ptrace (PTRACE_SET_WATCH_REGS, tid, &watch_mirror, NULL); >> tid =3D ptid_get_lwp (lp->ptid); >> - if (ptrace (PTRACE_SET_WATCH_REGS, tid, &watch_mirror, NULL) =3D=3D -= 1) >> - perror_with_name (_("Couldn't write debug register")); >> + if ( r =3D=3D -1L && errno =3D=3D ESRCH ) >> + { >> + /* sleep for a while to eliminate race condition on update to ker= nel >> + * task structure with the process state (STOP state of thread). >> + */ >> + usleep(10000); >> + if ( ptrace (PTRACE_SET_WATCH_REGS, tid, &watch_mirror, NULL) =3D= =3D -1 ) >> + { >> + perror_with_name (_("Couldn't write debug register")); >> + } >> + } >> } > > I am wondering why mips_linux_read_watch_registers > (ptrace (PTRACE_GET_WATCH_REGS) is successful but > ptrace (PTRACE_SET_WATCH_REGS) fails here. Looks they may use different > lwpids. Does the patch work for you? > > -- > Yao (=E9=BD=90=E5=B0=A7) > > From dc9b626b826b26431772271c9d9a3ee343d8a1e8 Mon Sep 17 00:00:00 2001 > From: Yao Qi > Date: Thu, 27 Apr 2017 09:59:40 +0100 > Subject: [PATCH] Use lwpid from lwp_info instead of inferior_ptid > > gdb: > > 2017-04-27 Yao Qi > > * mips-linux-nat.c (mips_linux_new_thread): Get lwpid from > lwp_info instead of getting from inferior_ptid. > > diff --git a/gdb/mips-linux-nat.c b/gdb/mips-linux-nat.c > index 9596b49..c5c18fd 100644 > --- a/gdb/mips-linux-nat.c > +++ b/gdb/mips-linux-nat.c > @@ -624,14 +624,13 @@ write_watchpoint_regs (void) > static void > mips_linux_new_thread (struct lwp_info *lp) > { > - int tid; > + long tid =3D ptid_get_lwp (lp->ptid); > > - if (!mips_linux_read_watch_registers (ptid_get_lwp (inferior_ptid), > + if (!mips_linux_read_watch_registers (tid, > &watch_readback, > &watch_readback_valid, 0)) > return; > > - tid =3D ptid_get_lwp (lp->ptid); > if (ptrace (PTRACE_SET_WATCH_REGS, tid, &watch_mirror, NULL) =3D=3D -1) > perror_with_name (_("Couldn't write debug register")); > }