Re: proposed PATCH: make watchpoints work correctly

Eli Zaretskii
2003-06-02T04:19:51Z

> Date: Thu, 29 May 2003 11:17:54 -0400
> From: Paul Koning <pkoning@equallogic.com>
>
> Eli> Certainly, I understand that. I just was surprised that your
> Eli> description of the problem was so different from my recollection
> Eli> of how watchpoints work.
>
> I just ran a small test case on the x86 Linux native build of gdb 5.3,
> and the problem (step works as if it were stepi, falsely reported as a
> watchpoint hit) occurs there as well -- just as expected.

Thanks, I now see the problem.

I think your solution is correct, but I'd like to minimize the number
of calls to target_stopped_data_address (they might be expensive).
Since the code already does call that function that elsewhere, could
we just reuse the result of that call, or rearrange your patch so that
a single call would do?

Otherwise, I think your change should go in. Thanks.